fix(market): populate combined address list so portfolio sees addresses
The Market-tab portfolio (editor checklist + SumPortfolioBalance) reads the combined WalletState::addresses view, but the full-node refresh path only ever updated the authoritative z_addresses/t_addresses lists — rebuildAddressList() was never called, so `addresses` stayed empty. Result: the manage-portfolio modal showed no addresses to pick, and addresses added via the overview right-click menu contributed no value to their entry (SumPortfolioBalance found nothing in the empty combined list). Rebuild the combined view in NetworkRefreshService::applyAddressRefreshResult (the sole bulk updater of the address lists), and push newly created addresses into the combined view immediately in the full-node create paths for zero-latency parity with the overview (matching the lite branch). This also repairs two other silently-broken full-node consumers of state.addresses: the auto-shield target-address finder and the pool-mining transparent fallback. Add a regression test (testWalletStateAddressListRebuild) covering the empty-before / union-after rebuild and pending-send delta reflection. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -1255,6 +1255,11 @@ void NetworkRefreshService::applyAddressRefreshResult(WalletState& state,
|
||||
{
|
||||
state.z_addresses = std::move(result.shieldedAddresses);
|
||||
state.t_addresses = std::move(result.transparentAddresses);
|
||||
// Keep the combined `addresses` view in sync with the authoritative z/t lists.
|
||||
// Consumers that read state.addresses (Market-tab portfolio, auto-shield target
|
||||
// selection, pool-mining transparent fallback) depend on this being rebuilt — the
|
||||
// full-node refresh path is the only place that bulk-updates the address lists.
|
||||
state.rebuildAddressList();
|
||||
}
|
||||
|
||||
void NetworkRefreshService::applyTransactionRefreshResult(WalletState& state,
|
||||
|
||||
Reference in New Issue
Block a user