refactor(lite): remove dead parallel refresh/readiness scaffolding (~3.1k lines)

The lite-wallet tree carried a second, unused refresh+readiness architecture
that never reached the shipping binary — exactly the churn CLAUDE.md warns
against. The live refresh path is controller -> gateway.refresh ->
mapLiteWalletRefreshResult -> applyLiteRefreshModelToWalletState; this parallel
stack was dead weight.

Verified unused (their public types/functions are referenced only within the
cluster), then deleted (8 files / 16 incl. headers):
- lite_wallet_refresh_service            (LiteWalletRefreshService + gateway adapters)
- lite_wallet_app_refresh_coordinator
- lite_wallet_app_refresh_orchestrator
- lite_wallet_refresh_readiness_policy
- lite_wallet_state_apply_plan
- lite_wallet_state_apply_executor
- lite_wallet_sync_app_refresh_integration
- lite_wallet_sync_execution_readiness

Severed three thin couplings into the cluster from live files:
- state_mapper: dropped the dead mapLiteWalletRefreshServiceResult and switched
  its include from refresh_service.h to gateway.h (where the live
  LiteWalletRefreshResult/Bundle DTOs actually live).
- server_lifecycle_readiness: dropped the unused syncLifecycleInput member +
  converter and the sync_app_refresh_integration include.
- artifact_resolver: relocated the three LIVE artifact-input structs
  (LiteWalletSdxlArtifact{Symbols,}Input, LiteWalletLinkedBackendReadinessInput)
  out of sync_execution_readiness.h — their only real consumers — into
  artifact_resolver.h, then dropped the include.

Also removed the dead DRAGONX_LONG_LITE_BATCH CMake machinery (its source var
was empty; on Windows it generated a broken lite_batch90_receipt_plan.cpp that
#included an empty path) and the stale .cpp/.h entries in CMakeLists.

Lite source files: 44 -> 30. Lite + full-node configure, both targets build,
test suite passes, source-hygiene clean.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
2026-06-05 12:25:02 -05:00
parent 6a4e98b7ed
commit 6611d57147
22 changed files with 33 additions and 3141 deletions

View File

@@ -377,26 +377,6 @@ set(QRCODE_SOURCES
# Application Sources
# -----------------------------------------------------------------------------
# MinGW writes .obj.d dependency files, so this overlong generated source name
# needs a short wrapper to stay under the Windows filename component limit.
set(DRAGONX_LONG_LITE_BATCH_SOURCE
)
set(DRAGONX_LONG_LITE_BATCH_COMPILE_SOURCE ${DRAGONX_LONG_LITE_BATCH_SOURCE})
if(WIN32)
set(DRAGONX_LONG_LITE_BATCH_COMPILE_SOURCE
${CMAKE_BINARY_DIR}/generated/short_sources/lite_batch90_receipt_plan.cpp
)
file(MAKE_DIRECTORY ${CMAKE_BINARY_DIR}/generated/short_sources)
file(WRITE ${DRAGONX_LONG_LITE_BATCH_COMPILE_SOURCE}
"#include \"${CMAKE_SOURCE_DIR}/${DRAGONX_LONG_LITE_BATCH_SOURCE}\"\n"
)
set_source_files_properties(${DRAGONX_LONG_LITE_BATCH_COMPILE_SOURCE}
PROPERTIES
GENERATED TRUE
OBJECT_DEPENDS ${CMAKE_SOURCE_DIR}/${DRAGONX_LONG_LITE_BATCH_SOURCE}
)
endif()
set(APP_SOURCES
src/main.cpp
src/app.cpp
@@ -418,17 +398,8 @@ set(APP_SOURCES
src/wallet/lite_result_parsers.cpp
src/wallet/lite_sync_service.cpp
src/wallet/lite_wallet_gateway.cpp
src/wallet/lite_wallet_refresh_service.cpp
src/wallet/lite_wallet_state_mapper.cpp
src/wallet/lite_wallet_state_apply_plan.cpp
src/wallet/lite_wallet_state_apply_executor.cpp
src/wallet/lite_wallet_app_refresh_coordinator.cpp
src/wallet/lite_wallet_refresh_readiness_policy.cpp
src/wallet/lite_wallet_app_refresh_orchestrator.cpp
src/wallet/lite_wallet_sync_app_refresh_integration.cpp
src/wallet/lite_wallet_sync_execution_readiness.cpp
src/wallet/lite_wallet_lifecycle_ui_adapter.cpp
${DRAGONX_LONG_LITE_BATCH_COMPILE_SOURCE}
src/wallet/lite_wallet_server_selection_adapter.cpp
src/wallet/lite_wallet_server_lifecycle_readiness.cpp
src/wallet/lite_wallet_lifecycle_service.cpp
@@ -542,15 +513,7 @@ set(APP_HEADERS
src/wallet/lite_result_parsers.h
src/wallet/lite_sync_service.h
src/wallet/lite_wallet_gateway.h
src/wallet/lite_wallet_refresh_service.h
src/wallet/lite_wallet_state_mapper.h
src/wallet/lite_wallet_state_apply_plan.h
src/wallet/lite_wallet_state_apply_executor.h
src/wallet/lite_wallet_app_refresh_coordinator.h
src/wallet/lite_wallet_refresh_readiness_policy.h
src/wallet/lite_wallet_app_refresh_orchestrator.h
src/wallet/lite_wallet_sync_app_refresh_integration.h
src/wallet/lite_wallet_sync_execution_readiness.h
src/wallet/lite_wallet_lifecycle_ui_adapter.h
src/wallet/lite_wallet_server_selection_adapter.h
src/wallet/lite_wallet_server_lifecycle_readiness.h
@@ -985,17 +948,8 @@ if(BUILD_TESTING)
src/wallet/lite_result_parsers.cpp
src/wallet/lite_sync_service.cpp
src/wallet/lite_wallet_gateway.cpp
src/wallet/lite_wallet_refresh_service.cpp
src/wallet/lite_wallet_state_mapper.cpp
src/wallet/lite_wallet_state_apply_plan.cpp
src/wallet/lite_wallet_state_apply_executor.cpp
src/wallet/lite_wallet_app_refresh_coordinator.cpp
src/wallet/lite_wallet_refresh_readiness_policy.cpp
src/wallet/lite_wallet_app_refresh_orchestrator.cpp
src/wallet/lite_wallet_sync_app_refresh_integration.cpp
src/wallet/lite_wallet_sync_execution_readiness.cpp
src/wallet/lite_wallet_lifecycle_ui_adapter.cpp
${DRAGONX_LONG_LITE_BATCH_COMPILE_SOURCE}
src/wallet/lite_wallet_server_selection_adapter.cpp
src/wallet/lite_wallet_server_lifecycle_readiness.cpp
src/wallet/lite_wallet_lifecycle_service.cpp