fix(chat): harden reply-target + scrub legacy secret (B2/B4)
B4: the legacy chat-identity fallback copied the z_exportkey spending key out of the RPC response and let the temporary json destruct un-zeroed. Mirror the mnemonic path — take our copy, then sodium_memzero the json's own buffer. B2: the memo header's peer z-address / cid ride OUTSIDE the secretstream AEAD, so trusting the newest message's header let a later message redirect our replies or splice threads. Pin the reply target (and displayed peer) to the EARLIEST (establishing) message instead of the latest, at both the send and display sites. Because ChatStore returned filtered INSERTION order (a scan harvests txids in set/hash order — not chronological), "earliest" wasn't reliable; ChatStore:: conversation now returns messages sorted by (timestamp, txid, payload_position), which also fixes out-of-order thread rendering and the last-message preview. A complete fix binds z+cid into the AEAD additional-data, but that's a coordinated HushChat/SDXLite wire-format change; this pin hardens the reply target without it. Adversarially verified; the store-ordering gap it surfaced is fixed here. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -2,6 +2,8 @@
|
||||
|
||||
#include "chat_store.h"
|
||||
|
||||
#include <algorithm>
|
||||
|
||||
namespace dragonx::chat {
|
||||
|
||||
std::string ChatStore::dedupKey(const ChatMessage& message) {
|
||||
@@ -19,6 +21,16 @@ std::vector<ChatMessage> ChatStore::conversation(const std::string& conversation
|
||||
for (const auto& message : messages_) {
|
||||
if (message.conversation_id == conversationId) out.push_back(message);
|
||||
}
|
||||
// Return chronological (oldest→newest). messages_ is in scan/insertion order, which is NOT
|
||||
// time-ordered (a full scan harvests txids in std::set/unordered_map order) — that would mis-order the
|
||||
// rendered thread AND let the reply-target pin (first-seen peer address) latch onto a non-establishing
|
||||
// message (B2). timestamp is the block/tx time (peer can't set it); tie-break txid + payload_position
|
||||
// for determinism.
|
||||
std::stable_sort(out.begin(), out.end(), [](const ChatMessage& a, const ChatMessage& b) {
|
||||
if (a.timestamp != b.timestamp) return a.timestamp < b.timestamp;
|
||||
if (a.txid != b.txid) return a.txid < b.txid;
|
||||
return a.payload_position < b.payload_position;
|
||||
});
|
||||
return out;
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user