refactor(lite): drop 4 unused OOP wrapper classes over free functions
Each of these classes wrapped an existing free function with a one-line delegating method and was never instantiated anywhere (verified: no references outside their own translation unit, not even within their own .cpp beyond the definition) — the redundant "wrapper layer" pattern CLAUDE.md warns against: - LiteWalletLifecycleUiExecutionAdapter -> executeLiteWalletLifecycleUiRequest - LiteWalletServerSelectionUiExecutionAdapter -> executeLiteWalletServerSelectionUi - LiteWalletServerLifecycleReadinessPlanner -> evaluateLiteWalletServerLifecycleReadiness - LiteBackendActivationReadinessAdapter -> evaluateLiteBackendActivationReadiness The live free functions (the actual entry points used by the UI/runtime) are unchanged. Both targets build, test suite passes, source-hygiene clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
@@ -910,16 +910,4 @@ LiteBackendArtifactResolverResult LiteBackendArtifactResolver::resolve(
|
|||||||
return evaluateLiteBackendArtifactResolver(input, options_);
|
return evaluateLiteBackendArtifactResolver(input, options_);
|
||||||
}
|
}
|
||||||
|
|
||||||
LiteBackendActivationReadinessAdapter::LiteBackendActivationReadinessAdapter(
|
|
||||||
LiteBackendActivationReadinessOptions options)
|
|
||||||
: options_(options)
|
|
||||||
{
|
|
||||||
}
|
|
||||||
|
|
||||||
LiteBackendActivationReadinessResult LiteBackendActivationReadinessAdapter::evaluate(
|
|
||||||
const LiteBackendActivationReadinessInput& input) const
|
|
||||||
{
|
|
||||||
return evaluateLiteBackendActivationReadiness(input, options_);
|
|
||||||
}
|
|
||||||
|
|
||||||
} // namespace dragonx::wallet
|
} // namespace dragonx::wallet
|
||||||
|
|||||||
@@ -431,14 +431,4 @@ private:
|
|||||||
LiteBackendArtifactResolverOptions options_;
|
LiteBackendArtifactResolverOptions options_;
|
||||||
};
|
};
|
||||||
|
|
||||||
class LiteBackendActivationReadinessAdapter {
|
|
||||||
public:
|
|
||||||
explicit LiteBackendActivationReadinessAdapter(LiteBackendActivationReadinessOptions options = {});
|
|
||||||
|
|
||||||
LiteBackendActivationReadinessResult evaluate(const LiteBackendActivationReadinessInput& input) const;
|
|
||||||
|
|
||||||
private:
|
|
||||||
LiteBackendActivationReadinessOptions options_;
|
|
||||||
};
|
|
||||||
|
|
||||||
} // namespace dragonx::wallet
|
} // namespace dragonx::wallet
|
||||||
|
|||||||
@@ -424,17 +424,5 @@ LiteWalletLifecycleUiExecutionResult executeLiteWalletLifecycleUiRequest(
|
|||||||
return result;
|
return result;
|
||||||
}
|
}
|
||||||
|
|
||||||
LiteWalletLifecycleUiExecutionAdapter::LiteWalletLifecycleUiExecutionAdapter(
|
|
||||||
config::Settings& settings)
|
|
||||||
: settings_(settings)
|
|
||||||
{
|
|
||||||
}
|
|
||||||
|
|
||||||
LiteWalletLifecycleUiExecutionResult LiteWalletLifecycleUiExecutionAdapter::execute(
|
|
||||||
const LiteWalletLifecycleUiExecutionInput& input) const
|
|
||||||
{
|
|
||||||
return executeLiteWalletLifecycleUiRequest(settings_, input);
|
|
||||||
}
|
|
||||||
|
|
||||||
} // namespace wallet
|
} // namespace wallet
|
||||||
} // namespace dragonx
|
} // namespace dragonx
|
||||||
@@ -131,16 +131,5 @@ LiteWalletLifecycleUiExecutionResult executeLiteWalletLifecycleUiRequest(
|
|||||||
config::Settings& settings,
|
config::Settings& settings,
|
||||||
const LiteWalletLifecycleUiExecutionInput& input);
|
const LiteWalletLifecycleUiExecutionInput& input);
|
||||||
|
|
||||||
class LiteWalletLifecycleUiExecutionAdapter {
|
|
||||||
public:
|
|
||||||
explicit LiteWalletLifecycleUiExecutionAdapter(config::Settings& settings);
|
|
||||||
|
|
||||||
LiteWalletLifecycleUiExecutionResult execute(
|
|
||||||
const LiteWalletLifecycleUiExecutionInput& input) const;
|
|
||||||
|
|
||||||
private:
|
|
||||||
config::Settings& settings_;
|
|
||||||
};
|
|
||||||
|
|
||||||
} // namespace wallet
|
} // namespace wallet
|
||||||
} // namespace dragonx
|
} // namespace dragonx
|
||||||
@@ -383,16 +383,4 @@ LiteWalletServerLifecycleReadinessResult evaluateLiteWalletServerLifecycleReadin
|
|||||||
return result;
|
return result;
|
||||||
}
|
}
|
||||||
|
|
||||||
LiteWalletServerLifecycleReadinessPlanner::LiteWalletServerLifecycleReadinessPlanner(
|
|
||||||
LiteWalletServerLifecycleReadinessOptions options)
|
|
||||||
: options_(options)
|
|
||||||
{
|
|
||||||
}
|
|
||||||
|
|
||||||
LiteWalletServerLifecycleReadinessResult LiteWalletServerLifecycleReadinessPlanner::evaluate(
|
|
||||||
const LiteWalletServerLifecycleReadinessInput& input) const
|
|
||||||
{
|
|
||||||
return evaluateLiteWalletServerLifecycleReadiness(input, options_);
|
|
||||||
}
|
|
||||||
|
|
||||||
} // namespace dragonx::wallet
|
} // namespace dragonx::wallet
|
||||||
@@ -178,16 +178,4 @@ LiteWalletServerLifecycleReadinessResult evaluateLiteWalletServerLifecycleReadin
|
|||||||
const LiteWalletServerLifecycleReadinessInput& input,
|
const LiteWalletServerLifecycleReadinessInput& input,
|
||||||
LiteWalletServerLifecycleReadinessOptions options = {});
|
LiteWalletServerLifecycleReadinessOptions options = {});
|
||||||
|
|
||||||
class LiteWalletServerLifecycleReadinessPlanner {
|
|
||||||
public:
|
|
||||||
explicit LiteWalletServerLifecycleReadinessPlanner(
|
|
||||||
LiteWalletServerLifecycleReadinessOptions options = {});
|
|
||||||
|
|
||||||
LiteWalletServerLifecycleReadinessResult evaluate(
|
|
||||||
const LiteWalletServerLifecycleReadinessInput& input) const;
|
|
||||||
|
|
||||||
private:
|
|
||||||
LiteWalletServerLifecycleReadinessOptions options_;
|
|
||||||
};
|
|
||||||
|
|
||||||
} // namespace dragonx::wallet
|
} // namespace dragonx::wallet
|
||||||
@@ -447,17 +447,5 @@ LiteWalletServerSelectionUiExecutionResult executeLiteWalletServerSelectionUi(
|
|||||||
return result;
|
return result;
|
||||||
}
|
}
|
||||||
|
|
||||||
LiteWalletServerSelectionUiExecutionAdapter::LiteWalletServerSelectionUiExecutionAdapter(
|
|
||||||
config::Settings& settings)
|
|
||||||
: settings_(settings)
|
|
||||||
{
|
|
||||||
}
|
|
||||||
|
|
||||||
LiteWalletServerSelectionUiExecutionResult LiteWalletServerSelectionUiExecutionAdapter::execute(
|
|
||||||
const LiteWalletServerSelectionUiExecutionInput& input) const
|
|
||||||
{
|
|
||||||
return executeLiteWalletServerSelectionUi(settings_, input);
|
|
||||||
}
|
|
||||||
|
|
||||||
} // namespace wallet
|
} // namespace wallet
|
||||||
} // namespace dragonx
|
} // namespace dragonx
|
||||||
@@ -146,16 +146,5 @@ LiteWalletServerSelectionUiExecutionResult executeLiteWalletServerSelectionUi(
|
|||||||
config::Settings& settings,
|
config::Settings& settings,
|
||||||
const LiteWalletServerSelectionUiExecutionInput& input);
|
const LiteWalletServerSelectionUiExecutionInput& input);
|
||||||
|
|
||||||
class LiteWalletServerSelectionUiExecutionAdapter {
|
|
||||||
public:
|
|
||||||
explicit LiteWalletServerSelectionUiExecutionAdapter(config::Settings& settings);
|
|
||||||
|
|
||||||
LiteWalletServerSelectionUiExecutionResult execute(
|
|
||||||
const LiteWalletServerSelectionUiExecutionInput& input) const;
|
|
||||||
|
|
||||||
private:
|
|
||||||
config::Settings& settings_;
|
|
||||||
};
|
|
||||||
|
|
||||||
} // namespace wallet
|
} // namespace wallet
|
||||||
} // namespace dragonx
|
} // namespace dragonx
|
||||||
Reference in New Issue
Block a user