test(daemon): add F1/F2 process-lifecycle integration tests; fix clobbered start error

Links the real EmbeddedDaemon into the ObsidianDragonTests target (its deps were
already present) and adds two POSIX integration tests that exercise the actual
fork/exec/waitpid fixes headlessly:

- testExecFailureReported (F2): start() against a non-executable file must fail with a
  precise "not executable or wrong architecture" reason.
- testDaemonCrashDetected (F1): a short-lived child that exits abnormally is still
  detected (crash_count_ increments) while isRunning() is hammered from the test
  thread — a regression test for the reap race.

Writing the F2 test surfaced a real bug: start()'s failure branch called
setState(State::Error, "Failed to start dragonxd process"), and setState stores the
Error message into last_error_ — clobbering the precise message startProcess() had
just set, so getLastError()/the UI only ever saw the generic string. Fixed to pass the
preserved detail to setState, so the precise reason survives and now also reaches the
state callback (crash panel / status).

ctest 1/1, green including the two new integration tests.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

This commit is contained in:

DanS

2026-08-02 13:11:15 -05:00

parent ff5f5ddf23

commit d188a08db7

4 changed files with 71 additions and 5 deletions

									
										1

CMakeLists.txt
									
												View File
												
				@@ -1129,6 +1129,7 @@ if(BUILD_TESTING)

				        src/data/address_book.cpp

				        src/data/wallet_index.cpp

				        src/daemon/lifecycle_adapters.cpp

				        src/daemon/embedded_daemon.cpp

				        src/rpc/connection.cpp

				        src/config/settings.cpp

				        src/resources/embedded_resources.cpp

test(daemon): add F1/F2 process-lifecycle integration tests; fix clobbered start error

1 CMakeLists.txt Unescape Escape View File

1

CMakeLists.txt

View File