refactor(audit): batch 7 — RPC/settings/lite/effects mechanical dedups

Six behavior-preserving consolidations from the audit:

- RPCClient::call() overloads share a private performCall() (payload dump +
  curl_easy_perform + http code) and a static parseRpcResult() (error->RpcError
  extraction). The timeout overload restores the prior timeout in both the
  success and catch paths, exactly as before.
- The six UnifiedCallback methods delegate to one splitUnified() that builds
  the (Callback, ErrorCallback) pair once (null-check preserved).
- One liteTrimCopy() in lite_connection_service replaces 5 file-local
  trim-copy helpers across the lite slice.
- lite_wallet_controller's inline height JSON parse now routes through the
  tested parseLiteHeightResponse().
- theme_effects.cpp: unpackRGB()/scaledAlpha() replace 14 RGB-unpack + 5
  alpha-scale copy-paste blocks.
- settings.cpp load() uses loadScalar()/loadClamped() helpers for ~44 scalar
  fields. Besides removing boilerplate this HARDENS loading: ~44 fields that
  previously only checked contains() now also verify the JSON type, so a
  malformed value in settings.json falls back to the default instead of
  throwing/misreading. Custom cases (enum parses, legacy migrations, arrays)
  stay inline; save() is unchanged.

Full-node + Lite build clean; ctest 1/1; hygiene clean.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

src/wallet/lite_wallet_lifecycle_service.cpp

@@ -4,7 +4,6 @@
 
 #include "lite_wallet_lifecycle_service.h"
 
-#include <cctype>
 #include <utility>
 
 namespace dragonx {
@@ -12,17 +11,6 @@ namespace wallet {
 
 namespace {
 
-std::string trimLifecycleCopy(const std::string& value)
-{
-    auto begin = value.begin();
-    while (begin != value.end() && std::isspace(static_cast<unsigned char>(*begin))) ++begin;
-
-    auto end = value.end();
-    while (end != begin && std::isspace(static_cast<unsigned char>(*(end - 1)))) --end;
-
-    return std::string(begin, end);
-}
-
 LiteRedactedPrivateData redactedField(LitePrivateDataKind kind, const std::string& value)
 {
     return LiteRedactedPrivateData{kind, !value.empty(), redactLitePrivateDataValue(value)};
@@ -172,7 +160,7 @@ LiteWalletLifecyclePlan LiteWalletLifecycleService::planOpenWallet(
 LiteWalletLifecyclePlan LiteWalletLifecycleService::planRestoreWallet(
     const LiteWalletRestoreRequest& request) const
 {
-    const std::string validationError = trimLifecycleCopy(request.seedPhrase).empty()
+    const std::string validationError = liteTrimCopy(request.seedPhrase).empty()
         ? "restore seed phrase is required"
         : std::string();
     return makePlan(LiteWalletLifecycleOperation::RestoreFromSeed,
@@ -220,7 +208,7 @@ LiteWalletLifecycleResult LiteWalletLifecycleService::restoreWallet(
 LiteServerSelectionResult LiteWalletLifecycleService::selectServerForRequest(
     const std::string& serverUrl) const
 {
-    const std::string overrideUrl = trimLifecycleCopy(serverUrl);
+    const std::string overrideUrl = liteTrimCopy(serverUrl);
     if (!overrideUrl.empty()) {
         if (!isLiteServerUrlUsable(overrideUrl)) {
             return LiteServerSelectionResult{false, {}, 0, false, "lite lifecycle server URL is not usable"};