DragonX/ObsidianDragon
1
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 10 Wiki Activity

fix(chat): drop a redundant save and report a real contact-save result

Browse Source 
Renaming or adding a contact from the chat tab called the address-book
mutator and then saved again, even though the mutator already persists.
It also reported success unconditionally, so a failed rename still
showed a success toast.

- The redundant explicit save is removed; the mutator's own save stands.
- A rename now shows success only when the mutator succeeds and an error
  toast when it does not.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
DanS
2026-10-13 16:00:10 -05:00
co-authored by Claude Opus 4.8
parent 2a3e88c8dc
commit f76d71fede
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ui/windows/chat_tab.cpp
+5 -5
View File
@@ -1118,12 +1118,12 @@ void RenderChatTab(App* app)
if (nm != book.entries()[bookIdx].label) { // skip a no-op rewrite/save if (nm != book.entries()[bookIdx].label) { // skip a no-op rewrite/save
data::AddressBookEntry e = book.entries()[bookIdx]; data::AddressBookEntry e = book.entries()[bookIdx];
e.label = nm; // keep address/notes/scope/avatar e.label = nm; // keep address/notes/scope/avatar
book.updateEntry(static_cast<std::size_t>(bookIdx), e); if (book.updateEntry(static_cast<std::size_t>(bookIdx), e)) // mutator already saves
book.save(); Notifications::instance().success(TR("chat_renamed"));
Notifications::instance().success(TR("chat_renamed")); else
Notifications::instance().error(TR("address_book_update_failed"));
} }
} else if (book.addEntry(data::AddressBookEntry(nm, sel->peerZaddr))) { } else if (book.addEntry(data::AddressBookEntry(nm, sel->peerZaddr))) { // mutator already saves
book.save();
Notifications::instance().success(TR("chat_contact_added")); Notifications::instance().success(TR("chat_contact_added"));
} else { } else {
Notifications::instance().error(TR("address_book_exists")); Notifications::instance().error(TR("address_book_exists"));