DragonX/ObsidianDragon
1
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 4 Wiki Activity

fix(rpc): invalidate stale in-flight refreshes on reset/reconnect

Browse Source 
resetJobs() cleared the in-progress flags but left generations_ untouched, so a
refresh WorkFn still executing on the worker when a disconnect cleared state_
could pass completeDispatch's generation check and apply last-connection data
onto the new session. Bump every job's generation in resetJobs() so any
pre-reset ticket is treated as stale.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
DanS
2026-06-07 14:25:44 -05:00
parent 8c2c1c2aaf
commit fc438ab962
1 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/services/network_refresh_service.cpp
View File

@@ -1310,6 +1310,13 @@ void NetworkRefreshService::resetJobs()
priceInProgress_.store(false, std::memory_order_release); priceInProgress_.store(false, std::memory_order_release);
encryptionInProgress_.store(false, std::memory_order_release); encryptionInProgress_.store(false, std::memory_order_release);
connectionInitInProgress_.store(false, std::memory_order_release); connectionInitInProgress_.store(false, std::memory_order_release);
// Bump every job's generation so any ticket minted before this reset (a refresh still
// in flight on the worker when a disconnect cleared state_) is treated as stale by
// completeDispatch — preventing last-connection data from landing on the new session.
for (auto& generation : generations_) {
generation.fetch_add(1, std::memory_order_acq_rel);
}
} }
NetworkRefreshService::DispatchTicket NetworkRefreshService::beginDispatch( NetworkRefreshService::DispatchTicket NetworkRefreshService::beginDispatch(