DanS
76093fe82d
Four confirmed findings from the review of ef247c9:
1. Persistence regression — the deferred-persist echo (in-memory Sending, written
only when the async callback resolved) meant a message broadcast on-chain but
whose callback hadn't fired yet was LOST from history if the app quit/crashed
in that window. Persist the echo immediately as Sending and UPSERT the final
status on resolve (new ChatDatabase::upsert with ON CONFLICT DO UPDATE, since
append is INSERT-OR-IGNORE). A stray persisted Sending still loads as Sent.
2. Fee ceiling — dragonxd REJECTS a 0-value tx whose fee exceeds the default
miners fee (0.0001), and max(getDefaultFee(), 0.0001) can only raise it, so a
default_fee > 0.0001 broke every chat send. Pin chat to exactly kChatMinFeeDrgx,
dropping getDefaultFee() from this path (chat always moves 0 value).
3. Lifetime — the resolve callback had no generation guard, so a wallet lock (which
doesn't disconnect) between submit and callback could resolve against a cleared
store. Capture chat_session_generation_ and bail on mismatch (both the full-node
callback and the lite optimistic resolve), matching the identity-fetch pattern.
4. Retry misdirect — Retry on a failed CONTACT REQUEST called sendChatMessage,
which (no peer key yet) just showed "waiting for reply". Route it to
sendContactRequestForCid() (refactored out of startChatConversation) so it
re-sends the request into the SAME conversation.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
80 lines
3.3 KiB
C++
80 lines
3.3 KiB
C++
#pragma once
|
|
|
|
// DragonX Wallet - HushChat persistent message store (Phase 2).
|
|
//
|
|
// Sqlite-backed, encrypted at rest with a SEED-DERIVED key (no wallet passphrase). Every record —
|
|
// message bodies, peer z-addresses, threading (conversation id), and timestamps — is AEAD-encrypted
|
|
// under a key derived from the wallet's own seed secret (the same secret used for the chat
|
|
// identity), and even the per-message dedup key is a KEYED hash of the txid — so the database
|
|
// reveals nothing about your conversations to disk-level access without the seed. Rows are
|
|
// partitioned by a seed-derived wallet tag so one file can hold several wallets, each readable only
|
|
// with its own seed. Not thread-safe — drive from the main thread. Mirrors the lifecycle of
|
|
// data::TransactionHistoryCache.
|
|
|
|
#include "chat_message.h"
|
|
|
|
#include <array>
|
|
#include <cstddef>
|
|
#include <string>
|
|
#include <vector>
|
|
|
|
struct sqlite3;
|
|
|
|
namespace dragonx::chat {
|
|
|
|
class ChatDatabase {
|
|
public:
|
|
ChatDatabase();
|
|
explicit ChatDatabase(std::string databasePath);
|
|
~ChatDatabase();
|
|
|
|
ChatDatabase(const ChatDatabase&) = delete;
|
|
ChatDatabase& operator=(const ChatDatabase&) = delete;
|
|
|
|
static std::string defaultDatabasePath();
|
|
|
|
// Derive the storage key + wallet tag from the wallet's seed secret and open the DB. The caller
|
|
// still owns and must wipe `secret`. Returns false on sodium/db failure (DB then stays locked).
|
|
bool unlockWithSecret(const std::string& secret);
|
|
void lock(); // wipe the key material (DB handle stays open); load()/append() then no-op
|
|
bool hasKey() const { return key_ready_; }
|
|
|
|
// Persist one message (INSERT OR IGNORE, deduped by a keyed hash of txid+payload_position).
|
|
// Returns true if newly inserted; false on duplicate or while locked.
|
|
bool append(const ChatMessage& message);
|
|
|
|
// Persist-or-overwrite one message by its (txid+position) dedup key. Unlike append(), this
|
|
// updates an existing row's payload — used for outgoing echoes whose delivery status changes
|
|
// (Sending → Sent/Failed). Returns true on success; false while locked / on error.
|
|
bool upsert(const ChatMessage& message);
|
|
|
|
// Decrypt and return every stored message for the unlocked wallet, in insertion order. Empty
|
|
// while locked or if none. Rows that fail to decrypt/parse are skipped.
|
|
std::vector<ChatMessage> load();
|
|
|
|
void clearWallet(); // delete the unlocked wallet's rows
|
|
|
|
private:
|
|
bool ensureOpen();
|
|
bool exec(const char* sql);
|
|
bool createSchema();
|
|
std::string dedupHash(const std::string& txid, std::size_t position) const;
|
|
std::string serialize(const ChatMessage& message) const;
|
|
bool deserialize(const std::string& json, ChatMessage& out) const;
|
|
bool encrypt(const std::string& plain,
|
|
std::vector<unsigned char>& nonce,
|
|
std::vector<unsigned char>& cipher) const;
|
|
bool decrypt(const std::vector<unsigned char>& nonce,
|
|
const std::vector<unsigned char>& cipher,
|
|
std::string& plain) const;
|
|
void close();
|
|
|
|
sqlite3* db_ = nullptr;
|
|
std::string database_path_;
|
|
std::array<unsigned char, 32> key_{}; // AEAD storage key (seed-derived)
|
|
std::string wallet_tag_; // seed-derived row partition (a keyed hash, hex)
|
|
bool key_ready_ = false;
|
|
};
|
|
|
|
} // namespace dragonx::chat
|