From 04ec2be8c882e44fdee17cfd4caa1512512dd74a Mon Sep 17 00:00:00 2001 From: Duke Date: Fri, 22 Aug 2025 13:17:36 -0400 Subject: [PATCH] Add fullyNotified to getblockchaininfo and use it in tests --- qa/rpc-tests/test_framework/util.py | 2 -- src/rpc/blockchain.cpp | 6 ++++++ 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/qa/rpc-tests/test_framework/util.py b/qa/rpc-tests/test_framework/util.py index ff1115b88..98d045442 100644 --- a/qa/rpc-tests/test_framework/util.py +++ b/qa/rpc-tests/test_framework/util.py @@ -57,8 +57,6 @@ def sync_blocks(rpc_connections, wait=1): break time.sleep(wait) - return - # Now that the block counts are in sync, wait for the internal # notifications to finish while True: diff --git a/src/rpc/blockchain.cpp b/src/rpc/blockchain.cpp index abcc49c45..5f1394a80 100644 --- a/src/rpc/blockchain.cpp +++ b/src/rpc/blockchain.cpp @@ -1335,6 +1335,12 @@ UniValue getblockchaininfo(const UniValue& params, bool fHelp, const CPubKey& my obj.push_back(Pair("pruneheight", block->GetHeight())); } + + // this helps our tests work correctly + if (Params().NetworkIDString() == "regtest") { + obj.pushKV("fullyNotified", ChainIsFullyNotified()); + } + return obj; }