Jl777 (#1315)

* Remove voutsum check

* Teach RPC interface about dpow-enabled minconfs (#1231)

* Make minconfs dpow-aware in z_listunspent + z_listreceivedbyaddress

* Add dpow-related test files to test suite

* Add dpow simulation to regtest every 7 blocks

* Fix compiler errors

* Fix link error

* Fix stdout spam when running regtests

* Dpowminconfs for listreceivedbyaddress

* dpowconfs tests

* Start adding specific tests for dpowminconfs in listreceivedbyaddress

* Get dpowminconfs tests for listreceivedbyaddress working

* Add dpowminconfs to getreceivedbyaddress + listunspent

* Add test for listtransactions + getreceivedbyaddress support

* Reliably passing dpowminconf tests. We only check for notarized-ness now, not exact confirmation numbers, to avoid race conditions

* Poll for the expected notarization info before running further tests; add support for getbalance

* Migrate tx_height() to a place where asyncrpcoperation_sendmany.cpp can use it

* fix

* Teach GetFilteredNotes about dpowconfs

Many RPCs rely on this internal function, which now correctly uses
dpowconfs to filter by the minconf/maxconf parameters.

* Fix sendmany when using non-default minconf

* inline seems to make things happy

* cleanup

* Add some code to test z_sendmany, which points out https://github.com/jl777/komodo/issues/1247

* try this

* Use already calculated value of dpowconfs instead of calculating it again

* Cleanup .pack file

* Remove

* Remove .pack

* Disable passkeys

* Rvalidate

* Syntax

* Allow overwrite by same pub33

* Tx

* Declare variables

* Allow replacement handle

* Grandfather existing handles

* Test

* Handleinfo

* Char *

* Begin

* Add mutex

* CCaddr

* Casts for windows

* +debugs

* Syntax

* Item

* Skeet

* +print

* Error check things

* +prints

* -sleep

* Brute force inventory check

* Revert

* num_packitems

* Log file

* Test

* ABC

* Test

* Add help docs for all -ac_* params of komodod (#1313)

* Remove myAddress from roc

* +print

* Test

* Test

* Leave pack all

* Dont discard unless last o_count

* Prevent pack corruption

* -ddebugs

* Merge branch 'FSM' into jl777

# Conflicts:
#	src/cc/rogue/main.c

src/cc/rogue/pack.c

@@ -163,6 +163,11 @@ int32_t num_packitems(struct rogue_state *rs)
     int32_t type = 0,n = 0,total = 0;
     for (; list != NULL; list = next(list))
     {
+        if ( thing_find(list) < 0 )
+        {
+            fprintf(stderr,"num_packitems cant find %p\n",list);
+            return(-1);
+        }
         if ( list->o_packch != 0 )
         {
             n++;
@@ -219,29 +224,29 @@ THING *
 leave_pack(struct rogue_state *rs,THING *obj, bool newobj, bool all)
 {
     THING *nobj;
-
+    
     inpack--;
     nobj = obj;
     if (obj->o_count > 1 && !all)
     {
-	last_pick = obj;
-	obj->o_count--;
-	if (obj->o_group)
-	    inpack++;
-	if (newobj)
-	{
-	    nobj = new_item();
-	    *nobj = *obj;
-	    next(nobj) = NULL;
-	    prev(nobj) = NULL;
-	    nobj->o_count = 1;
-	}
+        last_pick = obj;
+        obj->o_count--;
+        if (obj->o_group)
+            inpack++;
+        if (newobj)
+        {
+            nobj = new_item();
+            *nobj = *obj;
+            next(nobj) = NULL;
+            prev(nobj) = NULL;
+            nobj->o_count = 1;
+        }
     }
     else
     {
-	last_pick = NULL;
-	pack_used[obj->o_packch - 'a'] = FALSE;
-	detach(pack, obj);
+        last_pick = NULL;
+        pack_used[obj->o_packch - 'a'] = FALSE;
+        detach(pack, obj);
     }
     return nobj;
 }
@@ -466,7 +471,9 @@ get_item(struct rogue_state *rs,char *purpose, int type)
                     return NULL;
                 }
                 else
+                {
                     return obj;
+                }
             }
         }
     return NULL;