DragonX/dragonx
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 2 Wiki Activity

Net: Fix resource leak in ReadBinaryFile(...)

Browse Source 
Introduced in 3290567bbd via PR #2177.
This commit is contained in:
practicalswift
2017-06-14 17:32:45 +02:00
committed by Jack Grigg
parent d52ac0d498
commit 1240717431
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/torcontrol.cpp
View File

@@ -376,8 +376,10 @@ static std::pair<bool,std::string> ReadBinaryFile(const std::string &filename, s
while ((n=fread(buffer, 1, sizeof(buffer), f)) > 0) { while ((n=fread(buffer, 1, sizeof(buffer), f)) > 0) {
// Check for reading errors so we don't return any data if we couldn't // Check for reading errors so we don't return any data if we couldn't
// read the entire file (or up to maxsize) // read the entire file (or up to maxsize)
if (ferror(f)) if (ferror(f)) {
fclose(f);
return std::make_pair(false,""); return std::make_pair(false,"");
}
retval.append(buffer, buffer+n); retval.append(buffer, buffer+n);
if (retval.size() > maxsize) if (retval.size() > maxsize)
break; break;