DragonX/dragonx
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 2 Wiki Activity

Avoid coredump if witness index does not exist

Browse Source
This commit is contained in:
Duke
2025-08-22 07:34:11 -04:00
parent fb7d669f14
commit 34829af017
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/wallet/asyncrpcoperation_sendmany.cpp
View File

@@ -428,16 +428,14 @@ bool AsyncRPCOperation_sendmany::main_impl() {
// Add Sapling spends // Add Sapling spends
for (size_t i = 0; i < saplingNoteInputs_.size(); i++) { for (size_t i = 0; i < saplingNoteInputs_.size(); i++) {
//LOCK2(cs_main, pwalletMain->cs_wallet); if (!witnesses.at(i)) {
//TODO: avoid coredump here if this index does not exist
if (!witnesses[i]) {
throw JSONRPCError(RPC_WALLET_ERROR, throw JSONRPCError(RPC_WALLET_ERROR,
strprintf( "Missing witness for Sapling note at outpoint %s", std::get<0>(saplingNoteInputs_[i]).ToString()) strprintf( "Missing witness for Sapling note at outpoint %s", std::get<0>(saplingNoteInputs_[i]).ToString())
); );
} }
if(fZdebug) if(fZdebug)
LogPrintf("%s: Adding Sapling spend\n", __func__); LogPrintf("%s: Adding Sapling spend\n", __func__);
assert(builder_.AddSaplingSpend(expsk, std::get<1>(saplingNoteInputs_[i]), anchor, witnesses[i].get())); assert(builder_.AddSaplingSpend(expsk, std::get<1>(saplingNoteInputs_[i]), anchor, witnesses[i].get()));
} }