DragonX/dragonx
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 2 Wiki Activity

Fixes #362

Browse Source 
Array index 2 does not exist, which caused the foundersrewardaddress
key of getblocktemplate to be incorrect. It would either show the next
address in the list or be empty if it caused a read past the end of the
2D DEVTAX_DATA array. This is what happens in gcc 9.4.0 but since this
is technically Undefined Behavior according to the C Standard it could
cause a crash or even make demons fly out of your nose.

See http://catb.org/jargon/html/N/nasal-demons.html for details.
This commit is contained in:
Duke
2023-11-27 18:45:49 -05:00
parent 4facbadc6a
commit 382861de2b
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/hush_globals.h
View File

@@ -332,7 +332,7 @@ std::string devtax_scriptpub_for_height(uint32_t nHeight) {
} }
// this is only used by getblocktemplate, so it cannot change consensus of // this is only used by getblocktemplate, so it cannot change consensus of
// blocks < DEVTAX_FORK_HEIGHT but it will affect consensus of later blocks // blocks < DEVTAX_FORK_HEIGHT but it could affect consensus of later blocks
std::string devtax_address_for_height(uint32_t nHeight) { std::string devtax_address_for_height(uint32_t nHeight) {
const std::string legacy_devtax_address = "RHushEyeDm7XwtaTWtyCbjGQumYyV8vMjn"; const std::string legacy_devtax_address = "RHushEyeDm7XwtaTWtyCbjGQumYyV8vMjn";
bool ishush3 = strncmp(SMART_CHAIN_SYMBOL, "HUSH3",5) == 0 ? true : false; bool ishush3 = strncmp(SMART_CHAIN_SYMBOL, "HUSH3",5) == 0 ? true : false;
@@ -346,7 +346,7 @@ std::string devtax_address_for_height(uint32_t nHeight) {
// Decentralized devtax is height-activated // Decentralized devtax is height-activated
if (nHeight >= DEVTAX_FORK_HEIGHT) { if (nHeight >= DEVTAX_FORK_HEIGHT) {
if (ishush3 || istush3) { if (ishush3 || istush3) {
return DEVTAX_DATA[ nHeight % DEVTAX_NUM ][2]; return DEVTAX_DATA[ nHeight % DEVTAX_NUM ][0];
} else { } else {
// if this is not HUSH3 or TUSH3, return legacy // if this is not HUSH3 or TUSH3, return legacy
return legacy_devtax_address; return legacy_devtax_address;