DragonX/dragonx
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 2 Wiki Activity

cryptoconditions: ugly workaround to fix memory access issues on aarch64

Browse Source
This commit is contained in:
miodragpop
2020-07-16 19:24:30 +02:00
parent c12ec78caf
commit 6017bdba79
1 changed files with 12 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/cryptoconditions/src/asn/OCTET_STRING.c
View File

@@ -1714,7 +1714,9 @@ OCTET_STRING_free(asn_TYPE_descriptor_t *td, void *sptr, int contents_only) {
OCTET_STRING_t *st = (OCTET_STRING_t *)sptr; OCTET_STRING_t *st = (OCTET_STRING_t *)sptr;
asn_OCTET_STRING_specifics_t *specs; asn_OCTET_STRING_specifics_t *specs;
asn_struct_ctx_t *ctx; asn_struct_ctx_t *ctx;
#if !defined(__aarch64__)
struct _stack *stck; struct _stack *stck;
#endif
if(!td || !st) if(!td || !st)
return; return;
@@ -1731,6 +1733,15 @@ OCTET_STRING_free(asn_TYPE_descriptor_t *td, void *sptr, int contents_only) {
st->buf = 0; st->buf = 0;
} }
/* Attention !!!
* this is quick & dirty workaround for memory corruption bug on aarch64-linux-gnu
* - downside: allows memory leakage
* - issue description: On Raspberry Pi 4 @ 64bit linux, daemon crashes with "free(): invalid pointer" error
* - probable cause: misaligned memory access to nested structs containing pointers
* - TODO: use the latest asn1c compiler on CryptoConditions.asn, maybe generate cpp instead of c code... investigation in progress
*/
#if !defined(__aarch64__)
/* /*
* Remove decode-time stack. * Remove decode-time stack.
*/ */
@@ -1747,6 +1758,7 @@ OCTET_STRING_free(asn_TYPE_descriptor_t *td, void *sptr, int contents_only) {
if(!contents_only) { if(!contents_only) {
FREEMEM(st); FREEMEM(st);
} }
#endif
} }
/* /*