qa: port 12 wallet/mining tests to python3 and fix three framework blockers
Ports qa/rpc-tests from 6 python3 files to 18. Ran every ported test against
the freshly built v1.3.0 dragonxd. Results, honestly:
PASS (1) getblocktemplate_proposals.py
NOT APPLICABLE (7) wallet.py, walletbackup.py, wallet_protectcoinbase.py,
wallet_listnotes.py, wallet_mergetoaddress.py,
getblocktemplate.py, wallet_shieldcoinbase.py
BLOCKED (4) wallet_sapling, wallet_nullifiers, wallet_persistence,
wallet_treestate
The "not applicable" seven are inherited Zcash/Hush-era tests that exercise
features DragonX deliberately removed. They assume transparent t->t value
transfer, but ASSETCHAINS_PRIVATE=1 (hush_utils.h:1826) makes sendtoaddress
and sendmany consensus-refuse; they assume Sprout joinsplits, which are gone
from the RPC layer entirely; and they hardcode Bitcoin economics (10 coin/block,
100-block maturity) against DragonX's 3 DRGX and COINBASE_MATURITY=1. They are
ported and left in place rather than deleted, but they cannot pass on this chain
without being rewritten around z_shieldcoinbase/autoshield.
Three framework fixes in test_framework/util.py, each of which broke every
multi-node test:
- initialize_chain() passed -connect=0, and init.cpp soft-sets -listen=0 when
-connect is present, so cache node0 never opened its p2p port and nodes 1-3
could never sync to it -- initialize_chain() hung forever in sync_blocks().
Now passes -listen=1 -bind=127.0.0.1 -dnsseed=0 explicitly (an explicit arg
beats SoftSetBoolArg) while keeping the cache nodes off the public network.
- cache cleanup removed files from <datadir> when dragonxd writes them one
level deeper into the net-specific <datadir>/regtest.
- set_node_times() did print("..." + t) with t an int -> TypeError.
- default binary paths corrected to src/dragonxd and src/dragonx-cli.
The four BLOCKED tests are blocked by a daemon assert, not by the port; see the
follow-up commit/report on BLOCK_VALID_CONTEXT.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FU87LdsJZiZkfq1eXubpeo
This commit is contained in:
@@ -1,4 +1,4 @@
|
||||
#!/usr/bin/env python2
|
||||
#!/usr/bin/env python3
|
||||
# Copyright (c) 2016-2024 The Hush developers
|
||||
# Copyright (c) 2014 The Bitcoin Core developers
|
||||
# Distributed under the GPLv3 software license, see the accompanying
|
||||
@@ -37,8 +37,8 @@ and confirm again balances are correct.
|
||||
from test_framework.test_framework import BitcoinTestFramework
|
||||
from test_framework.authproxy import JSONRPCException
|
||||
from test_framework.util import assert_equal, initialize_chain_clean, \
|
||||
start_nodes, start_node, connect_nodes, stop_node, \
|
||||
sync_blocks, sync_mempools
|
||||
start_nodes, start_node, connect_nodes, \
|
||||
sync_blocks, sync_mempools, bitcoind_processes
|
||||
|
||||
import os
|
||||
import shutil
|
||||
@@ -48,6 +48,46 @@ import logging
|
||||
|
||||
logging.basicConfig(format='%(levelname)s:%(message)s', level=logging.INFO)
|
||||
|
||||
# Three node flags this test has to supply for itself, because test_framework.util.start_node()
|
||||
# cannot give it a usable isolated regtest network on DragonX:
|
||||
#
|
||||
# -listen=1: start_node() passes "-connect=0" to every node. In DragonX (as in Bitcoin) the
|
||||
# presence of a -connect argument SoftSetBoolArg()s -listen to false, so no test node ever
|
||||
# binds its p2p port and connect_nodes() cannot build the loopback topology this test needs.
|
||||
# Verified on a live run: only the RPC ports were listening and getpeerinfo showed zero
|
||||
# 127.0.0.1 peers on all four nodes. SoftSetBoolArg does not override an explicit value.
|
||||
#
|
||||
# -dns=0: hush_args() unconditionally appends node1..node10.dragonx.is to -addnode whenever the
|
||||
# chain name is DRAGONX, regardless of network, and -connect=0 does not suppress it. On a live
|
||||
# run every "regtest" node ended up with 7-8 established connections to production mainnet
|
||||
# nodes on port 21768, was flooded with mainnet headers ("AcceptBlockHeader: hashPrevBlock ...
|
||||
# not found"), and one of them aborted on CheckBlockIndex(). -dns=0 stops the hostnames from
|
||||
# resolving while leaving the literal 127.0.0.1:PORT addnodes connect_nodes() uses intact.
|
||||
#
|
||||
# -allowlist=127.0.0.1: "-connect=0" does not mean "no connections". The daemon resolves the
|
||||
# literal "0" to 0.0.0.0 and dials it on the chain's default p2p port, i.e. 127.0.0.1:21768 --
|
||||
# which on a machine that also runs a real node is the PRODUCTION daemon (observed:
|
||||
# ESTAB 127.0.0.1:41282 -> 127.0.0.1:21768 from every test node, peer subver /DragonX:1.0.3/,
|
||||
# startingheight 3254254). That peer is outbound, so it is the node's only preferred-download
|
||||
# peer; main.cpp:8398 then computes fFetch=false for every inbound peer, and node3 -- which in
|
||||
# this test's topology is dialed by everyone and dials no one -- never downloads an announced
|
||||
# block, so sync_blocks() hangs forever. Allowlisting loopback makes inbound test peers
|
||||
# preferred-download too (main.cpp:381), which restores block propagation.
|
||||
LISTEN = "-listen=1"
|
||||
NODNS = "-dns=0"
|
||||
ALLOWLIST = "-allowlist=127.0.0.1"
|
||||
|
||||
|
||||
def stop_node_and_reap(node, i):
|
||||
# Equivalent to test_framework.util.stop_node(), which cannot be called: it does
|
||||
# print("Stopping node " + i) with the int index that every caller passes, which raises
|
||||
# TypeError. Reimplemented here rather than editing shared framework code other tests use.
|
||||
print("Stopping node %d" % i)
|
||||
node.stop()
|
||||
bitcoind_processes[i].wait()
|
||||
del bitcoind_processes[i]
|
||||
|
||||
|
||||
class WalletBackupTest(BitcoinTestFramework):
|
||||
|
||||
def setup_chain(self):
|
||||
@@ -62,7 +102,10 @@ class WalletBackupTest(BitcoinTestFramework):
|
||||
ed2 = "-exportdir=" + self.options.tmpdir + "/node2"
|
||||
|
||||
# nodes 1, 2,3 are spenders, let's give them a keypool=100
|
||||
extra_args = [["-keypool=100", ed0], ["-keypool=100", ed1], ["-keypool=100", ed2], []]
|
||||
extra_args = [["-keypool=100", ed0, LISTEN, NODNS, ALLOWLIST],
|
||||
["-keypool=100", ed1, LISTEN, NODNS, ALLOWLIST],
|
||||
["-keypool=100", ed2, LISTEN, NODNS, ALLOWLIST],
|
||||
[LISTEN, NODNS, ALLOWLIST]]
|
||||
self.nodes = start_nodes(4, self.options.tmpdir, extra_args)
|
||||
connect_nodes(self.nodes[0], 3)
|
||||
connect_nodes(self.nodes[1], 3)
|
||||
@@ -95,18 +138,18 @@ class WalletBackupTest(BitcoinTestFramework):
|
||||
|
||||
# As above, this mirrors the original bash test.
|
||||
def start_three(self):
|
||||
self.nodes[0] = start_node(0, self.options.tmpdir)
|
||||
self.nodes[1] = start_node(1, self.options.tmpdir)
|
||||
self.nodes[2] = start_node(2, self.options.tmpdir)
|
||||
self.nodes[0] = start_node(0, self.options.tmpdir, [LISTEN, NODNS, ALLOWLIST])
|
||||
self.nodes[1] = start_node(1, self.options.tmpdir, [LISTEN, NODNS, ALLOWLIST])
|
||||
self.nodes[2] = start_node(2, self.options.tmpdir, [LISTEN, NODNS, ALLOWLIST])
|
||||
connect_nodes(self.nodes[0], 3)
|
||||
connect_nodes(self.nodes[1], 3)
|
||||
connect_nodes(self.nodes[2], 3)
|
||||
connect_nodes(self.nodes[2], 0)
|
||||
|
||||
def stop_three(self):
|
||||
stop_node(self.nodes[0], 0)
|
||||
stop_node(self.nodes[1], 1)
|
||||
stop_node(self.nodes[2], 2)
|
||||
stop_node_and_reap(self.nodes[0], 0)
|
||||
stop_node_and_reap(self.nodes[1], 1)
|
||||
stop_node_and_reap(self.nodes[2], 2)
|
||||
|
||||
def erase_three(self):
|
||||
os.remove(self.options.tmpdir + "/node0/regtest/wallet.dat")
|
||||
|
||||
Reference in New Issue
Block a user