From fa92a21a40c5706b9f3b454b68050ce5f36b1bbc Mon Sep 17 00:00:00 2001 From: Jack Grigg Date: Tue, 21 Aug 2018 17:59:46 +0100 Subject: [PATCH] libsnark: Adjust SHA256 K value type to match the constant When used, it is cast to an integer_coeff_t, which is currently a long. On LP64 systems, this cast is lossless. Issues with LLP64 systems will be addressed later. --- .../gadgetlib1/gadgets/hashes/sha256/sha256_components.hpp | 4 ++-- .../gadgetlib1/gadgets/hashes/sha256/sha256_components.tcc | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/snark/libsnark/gadgetlib1/gadgets/hashes/sha256/sha256_components.hpp b/src/snark/libsnark/gadgetlib1/gadgets/hashes/sha256/sha256_components.hpp index c2f31e3af..2f7e71e35 100644 --- a/src/snark/libsnark/gadgetlib1/gadgets/hashes/sha256/sha256_components.hpp +++ b/src/snark/libsnark/gadgetlib1/gadgets/hashes/sha256/sha256_components.hpp @@ -78,7 +78,7 @@ public: pb_linear_combination_array g; pb_linear_combination_array h; pb_variable W; - long K; + uint32_t K; pb_linear_combination_array new_a; pb_linear_combination_array new_e; @@ -92,7 +92,7 @@ public: const pb_linear_combination_array &g, const pb_linear_combination_array &h, const pb_variable &W, - const long &K, + const uint32_t &K, const pb_linear_combination_array &new_a, const pb_linear_combination_array &new_e, const std::string &annotation_prefix); diff --git a/src/snark/libsnark/gadgetlib1/gadgets/hashes/sha256/sha256_components.tcc b/src/snark/libsnark/gadgetlib1/gadgets/hashes/sha256/sha256_components.tcc index ec02172de..41ad20883 100644 --- a/src/snark/libsnark/gadgetlib1/gadgets/hashes/sha256/sha256_components.tcc +++ b/src/snark/libsnark/gadgetlib1/gadgets/hashes/sha256/sha256_components.tcc @@ -149,7 +149,7 @@ sha256_round_function_gadget::sha256_round_function_gadget(protoboard &g, const pb_linear_combination_array &h, const pb_variable &W, - const long &K, + const uint32_t &K, const pb_linear_combination_array &new_a, const pb_linear_combination_array &new_e, const std::string &annotation_prefix) :