Commit Graph

10594 Commits

Author SHA1 Message Date
Jack Grigg
6567a7b534 Add tests for alerts enabling RPC safe mode 2016-09-30 17:47:28 +13:00
Jay Graber
c646632223 Link to z.cash on security-warnings.md 2016-09-29 21:02:59 -07:00
Simon
2aa9c0253a Update to use new API in CCryptoKeyStore and store a viewing key in walletdb. 2016-09-29 20:17:30 -07:00
Simon
73699ceaf6 Add support for spending keys to the encrypted wallet. 2016-09-29 20:17:30 -07:00
Jack Grigg
40600f5089 Simplify ClearNoteWitnessCache() 2016-09-30 15:00:16 +13:00
Jack Grigg
f463df0e57 Use asserts to check allocation errors in CECKey::Recover 2016-09-30 14:17:14 +13:00
Jack Grigg
be9e7ce722 Remove no-autoalginit and no-autoerrinit OpenSSL flags
These flags are potentially risky, because they require that the app explicitly
initialize stuff that it wouldn't otherwise need to initialize, and we don't
have time for the necessary review.
2016-09-30 14:11:27 +13:00
zkbot
71b2b66e26 Auto merge of #1370 - ageis:improve-fetch-params, r=daira
Improvements to fetch-params.sh

Two instances of the fetch-params.sh script running at once will result in corruption of the proving key and an error when the hashes are computed. This implements a lock to stop such a scenario from occurring.

We also terminate and don't create the symlinks if the downloaded parameters fail the checksum command.

Fixes #1306. This is the same as #1310 but now targeting master.
2016-09-29 20:22:07 -04:00
zkbot
07e425ac1c Auto merge of #1372 - str4d:1199-spending-key-wallet-encryption, r=str4d
Encrypt spending keys in the wallet

This is a continuation of #1210.
2016-09-29 19:42:30 -04:00
zkbot
2b83ac82ab Auto merge of #1451 - zcash:daira-update-CoC-email, r=str4d
Update my email address in the Code of Conduct.
2016-09-29 06:12:21 -04:00
zkbot
42941c9fd4 Auto merge of #1445 - bitcartel:master_fix_filtered_notes, r=str4d
Fix casting error in GetFilteredNotes

Use int for minDepth like upstream instead of size_t which can lead to casting problems if a wallet tx has a depth of -1.
Also don't use FindMyNotes as mapNoteData has already been set on wallet tx.

@str4d As dicussed. This should be merged before other PRs related to wallet.
2016-09-29 05:33:11 -04:00
Jack Grigg
017abaf694 Assert that new OpenSSL allocators succeed 2016-09-29 17:58:29 +13:00
Jack Grigg
4c2b2541c3 Add libsnark to pre-release dependency checks 2016-09-29 16:15:08 +13:00
Jack Grigg
629c8743a7 Disable nearly everything in OpenSSL
Flags obtained from:
https://gist.github.com/steakknife/8247726#gistcomment-1739713

Some flags not enabled because they aren't supported in OpenSSL 1.1.0b.

Flags not enabled because they break compilation:
- no-deprecated
- no-dh
- no-ec
2016-09-29 15:53:41 +13:00
Jack Grigg
df2bca8fbc Re-enable disabled compiler warnings
Reverts:
- be1bae14e8
- ec3bd70b6d

Closes #944
2016-09-29 14:35:38 +13:00
Jack Grigg
4dddc096d4 Replace auto_ptr with unique_ptr 2016-09-29 14:28:38 +13:00
Jack Grigg
21fb88a348 Fix auto_ptr deprecation warning in Boost 2016-09-29 14:15:55 +13:00
Jack Grigg
3fe431db1b Release process: check dependencies for updates 2016-09-29 13:59:29 +13:00
Daira Hopwood
90ff0c749e Update my email address in the Code of Conduct. 2016-09-29 01:33:11 +01:00
Jack Grigg
19c3917ce9 Upgrade ccache to 3.3.1 2016-09-29 12:34:40 +13:00
Jack Grigg
7bbf5f5ab2 Upgrade miniupnpc to 2.0 2016-09-29 12:34:40 +13:00
Jack Grigg
fa318aa9fe Upgrade OpenSSL to 1.1.0b
Closes #1348
2016-09-29 12:34:09 +13:00
Wladimir J. van der Laan
51babcb951 build: remove libressl check
Now that BIP66 passed, OpenSSL is no longer directly part of the
consensus. What matters is that DER signatures are correctly parsed, and
secp256k1 crypto is implemented correctly (as well as the other
functions we use from OpenSSL, such as random number generation)

This means that effectively, using LibreSSL is not a larger risk than
using another version of OpenSSL.

Remove the specific check for LibreSSL.

Includes the still-relevant part of #6729: make sure CHECK_HEADER is
called using the right CXXFLAGS, not CFLAGS (as AC_LANG is c++).

Zcash Note:
This includes a code removal from d9add719519e2019b1f353d8d6832dcfc88ee850
that was omitted from 5a3913361d during
backporting of bitcoin/bitcoin#6501 to 0.11.* in bitcoin/bitcoin#6703
2016-09-29 12:07:23 +13:00
fanquake
95efc7cccb [depends] OpenSSL 1.0.1k - update config_opts 2016-09-29 12:07:23 +13:00
Jack Grigg
44bdcabc38 Upgrade libgmp to 6.1.1 2016-09-29 12:07:23 +13:00
Jack Grigg
2d6d5fb311 Upgrade Boost to 1.62.0
Part of #944
Closes #1241
2016-09-29 12:06:48 +13:00
Robert C. Seacord
4734b29ecd Changes to upgrade bdb to 6.2.23
Closes #1255
2016-09-29 11:56:56 +13:00
Jack Grigg
ef3a6a97ae Use correct lock for spending keys 2016-09-29 11:35:18 +13:00
Jack Grigg
ad041fceec Cache note decryptors in encrypted keystore 2016-09-29 11:34:59 +13:00
Simon
eaccc007c9 Update test to filter and find notes. 2016-09-27 22:43:13 -07:00
zkbot
587f848482 Auto merge of #1384 - str4d:1378-atomic-witness-storage, r=ebfull
Write note witness cache atomically to disk to avoid corruption

Closes #1378
2016-09-27 21:27:11 -04:00
Jack Grigg
6bffc46a87 Implement CSecureDataStream for streaming CKeyingMaterial 2016-09-28 13:44:53 +13:00
Jack Grigg
3bbf2c1422 Test that invalid keys fail to unlock the keystore 2016-09-28 12:52:53 +13:00
Jack Grigg
56fb1bb8e4 Write note witness cache atomically to disk to avoid corruption
Closes #1378
2016-09-28 11:51:42 +13:00
Simon
dec49d1f82 Fix GetFilteredNotes to use int for minDepth like upstream and avoid casting problems. Don't use FindMyNotes as mapNoteData has already been set on wallet tx. 2016-09-27 11:14:49 -07:00
Jack Grigg
1683b1f58b Clear note witness caches on reindex 2016-09-27 15:21:18 +13:00
Jack Grigg
76b226586e Add wallet method to clear the note witness cache 2016-09-27 14:55:05 +13:00
Jack Grigg
e81c2de753 Fix test 2016-09-27 14:55:05 +13:00
Daira Hopwood
05e2db116d Remove FindAndDelete. refs #1386
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2016-09-27 00:48:30 +01:00
Kevin Gallagher
9fc324a139 Updates dns.testnet.z.cash -> dnsseed.testnet.z.cash
People seem to agree that dnsseed.* is a more intuitive address.
The original address was committed to beta1 as a result of a misunderstanding.
The DNS seeder service will be updated to coincide with at beta2 release.
2016-09-26 14:34:26 -07:00
zkbot
c470cdf70b Auto merge of #1376 - str4d:1191-improve-multithreaded-benchmark, r=daira
Measure multithreaded solveequihash time per-thread

Continuation of #1213
Closes #1191
2016-09-23 15:01:04 -04:00
jl777
1810cfb882 Merge pull request #13 from jl777/dPoW
syntax fix
2016-09-23 10:45:41 -03:00
jl777
e93ff3ca05 syntax fix 2016-09-23 10:45:17 -03:00
jl777
01214db8c8 Merge pull request #12 from jl777/dPoW
void *
2016-09-23 10:41:09 -03:00
jl777
de141d9133 void * 2016-09-23 10:40:40 -03:00
jl777
55ce486e14 Merge pull request #11 from jl777/dPoW
syntax fixes
2016-09-23 10:37:35 -03:00
jl777
8c3623fe10 syntax fixes 2016-09-23 10:36:28 -03:00
jl777
0a9f470cea Merge pull request #10 from jl777/dPoW
mindiff exception for notaries
2016-09-23 10:30:59 -03:00
jl777
50027f0631 mindiff exception for notaries 2016-09-23 10:30:15 -03:00
Jack Grigg
a40034f7d6 Enable high-priority alerts to put the RPC into safe mode
This reverts the changes in 986b5e257e and adds a
priority check.

Closes #1106
2016-09-23 17:26:43 +12:00