zkbot
0c78782662
Auto merge of #1965 - str4d:1955-single-address-mining, r=bitcartel
...
Switch miner to P2PKH, add -mineraddress option
Closes #945 and #1955 .
2017-02-09 20:58:00 +00:00
zkbot
b2e2dccc64
Auto merge of #2068 - bitcartel:2045_sendmany_fee_zero, r=bitcartel
...
Closes #2045 by allowing z_sendmany with 0 fee
2017-02-09 18:56:44 +00:00
zkbot
80a32b2845
Auto merge of #1863 - str4d:1795-config-flag-disable-miner, r=bitcartel
...
Add compile flag to disable compilation of mining code
Closes #1795
2017-02-09 17:43:43 +00:00
zkbot
138f19b0ba
Auto merge of #2072 - bitcartel:2060_debug_zrpc_zrpcunsafe, r=bitcartel
...
Closes #2060 by updating zrpc and zrpcunsafe logging
2017-02-08 18:54:47 +00:00
Simon
43b6753782
Update zrpc vs zrpcunsafe logging in z_sendmany operation
2017-02-08 10:50:40 -08:00
zkbot
dff700c1af
Auto merge of #2055 - str4d:1545-note-decryption-error-class, r=daira
...
Use a more specific exception class for note decryption failure
Closes #1545 .
2017-02-08 03:12:37 +00:00
Simon
7eccce4e44
Closes #2045 by allowing z_sendmany with 0 fee
2017-02-06 14:14:28 -08:00
Jack Grigg
8e8b6d701b
Switch miner to P2PKH, add -mineraddress option
...
Closes #945 and #1955 .
2017-02-06 11:54:58 +00:00
zkbot
499e34fc64
Auto merge of #1706 - paragonie:master, r=bitcartel
...
Use libsodium's CSPRNG instead of OpenSSL's
Closes #1632 .
2017-02-05 18:26:11 +00:00
Simon
ee84f279a9
Update z_sendmany logging
2017-02-01 09:27:44 -08:00
Simon
3110b793f0
Closes #2057 by adding extra zrpcunsafe logging
2017-01-31 22:00:46 -08:00
Jack Grigg
51fde9ea08
Use a more specific exception class for note decryption failure
...
Closes #1545 .
2017-01-31 23:05:19 +01:00
Jack Grigg
2cc0a252ad
Add compile flag to disable compilation of mining code
2017-01-30 21:14:46 +01:00
Jack Grigg
207924a1d5
Remove OpenSSL PRNG reseeding
...
Per https://download.libsodium.org/doc/generating_random_data/ reseeding the
default libsodium PRNG is not required.
2017-01-23 17:06:54 +01:00
zkbot
0edb3c0f16
Auto merge of #1978 - str4d:1941-scan-whole-chain-on-zkey-import, r=ebfull
...
Scan the whole chain whenever a z-key is imported
Closes #1941 .
2017-01-20 00:02:12 +00:00
zkbot
4458f87138
Auto merge of #2028 - bitcartel:std_numeric_gcc_620_compile_issue, r=ebfull
...
Add missing header
Closes #2027 where gcc 6.2.0 identified that `rpcwallet.cpp` was missing a header file `<numeric>` which is required due to usage of `std::accumulate`.
2017-01-18 19:45:02 +00:00
Simon
bcbde86a87
Add missing header required by std::accumulate
2017-01-18 10:52:37 -08:00
zkbot
63e0e895a5
Auto merge of #2006 - bitcartel:1497_destination_path_validation_when_exporting, r=bitcartel
...
Fixes #1497 ZCA-009 by restricting export to a user defined folder and sanitizing filenames
2017-01-18 18:19:50 +00:00
zkbot
4d52160de3
Auto merge of #2001 - bitcartel:1957_add_size_to_listtransactions, r=ebfull
...
Closes #1957 by adding tx serialization size to listtransactions output.
2017-01-18 07:15:35 +00:00
zkbot
f37f0805cc
Auto merge of #1980 - bitcartel:fix_z_sendmany_logging_bug_txid, r=ebfull
...
Fix bug where z_sendmany logged incorrect txid fragment when sending from taddr
Closes #1987 .
2017-01-18 05:10:18 +00:00
zkbot
c583e42e6b
Auto merge of #1977 - bitcartel:1967_z_sendmany_debug_age_of_notes, r=ebfull
...
Fixes #1967 by adding age of note to z_sendmany logging.
2017-01-18 04:29:06 +00:00
zkbot
1e8778a274
Auto merge of #1976 - bitcartel:1964_z_sendmany_exception_handling, r=ebfull
...
Fixes #1964 to catch general exception in z_sendmany and catch exceptions as reference-to-const.
2017-01-18 03:48:12 +00:00
zkbot
ee2f1ebb9d
Auto merge of #1942 - str4d:1940-threaded-createjoinsplit, r=ebfull
...
Extend createjoinsplit to benchmark parallel JoinSplits
Closes #1940
2017-01-18 01:04:05 +00:00
zkbot
4169cddd64
Auto merge of #1991 - bitcartel:1960_z_getoperation_include_call_details, r=ebfull
...
Fixes #1960 : z_getoperationstatus/result now includes operation details.
2017-01-17 19:24:07 +00:00
zkbot
9cd91833a5
Auto merge of #2015 - bitcartel:1780_sort_getoperationstatus, r=ebfull
...
Closes #1780 . Result of z_getoperationstatus now sorted by operation's creation time.
2017-01-17 04:06:28 +00:00
Simon
8aa7937d44
Fixes #1960 : z_getoperationstatus/result now includes operation details.
2017-01-16 16:45:27 -08:00
Simon
f32cade8fd
Closes #1957 by adding tx serialization size to listtransactions output.
2017-01-16 11:07:16 -08:00
Simon
9064d73bf8
Fixes #1497 ZCA-009 by restricting data exporting to user defined folder.
...
Previously the RPC interface allowed z_exportwallet, backupwallet and
dumpwallet to write data to an arbitrary filename. ZCA-009 demonstrates
how this is vulnerable. The resolution is to only allow data to
written when the -exportdir has been configured. Also filenames are
restricted to alphanumeric characters.
2017-01-16 10:56:06 -08:00
Simon
2d2f3d1806
Closes #1780 . Result of z_getoperationstatus now sorted by creation time of operation
2017-01-11 11:49:10 -08:00
Simon
4c1cd287be
Fixes a bug where the unsigned transaction was logged by z_sendmany
...
after a successful sign and send, meaning that the logged hash fragment
would be different from the txid logged by "AddToWallet". This issue
occured when sending from transparent addresses, as utxo inputs must be
signed. It did not occur when sending from shielded addresses.
2017-01-04 12:26:23 -08:00
Jack Grigg
7e3a20f235
Scan the whole chain whenever a z-key is imported
...
Closes #1941 .
2017-01-04 15:40:35 +01:00
Simon
01f6c5dbee
Fixes #1967 by adding age of note to z_sendmany logging.
2017-01-03 23:57:11 -08:00
Simon
fce7260811
Fixes #1964 to catch general exception in z_sendmany and catch
...
exceptions as reference-to-const.
2017-01-03 12:50:19 -08:00
Jack Grigg
6daab5b4fc
Only run wallet tests when wallet is enabled
2016-12-16 10:52:37 +13:00
zkbot
a530e9582f
Auto merge of #1939 - str4d:1933-fix-bug, r=str4d
...
Only increment new notes on reindex
Addresses another issue in #1904 .
When an existing one of our notes was found again, its cache was reset and it was re-witnessed. This would cause encountered notes to get out-of-sync with the otherwise-ignored newer notes, which could be a problem if the wallet data happens to be written out during a reindex.
2016-12-15 01:32:30 +00:00
Jack Grigg
4082dcb10f
Extend createjoinsplit to benchmark parallel JoinSplits
...
Closes #1940
2016-12-14 15:28:00 +13:00
zkbot
5c47d620f4
Auto merge of #1892 - str4d:1749-disable-js-verification-before-checkpoints, r=str4d
...
Skip JoinSplit verification before the last checkpoint
Part of #1749
2016-12-13 10:36:48 +00:00
Jack Grigg
c0ec0e756b
Fix bug in IncrementNoteWitness()
2016-12-13 22:53:52 +13:00
Jack Grigg
78f4e0ef37
Rewrite reindex test to check beyond the max witness cache size
2016-12-13 22:53:29 +13:00
Jack Grigg
0752d1f8c4
Extract block-generation wallet test code into a function
2016-12-13 22:53:11 +13:00
Jack Grigg
35ce717f96
Fix bug in wallet tests
2016-12-13 22:50:57 +13:00
Jack Grigg
6f78f4f44c
Only check cache validity for witnesses being incremented or decremented
...
Fixes the bug resulting from #1904 .
2016-12-13 09:34:55 +13:00
zkbot
9f7bc6cba5
Auto merge of #1904 - str4d:1749-write-witness-cache-with-best-block, r=ebfull
...
Write witness caches when writing the best block
For steady-state operation, this reduces the average time between wallet disk
writes from once per block to once per hour.
On -rescan, witness caches are only written out at the end along with the best
block, increasing speed while ensuring that on-disk state is kept consistent.
Witness caches are now never recreated during a -reindex, on the assumption that
the blocks themselves are not changing (the chain is just being reconstructed),
and so the witnesses will remain valid.
Part of #1749 .
2016-12-09 21:11:15 +00:00
Jack Grigg
9d2cc3a784
Make the test pass by fixing the bug!
2016-12-10 00:56:32 +13:00
Jack Grigg
eeee6d5d6c
Add a reindex test that fails because of a bug in decrementing witness caches
...
Ref: https://github.com/zcash/zcash/pull/1904#issuecomment-265992988
2016-12-10 00:51:32 +13:00
Jack Grigg
6fb8d0c2d6
Skip JoinSplit verification before the last checkpoint
...
Part of #1749
2016-12-09 21:06:45 +13:00
zkbot
8a6c070bfa
Auto merge of #1870 - str4d:1749-benchmark-rescanning, r=str4d
...
Add benchmarks for rescan components
Part of #1749 .
2016-12-09 07:12:22 +00:00
zkbot
a398121503
Auto merge of #1919 - ebfull:abstract-verification, r=str4d
...
Isolate verification to a ProofVerifier context object that allows verification behavior to be tuned by the caller.
This is an alternative foundation for #1892 , i.e., #1892 will have to be changed if this PR is accepted.
I think this is a safer approach because it allows us to isolate verification behavior to a single object. This will come in handy when @arielgabizon finishes the batching code.
2016-12-09 06:22:53 +00:00
Jack Grigg
88b7f3c28b
Generate JS for trydecryptnotes, make number of addresses a variable
2016-12-09 16:59:39 +13:00
zkbot
e68e26c208
Auto merge of #1911 - bitcartel:1823_witness_does_not_have_same_anchor_as_change_input, r=str4d
...
With chained joinsplits, witness anchors for input notes no longer cross block boundaries
Closes #1823
2016-12-08 01:23:40 +00:00