Homu
4fc1066b6f
Auto merge of #3516 - str4d:3506-sendmany-sapling-t-ovk, r=ebfull
...
Generate an ovk to encrypt outCiphertext for t-addr senders
Closes #3506 .
2018-09-18 18:10:52 -07:00
Jack Grigg
bb4b6982e3
Generate an ovk to encrypt outCiphertext for t-addr senders
...
Closes #3506 .
2018-09-19 00:51:30 +01:00
Jack Grigg
bd3c860cb4
Use ovk directly in the TransactionBuilder API instead of fvk
2018-09-18 23:26:31 +01:00
Homu
e95bdeabbf
Auto merge of #3521 - bitcartel:sapling_json_data, r=str4d
...
Add Sapling fields to JSON RPC output using TxToJSON.
Related to #3063 to add Sapling support to wallet RPCs.
2018-09-18 12:13:14 -07:00
Homu
49356ed798
Auto merge of #3512 - str4d:3487-nu-peer-management, r=ebfull
...
Make NU peer management logic upgrade-agnostic
Closes #3487 .
2018-09-18 04:25:54 -07:00
Simon
9ba7479de1
Add Sapling fields to JSON RPC output using TxToJSON.
2018-09-17 09:44:43 -07:00
Homu
0e0f5e4ea7
Auto merge of #3496 - bitcartel:3442_sapling_note_locking, r=str4d
...
Add Sapling note locking to the CWallet class
Closes #3442 .
2018-09-12 09:07:14 -07:00
Jack Grigg
c861137624
net: Check against the current epoch's version when disconnecting peers
2018-09-12 10:17:33 +01:00
Jack Grigg
feee210af6
net: Check against the next epoch's version when evicting peers
2018-09-12 10:10:22 +01:00
Jack Grigg
07d3f947ec
Extract a helper method for finding the next epoch
2018-09-12 10:07:44 +01:00
Jack Grigg
ebf4c0671e
net: Check against the current epoch's version when rejecting nodes
2018-09-12 09:27:28 +01:00
Homu
d2b5a2daeb
Auto merge of #3502 - wo01:fix-num_bits, r=bitcartel
...
Fix assertion failure in circuit.merkle_tree_gadget_weirdness test on Windows
zcash-gtest.exe fails
```
[ RUN ] circuit.merkle_tree_gadget_weirdness
Assertion failed!
Program: C:\zcash-gtest.exe
File: ./snark/libsnark/gadgetlib1/gadgets/basic_gadgets.tcc, Line 50
Expression: this->pb.lc_val(packed).as_bigint().num_bits() <= bits.size()
```
The argument type of `__builtin_clzl()` function is unsigned long.
So, we need to replace `__builtin_clzl` with `__builtin_clzll`. (The argument type of `__builtin_clzll()` is unsigned long long (64bit)).
2018-09-11 17:02:09 -07:00
Homu
396bdaf00f
Auto merge of #3307 - gtank:3187-refactor-checkblock, r=bitcartel
...
Refactor ContextualCheckBlock tests
This cleans up and condenses our quadratically-scaling transaction format / consensus rule tests. They still technically scale quadratically, but should be much more readable and manageable now - all that remains in the individual test cases is the specific version flag tweaking we're trying to test.
Closes #3187 .
2018-09-11 14:53:59 -07:00
Simon
17b6a9d376
Update comment for test ContextualCheckBlockTest.BlockSproutRulesRejectOtherTx
2018-09-11 14:49:47 -07:00
Jack Grigg
94549326c9
Bugfix: Use time instead of block height for Sapling key metadata
2018-09-11 12:45:25 +01:00
Simon
761f8c8bb8
Add unit test SaplingNoteLocking
2018-09-04 14:56:08 -07:00
Simon
b1c693e532
Add methods to store SaplingOutPoint in setLockedSaplingNotes
2018-09-04 14:56:08 -07:00
Simon
0f62cacf0c
Refactor: rename ListLockedNotes -> ListLockedSproutNotes
2018-09-04 14:56:08 -07:00
Simon
9ae73247e2
Refactor: rename UnlockAllNotes -> UnlockAllSproutNotes
2018-09-04 14:56:08 -07:00
Simon
d358d145ca
Refactor: rename setLockedNotes -> setLockedSproutNotes
2018-09-04 14:55:58 -07:00
Jack Grigg
b33a7ec46e
wallet: Don't allow an HDSeed to be overwritten
...
We can maybe relax this restriction later once we have worked out the UX
implications.
2018-09-03 10:45:37 +01:00
Jack Grigg
b7f9a7ae02
wallet: Comment out HDSeed and CHDChain persistence to disk
...
Sapling keys generated from the seed are not yet persisted, so we don't
want to persist the seed or chain state either, otherwise the wallet
could end up in an inconsistent state.
Some tests are temporarily disabled because commenting out HDSeed
persistence breaks invariants inside CCryptoKeyStore.
Revert this commit during the PR for #3388 .
2018-09-03 10:45:37 +01:00
Jack Grigg
c58dae6cda
init: Generate a new HD seed on startup
2018-09-03 10:45:37 +01:00
Jack Grigg
70b4ad2dcd
wallet: Switch from SaplingSpendingKey to SaplingExtendedSpendingKey
...
The wallet now only stores Sapling extended spending keys, and thus can
only be used with keys generated from an HDSeed via ZIP 32.
Note that not all Sapling keys in the wallet will correspond to the
wallet's HDSeed, as a standalone Sapling xsk can be imported via
z_importkey. However, it must have been generated from a seed itself,
and thus is more likely to be backed up elsewhere.
2018-09-03 10:45:37 +01:00
Jack Grigg
a4ac4fc3f4
wallet: Store Sapling key metadata indexed by ivk
...
Closes #3426 .
2018-09-03 10:45:37 +01:00
Jack Grigg
e2416930ea
wallet: Store HDSeed and chain data
2018-09-03 10:45:37 +01:00
Jack Grigg
ec653523ad
Store HDSeed in CCryptoKeyStore
2018-09-03 10:45:33 +01:00
Jack Grigg
70c8c25e4b
Store HDSeed in CBasicKeyStore
2018-09-03 10:27:52 +01:00
Jack Grigg
7614198f9d
ZIP 32 Sapling structs
2018-09-03 10:27:52 +01:00
Homu
edd321609c
Auto merge of #3489 - str4d:3215-z_sendmany, r=str4d
...
Add Sapling support to z_sendmany
Closes #3215 .
2018-09-03 00:29:56 -07:00
Jack Grigg
7c02acc5b6
Minor cleanups
2018-09-03 01:28:31 +01:00
Jack Grigg
1ec06e93b1
Rename z_inputs_ to z_sprout_inputs_
2018-09-03 01:13:18 +01:00
WO
3786db4fb9
The long data type is replaced with int64_t
2018-09-01 00:57:11 +09:00
WO
c1992b5834
long -> int64_t
2018-09-01 00:37:57 +09:00
WO
a7102acb7e
Add an assert for num_bits function
2018-08-31 19:56:20 +09:00
WO
ccb58e2cab
Fix a bug of Windows binary
2018-08-31 12:36:36 +09:00
Homu
12c1156f31
Auto merge of #3172 - str4d:mingw32, r=str4d
...
Windows cross-compile support
Usage on Debian / Ubuntu:
> $ sudo apt install mingw-w64
> $ sudo update-alternatives --config x86_64-w64-mingw32-gcc
> (configure to use POSIX variant)
> $ sudo update-alternatives --config x86_64-w64-mingw32-g++
> (configure to use POSIX variant)
> $ HOST=x86_64-w64-mingw32 ./zcutil/build.sh
Closes #489 .
2018-08-30 14:51:24 -07:00
Jack Grigg
e47ccf2a00
libsnark: Use format macro constants for printing fixed-width values
2018-08-30 22:21:25 +01:00
Jack Grigg
c53defda9d
libsnark: Force constants used in test comparisons to be unsigned
2018-08-30 21:37:10 +01:00
Jack Grigg
2962a72e35
Rename GetFirstBlockTransaction() to GetFirstBlockCoinbaseTx()
2018-08-30 14:58:19 +01:00
Jack Grigg
d7bcbfaee4
Fix test after refactor to check bacd-cb-height rule on a genesis block
2018-08-30 14:50:57 +01:00
Jack Grigg
fb22b3bbd8
Revert NU activation heights in reverse order
...
Ensures that global state remains consistent.
2018-08-30 14:44:50 +01:00
Jack Grigg
d70d103ee0
Ensure SCOPED_TRACE falls out of scope when necessary
2018-08-30 14:41:56 +01:00
George Tankersley
e601446adc
Refactor ContextualCheckBlock tests
...
Combines some of the needlessly separate tests. Each formerly separate
test is tagged with a SCOPED_TRACE to make sure logs are still useful.
2018-08-30 14:39:07 +01:00
George Tankersley
ec7466b62f
Refactor ContextualCheckBlock tests ( #3187 )
...
Initial cleanup. Reduces duplication of code, especially around
constructing transactions, resetting the activation heights, and setting
up the EXPECT calls for accepting and rejecting tests.
Also adds a bunch of comments explaining the test plan and what
particular parts of the test are doing.
2018-08-30 14:37:19 +01:00
Jack Grigg
07d85a6455
Define additional booleans for readability
2018-08-30 09:42:21 +01:00
Jack Grigg
e54c4d2ca1
rpcwallet: Add Sapling support to z_sendmany
2018-08-27 11:36:14 +01:00
Jack Grigg
af4057b904
rpcwallet: Prevent use of both Sprout and Sapling addresses in z_sendmany
2018-08-27 11:13:49 +01:00
Jack Grigg
36e2141d92
rpcwallet: Add TransactionBuilder argument to AsyncRPCOperation_sendmany
2018-08-27 11:13:49 +01:00
Jack Grigg
81e0fd2eb9
wallet: Add HaveSpendingKeyForPaymentAddress visitor
2018-08-27 11:13:49 +01:00