miketout
bb3d3ab770
Keep cheatcatcher's lists in sync
2018-10-12 15:43:15 -07:00
Homu
527b7feef5
Auto merge of #3592 - Eirik0:z-sendmany-better-error, r=bitcartel
...
Better error message when sending to both sprout and sapling
When trying to send to both Sprout and Sapling (not currently supported with z_sendmany) we were getting the following error in our operation result: `general exception: boost::bad_get: failed value get using boost::get`.
This PR changes this to fail with a better error message before the async operation begins:
```
error code: -8
error message:
Cannot send to both Sprout and Sapling addresses using z_sendmany
```
2018-10-12 15:30:34 -07:00
miketout
79b0432dc1
Fix false positive error
2018-10-12 14:56:01 -07:00
miketout
085c3640bb
Improve error reporting and wallet cleanup
2018-10-12 13:54:31 -07:00
Eirik Ogilvie-Wigley
0917c84d9a
Better error message when sending to both sprout and sapling
...
Co-authored-by mdr0id <marshall@z.cash >
2018-10-12 14:12:21 -06:00
miketout
8c3a9bc7ae
Clean up POS checks
2018-10-12 01:12:08 -07:00
miketout
a8d2188651
Timeout adjustment
2018-10-11 22:47:07 -07:00
miketout
69fa3d0e00
Reduce lag timeouts
2018-10-11 22:28:37 -07:00
miketout
af2e212d7a
Remove spurios opret in tx builder, don't wait forever for blocks before mining, add delay to getblocktemplate
2018-10-11 21:35:09 -07:00
Simon
cd10562c73
Resolves Sapling nullifier persistence issue when importing a key.
...
During a rescan, a CWalletTx was persisted to disk before it had its
note data set. This meant that upon restart, the CWalletTx would
potentially be missing its nullifiers causing the wallet's balance
to include notes which had already been spent.
The resolution is to ensure that after a rescan, a CWalletTx is
persisted after it has had its nullifiers set correctly.
Co-authored-by: Eirik Ogilvie-Wigley <eirik@z.cash >
2018-10-11 21:25:53 -07:00
miketout
271326fafd
Clean up stake rebroadcasting and mempool checking
2018-10-11 19:52:32 -07:00
miketout
ae773246f8
Error message only when cheatstaker parameter is invalid, not missing
2018-10-11 14:52:05 -07:00
miketout
8b57c15f6a
Zcash latest changes
2018-10-11 14:30:42 -07:00
miketout
1021455845
Fix negative height issues for pruning cheat lists
2018-10-11 14:23:14 -07:00
miketout
16ef4f1e3d
update comments
2018-10-10 22:14:05 -07:00
Michael Toutonghi
8fc4030c10
Reorganized cheatcatcher for build issues
2018-10-10 21:46:40 -07:00
Michael Toutonghi
99dbf2c2ed
Build
2018-10-10 19:20:01 -07:00
Michael Toutonghi
2d02c19ee7
Build
2018-10-10 19:15:41 -07:00
Michael Toutonghi
df756d24ba
Cheatcatcher
2018-10-10 19:02:09 -07:00
Eirik Ogilvie-Wigley
3f824a908b
Fix HDSeed comment
2018-10-10 16:00:59 -06:00
miketout
477fd227ee
Simpler internal check
2018-10-09 14:35:46 -07:00
miketout
85ca7bb9cb
Debug comment cleanup
2018-10-09 00:04:45 -07:00
miketout
c754dbcfa6
Update to Zcash rc1
2018-10-08 23:47:20 -07:00
miketout
58fbbfc32f
Add staking control and reporting to getgenerate and setgenerate
2018-10-08 22:06:20 -07:00
miketout
5f63373eb9
Selectively reject Sapling transactions while synced below activation height. Add separate control of staking.
2018-10-08 21:15:21 -07:00
miketout
051af72cbd
Cap the random additional stake of a block to 1/2 the current stake difficulty
2018-10-08 17:20:31 -07:00
miketout
c2dc091e40
Merge branch 'master' of https://github.com/zcash/zcash into dev
2018-10-08 17:19:15 -07:00
miketout
8682e17a7d
Sapling support for z_shieldcoinbase and more
2018-10-08 16:17:24 -07:00
mdr0id
94360cd098
make-release.py: Versioning changes for 2.0.1-rc1.
2018-10-08 12:23:18 -07:00
Homu
c2bb0ec67f
Auto merge of #3517 - mdr0id:3388_persist_wallet, r=str4d
...
Sapling support for persisting wallet to disk
Closes #3388 . Closes #3061 .
2018-10-08 09:53:34 -07:00
miketout
ca4a5f2692
Change name to Stake Guard
2018-10-07 19:56:02 -07:00
miketout
d0cd50740c
Fix error in display-only of winning stake POS hash when output prevout.n was not 0
2018-10-07 14:54:07 -07:00
miketout
f2450b36f5
Remove debugging output
2018-10-07 14:32:45 -07:00
miketout
281a5e2eec
Confirm positive and negative spends with and without priv keys
2018-10-07 14:21:43 -07:00
Michael Toutonghi
ccc47c554c
Add cc include dirs to make file
2018-10-06 23:44:26 -07:00
miketout
191f3bbddd
Complete nothing at stake solution, waiting for confirm of masks
2018-10-06 21:28:51 -07:00
miketout
a1fd99cf34
data parsing issues
2018-10-06 10:05:48 -07:00
Jack Grigg
5513faccf6
Ignore decoding errors during -zapwallettxes
...
The undecoded wallet transaction is logged before proceeding, so later
recovery of metadata might be possible. But the fact that the user is
using -zapwallettxes is a clear indicator that they want
transactions removed from their wallet, so this is the priority.
2018-10-06 12:18:56 +01:00
miketout
68b9a352da
Change behavior of ExtractDestination, Solver, and GetscriptAddress for crypto conditions
2018-10-06 00:36:21 -07:00
miketout
ef9a13b557
Additional null check
2018-10-05 21:44:24 -07:00
miketout
a6ac51616c
Add null check to deref
2018-10-05 21:37:49 -07:00
Simon
cb9cff5fdc
Fix deadlock from calling CWallet::AddSaplingIncomingViewingKey instead of CBasicKeyStore::AddSaplingIncomingViewingKey
2018-10-05 21:15:08 -07:00
miketout
95c5c69bab
Successful staking on Sapling wit Crypto Conditions
2018-10-05 21:09:09 -07:00
Homu
72f6925de1
Auto merge of #3567 - bitcartel:3546_estimate_tx_size, r=bitcartel
...
For #3546 . Improve estimated tx size for Sapling outputs.
2018-10-05 20:33:38 -07:00
miketout
185b2d4f2f
move things around and some debugging code for odd issues
2018-10-05 17:20:23 -07:00
Homu
a513798710
Auto merge of #3566 - bitcartel:3546_prohibit_sapling_map_orphans, r=bitcartel
...
For #3546 . Shielded tx with missing inputs are not treated as orphans.
2018-10-05 17:09:29 -07:00
Jack Grigg
3e471410f1
Persist Sapling payment address to IVK map
...
This ensures we remember any diversified addresses manually generated
outside the wallet.
2018-10-06 00:45:39 +01:00
mdr0id
9ce6f8425b
Add gtest coverage of Sapling wallet persistence
2018-10-06 00:01:22 +01:00
mdr0id
fe92bc700a
Adding in rpc wallet sap for test_bitcoin
2018-10-06 00:01:21 +01:00
mdr0id
48a93fd2e0
Serialize Sapling data in CWalletTx
...
If 2.0.0 nodes upgrade to 2.0.1 after Sapling has activated, the v4 Sapling
transactions in their wallet will be treated as corrupt, and a rescan will be
triggered which will overwrite the old-format transactions with the new
Sapling-aware format.
2018-10-06 00:01:20 +01:00