Commit Graph

2156 Commits

Author SHA1 Message Date
DenioD
b3c7e048ab add z_getnotescount as rpc call ported for Hush from https://github.com/zcash/zcash/pull/4465 2020-04-25 00:30:06 +02:00
Duke Leto
a0e36da33c Spelling 2020-04-07 22:17:43 -04:00
Duke Leto
be4812bd29 Use fee=0 if we do not have enough funds in this zaddr to pay a fee; track number of txs created 2020-04-07 21:17:58 -04:00
Duke Leto
941f983a9f speling iz hard 2020-04-07 21:16:04 -04:00
Duke Leto
a96a1ebce5 Use fee=0 if we have less than a fee worth of funds to consolidate 2020-04-07 18:19:48 -04:00
Duke Leto
cf4514deef Log more details during sapling consolidation 2020-04-07 13:36:46 -04:00
Duke Leto
3175039f62 Log consolidation output amounts 2020-04-07 09:36:05 -04:00
Duke Leto
6cdf4dd765 Fix zrpcunsafe logging and log valueBalance when final_check fails 2020-04-07 00:11:53 -04:00
Duke Leto
4d56e542a8 Do not look for sprout notes 2020-04-06 23:07:11 -04:00
Duke Leto
e03ef7f108 Avoid notes with height=0 2020-04-06 23:05:20 -04:00
Duke Leto
a7dd309ad0 Add copyright 2020-04-06 18:37:02 -04:00
Duke Leto
f5444b1679 LogPrintf does not take a category argument, only LogPrint 2020-03-26 09:18:52 -04:00
Duke Leto
9f0197bba3 Improved error handling and logging for sapling consolidation 2020-03-20 11:31:58 -04:00
Duke Leto
2e51538df8 Add some debug 2020-03-16 07:58:12 -04:00
Duke Leto
707d50e894 Only malloc_trim on unix+windows 2020-03-15 15:18:00 -04:00
Duke Leto
c0c7d497d0 Fix compile issues and hopefully better logging of consolidation 2020-03-14 15:03:23 -04:00
Duke Leto
d81ab5c9c7 I think this should fix some compile issues 2020-03-14 10:45:04 -04:00
Duke Leto
c271fb8cbd Locks and docs 2020-03-10 09:10:12 -04:00
Duke Leto
968890c591 More error checking and use a CAmount instead of int, which hopefully fixes CommitTransaction() bug 2020-03-10 09:10:05 -04:00
Duke Leto
1beb2b1fa8 Remove more sprouty code 2020-03-10 07:22:23 -04:00
Duke Leto
41662dc370 Remove sprout-related RPC docs 2020-03-10 07:22:14 -04:00
Duke Leto
d8477c4d7b Remove some more sprout code, yay 2020-03-09 21:28:09 -04:00
Duke Leto
736aa8cfaf Add more data to failed consolidation ops 2020-03-09 21:27:49 -04:00
Duke Leto
744ef34438 Add zindex to z_getinfo 2020-03-09 21:04:53 -04:00
Duke Leto
e4bfafc76c Better error checking in consolidation for when CommitTransaction() fails 2020-03-09 21:02:52 -04:00
Duke Leto
67f666d5ff Tweak z_getinfo data slightly 2020-03-09 18:42:13 -04:00
Duke Leto
2aa376d286 Add z_getinfo, a place for various shielded details that do not fit other places 2020-03-09 16:31:54 -04:00
Duke Leto
4f06ce726b Merge pull request #95 from MyHush/thread_notify
Thread notify upstream fixes
2020-03-08 05:14:40 -07:00
Duke Leto
3d7bed74c1 Port more required code 2020-03-07 17:22:41 -05:00
Duke Leto
a2b3316664 Port PR93 from @denioD 2020-03-07 13:55:12 -05:00
Duke Leto
fad66953fb Cleanup 2020-03-06 15:22:50 -05:00
Duke Leto
9c72f4c2f5 Change consolidation fee to be the default instead of zero and require zinput arity to be inside [3,8] 2020-03-06 14:40:24 -05:00
Duke Leto
dc7525f12e Untested sapling consolidation plus sietch outputs to reduce metadata leakage 2020-03-04 09:17:05 -05:00
Duke Leto
9b0d986528 Document default of -consolidation and add comment about number of zouts 2020-02-27 18:20:14 -05:00
Duke Leto
cb004f5d57 Remove sprout code from z_exportwallet 2020-02-27 11:11:59 -05:00
Duke Leto
a7250280d0 Remove deprecated Sprout benchmarking RPCs 2020-02-27 11:06:58 -05:00
Duke Leto
2152f4df6d Port getalldata from ZER sans sproutness 2020-02-26 09:51:09 -05:00
Duke Leto
b06bd5720a Add z_listreceivedbyaddress from ZER and refactor some stuff 2020-02-26 00:20:02 -05:00
Duke Leto
a338a974c7 Add z_listreceivedbyaddress from ZER 2020-02-25 23:49:49 -05:00
Duke Leto
3b4e5d727c Revert "cleanup unnecessary lines"
This reverts commit 49872e5fd7.
2020-02-25 23:49:16 -05:00
DenioD
49872e5fd7 cleanup unnecessary lines 2020-02-25 15:47:18 +01:00
DenioD
c984c2e8d5 port z_listsentbyaddress and add memo field from c00e30b210 2020-02-25 11:54:23 +01:00
DenioD
8556f00d37 resource friendly tx reorder port from 58b05de90d 2020-02-17 21:36:17 +01:00
Duke Leto
ddbf53524e Merge pull request #80 from DenioD/dev
Hush witness rework, many thanks to @CryptoForge for this awesome cod…
2020-02-15 05:43:11 -08:00
DenioD
6c48397cf3 Hush witness rework, many thanks to @CryptoForge for this awesome code https://github.com/Cryptoforge-alt/pirate/tree/pirate_witness_rework 2020-02-15 14:14:39 +01:00
Duke Leto
89bbd48eae More libsnark removal changes to various internals 2020-01-24 12:30:58 -05:00
Duke Leto
8eef38f94c Fix broken sendmany RPC
The sendmany RPC was broken in the 3.3.0 release due to a bad merge of upstream KMD code,
resulting in this kind of error:

./src/hush-cli sendmany "" "{\"$TADDR1\": 0.0001, \"$TADDR2\": 0.0002, \"$TADDR3\": 0.0004}"
error code: -3
error message:
Amount is not a number or string

No matter how many recipients you give, it will always "fall off the end" of the array, because it increments i twice per loop.
That means AmountFromValue(sendTo[i]) is given an invalid amount and the RPC errors out, with no loss of funds.

This is not a consensus bug and only nodes who want to use the sendmany RPC need to upgrade.
Since GUI wallets do not use this RPC, it's most likely pools and exchanges that would want this.
2020-01-18 08:42:12 -05:00
Duke Leto
8da7b2f9d5 Use global nullifier list in z_listnullifiers 2020-01-02 13:55:22 -05:00
Duke Leto
1ddae646bf Return global nullifier count for zindex stats 2020-01-02 13:21:50 -05:00
Duke Leto
c0ca9ee8fe Log the sizes of various datastructures about nullifiers when NullifierCount() is called, if -zdebug 2020-01-02 12:46:35 -05:00