Commit Graph
23405 Commits
Author SHA1 Message Date
Duke Leto eec2dd51fb wallet desprout 2020-05-30 00:44:20 -04:00
Duke Leto ab0576a72e desprout 2020-05-29 23:47:28 -04:00
Duke Leto d265f782e7 desprout 2020-05-29 23:35:11 -04:00
Duke Leto 1010c7e8e4 Throw a logic error instead of asserting when we see weird witness shenanigans 2020-05-29 23:32:41 -04:00
Duke Leto 9c5a4e682e desprout 2020-05-29 23:10:05 -04:00
Duke Leto ff0ce2b69a Fix warning 2020-05-29 02:08:21 -04:00
Duke Leto c0834c3cb7 S4 dpow notaries 2020-05-29 01:55:00 -04:00
DeckerSU 2c60f2ffae disable assertion when -debug arg is passed 2020-05-21 21:55:16 -04:00
DeckerSU c7d96194d6 [test] proper removing of txes that violates interest validation from mempool
In CreateNewBlock of miner https://github.com/KomodoPlatform/komodo/blob/master/src/miner.cpp#L331
we have a condition that prevents miners to include certain txes in
block if tx violates komodo_validate_interest check. so, if such txes
will exist in mempool and in some reason they was not miner earlier, if
they have nExpiryHeight = 0 - they NEVER will be included in block by miners.

Also, code in CTxMemPool::removeExpired that should remove such txes
from mempool didn't do it due to mistake. As a result these txes
stucks in mempool. No one can mine it, bcz no one can include it in block,
and no one get success to remove it from mempool.

Look on old code:

```
(ASSETCHAINS_SYMBOL[0] == 0
  && tipindex != 0 && komodo_validate_interest(...) ) < 0

```
But should be:

```
(ASSETCHAINS_SYMBOL[0] == 0
  && tipindex != 0 && komodo_validate_interest(...) < 0 )
```

Bcz we should compare with 0 result of komodo_validate_interest, but we
had different behaviour, due to typo.
2020-05-21 21:54:28 -04:00
DeckerSU bde1f3c632 limit blockchain progress to a max of 1.000000
Issue: https://github.com/zcash/zcash/issues/3161
Fix commit: https://github.com/zcash/zcash/pull/4176/commits/b3594b52739c96105a3f6976924a9075b1c5bbe2
2020-05-21 21:53:51 -04:00
DeckerSU 3199c01328 CVE-2018–20586 fix
- https://medium.com/@lukedashjr/cve-2018-20586-disclosure-ff3e1ab9a21f
- https://github.com/bitcoin/bitcoin/pull/14618/files
2020-05-21 21:49:08 -04:00
ca333 b879f536e9 debug.log spam prevention 2020-05-21 21:33:05 -04:00
Duke Leto 12d6704621 Merge branch 'duke' into danger 2020-05-21 21:23:45 -04:00
Duke Leto 52193c6a86 Merge branch 'dev' into duke 2020-05-21 21:22:43 -04:00
Duke Leto a6c0532d16 Merge pull request #107 from MyHush/subatomic
Subatomic Swaps In Hush
2020-05-21 12:10:37 -07:00
Duke Leto 16477843d6 Merge branch 'duke' into danger 2020-05-19 23:34:07 -04:00
DenioD 6e4be99c21 Add dpow season 4 pubkeys Issue #109 2020-05-19 10:20:28 +02:00
DenioD f3a4f77368 port expired transaction notify from Zcash. Issue #110 2020-05-19 10:03:53 +02:00
ssadler eabcce62f7 return void where possible and pass references to indicate that a NULL result is impossible 2020-05-12 21:42:37 -04:00
ssadler 2324e8ca4b fix fingerprint encoding 2020-05-12 21:42:03 -04:00
Duke Leto 095157d2d9 Remove sprout junk 2020-05-11 06:42:01 -04:00
Duke Leto dd5d932f87 Only print these when -zdebug is turned on 2020-05-11 06:34:48 -04:00
Duke Leto 8a4e72fca2 Remove some sprout code from BuildWitnessCache 2020-05-08 08:57:34 -04:00
Duke Leto 888efff4d1 Add subatomic to dapp makefile 2020-04-30 07:06:47 -04:00
Duke Leto 70bd156655 Add dapp header to make subatomic happy 2020-04-30 07:04:52 -04:00
Duke Leto 19ddbe1280 Update subatomic json 2020-04-30 06:57:21 -04:00
Duke Leto ed0385b524 Initial merge of subatomic dapp from KMD upstream
from dev branch of https://github.com/jl777/komodo/

commit d75041c478bcd721d44be0ab9af45c3d2ba2f69b
2020-04-30 06:51:54 -04:00
DenioD b3c7e048ab add z_getnotescount as rpc call ported for Hush from https://github.com/zcash/zcash/pull/4465 2020-04-25 00:30:06 +02:00
Duke Leto 1009c7933d CLI arg -z2zforkheight and avoid a compiler warning 2020-04-16 22:10:25 -04:00
Duke Leto d170d08260 Merge pull request #98 from csharpee/bugsbunny
updated undefined behavior in accordance with zcash remedy rex4539 #4056
2020-04-16 08:43:46 -04:00
Duke Leto 41a4c84633 Refactor z2z and additionally set ac_private=1 when loading block index from disk
This should avoid the edge case when a node starts up after the z2z block height but
has not yet seen a new block and so does not yet know it is an -ac_private=1 chain,
as currently that is set in ConnectBlock.
2020-04-15 02:39:18 -04:00
Duke Leto a2013ecc39 Fix incorrect error message 2020-04-15 02:07:19 -04:00
Duke Leto 77cc82428b Hush Smart Chains 2020-04-15 00:59:47 -04:00
Duke Leto e515560837 Improve and remove mention of sprout in this error message 2020-04-14 22:27:24 -04:00
Duke Leto 3d9e662266 Switch to -ac_private=1 at our z2z fork height 2020-04-14 07:53:01 -04:00
Duke Leto bd88898ce0 Implement z2z transition period for mempool 2020-04-12 05:55:08 -04:00
Duke Leto a0e36da33c Spelling 2020-04-07 22:17:43 -04:00
Duke Leto be4812bd29 Use fee=0 if we do not have enough funds in this zaddr to pay a fee; track number of txs created 2020-04-07 21:17:58 -04:00
Duke Leto 941f983a9f speling iz hard 2020-04-07 21:16:04 -04:00
Duke Leto 32400168c1 Add logging for rare error cases in transaction builder 2020-04-07 21:15:39 -04:00
Duke Leto a96a1ebce5 Use fee=0 if we have less than a fee worth of funds to consolidate 2020-04-07 18:19:48 -04:00
Duke Leto cf4514deef Log more details during sapling consolidation 2020-04-07 13:36:46 -04:00
Duke Leto 88f846c359 Log more details for invalid binding sigs 2020-04-07 13:36:21 -04:00
Duke Leto 3175039f62 Log consolidation output amounts 2020-04-07 09:36:05 -04:00
Duke Leto 6cdf4dd765 Fix zrpcunsafe logging and log valueBalance when final_check fails 2020-04-07 00:11:53 -04:00
Duke Leto 4d56e542a8 Do not look for sprout notes 2020-04-06 23:07:11 -04:00
Duke Leto e03ef7f108 Avoid notes with height=0 2020-04-06 23:05:20 -04:00
Duke Leto 28f5f51e5e Do not call BatchWrite* for sprout 2020-04-06 23:03:27 -04:00
Duke Leto 848b78f848 Return early for unknown txs and log unconfirmed 2020-04-06 23:01:14 -04:00
Duke Leto a7dd309ad0 Add copyright 2020-04-06 18:37:02 -04:00