DragonX/dragonx
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 2 Wiki Activity
11,072 Commits 6 Branches 3 Tags
e6cd2a835646663b8d36d8f492d4076604bedc17
Commit Graph

396 Commits

Author SHA1 Message Date
Simon
e6cd2a8356 Closes #2964. z_sendmany once again makes v1 tx for taddr to taddr. 
In accordance with the Zcash protocol spec.
 2018-02-22 15:43:42 +00:00
Homu
933e0d6675 Auto merge of #2968 - maxgubler:v1.0.14-edit, r=str4d 
Fix documentation examples for z_importwallet z_exportwallet exportdir

Closes #2967.
 2018-02-21 20:14:32 -08:00
Homu
d4d2844829 Auto merge of #2463 - str4d:713-rollback-limit, r=str4d 
Implement roll-back limit for reorganisation

Part of  #2905. Closes #713.
 2018-02-20 15:17:22 -08:00
Maxwell Gubler
f70cd24521 Fix syntax examples for z_importwallet and export 2018-02-20 16:46:12 -05:00
Jack Grigg
818b94f94f Make number of inputs configurable in validatelargetx test 2018-02-20 04:22:22 +00:00
Jack Grigg
be12669982 Add consensus branch ID parameter to SignatureHash, remove SigVersion parameter 
We do not need to be able to calculate multiple SignatureHash versions for a
single transaction format; instead, we use the transaction format to determine
the SigVersion.

The consensus branch ID *does* need to be passed in from the outside, as only
the caller knows the context in which the SignatureHash is being calculated
(ie. mempool acceptance vs. block validation).

JoinSplit signature verification has been moved into ContextualCheckTransaction,
where the consensus branch ID can be obtained.

The argument to the sign command for zcash-tx has been modified to take a height
in addition to the optional sigtype flags.
 2018-02-20 04:22:20 +00:00
Jack Grigg
e005ff83ab Remove P2WPKH and P2WSH from signing logic 
Separated from the previous commit for ease of review.
 2018-02-20 04:22:19 +00:00
Pieter Wuille
157a5d0d9c BIP143: Signing logic 2018-02-20 04:22:19 +00:00
Pieter Wuille
c86a1cb86e BIP143: Verification logic 
Includes simplifications by Eric Lombrozo.

Edited for Zcash merge by Ariel Gabizon.
 2018-02-20 04:22:19 +00:00
Jack Grigg
57e6ecda5a Implement roll-back limit for reorganisation 
Closes #713.
 2018-02-19 16:32:42 +00:00
Simon
072099d788 Implementation of Overwinter transaction format ZIP 202. 2018-02-16 10:10:15 -08:00
Homu
1683c2d5bf Auto merge of #2143 - str4d:1997-viewing-keys, r=str4d 
Implement incoming viewing keys

Closes #1997.
 2017-12-20 14:11:05 -08:00
Jack Grigg
2bbfe6c4e8 Add cautions to z_getbalance and z_gettotalbalance help text about viewing keys 2017-12-20 11:24:51 +00:00
Jack Grigg
bec2235148 Cleanup: Add braces for clarity 2017-12-20 11:18:59 +00:00
Jack Grigg
7b8d4f87ec Modify zcrawkeygen RPC method to set "zcviewingkey" to the viewing key 
The "zcviewingkey" field has never been documented before, and the method itself
is deprecated; this just ensures it is consistent with the rest of the RPC.
 2017-12-20 00:46:41 +00:00
Jack Grigg
44e37656bf Add watch-only support to Zcash RPC methods 
Balance totals do not include spends linked to viewing key addresses, as
nullifiers cannot be calculated and therefore spends cannot be detected.
 2017-12-20 00:46:37 +00:00
Jack Grigg
9a2b8ae57f Update wallet logic to account for viewing keys 
The wallet code previously assumed that an unlocked wallet would always
have a spending key associated with a note decryptor. Viewing keys break
this assumption.
 2017-12-20 00:46:37 +00:00
Jack Grigg
e85b33a52e Add RPC methods for exporting/importing viewing keys 2017-12-20 00:46:37 +00:00
Jack Grigg
167cd33374 Implement viewing key storage in the wallet 2017-12-20 00:46:37 +00:00
Homu
f44a4cea42 Auto merge of #2790 - bitcartel:2746_payment_disclosure_prefix, r=str4d 
Closes #2746. Payment disclosure blobs now use 'zpd:' prefix.
 2017-12-15 10:31:58 -08:00
Simon
61345ae703 Closes #2746. Payment disclosure blobs now use 'zpd:' prefix. 2017-12-07 10:11:43 -08:00
Homu
019c4bddc8 Auto merge of #2741 - bitcartel:stop_dumpwallet_overwriting, r=str4d 
Prevent RPC calls dumpwallet and z_exportwallet from overwriting an existing file

Closes #2740
 2017-12-04 09:41:52 -08:00
Jack Grigg
642a1caf93 ViewingKey -> ReceivingKey per zcash/zips#117 2017-12-04 17:17:18 +00:00
Homu
28e0159707 Auto merge of #2724 - arcalinea:1020-add-examples-for-zrpc, r=str4d 
Add examples for z_rpc calls

Adds missing cli and json-rpc examples for `z_` rpc calls

Closes #2723
(Accidentally named the branch being merged in with wrong issue number)
 2017-12-04 08:39:20 -08:00
Cory Fields
4bfe8a744b c++11: CAccountingEntry must be defined before use in a list 
c++11ism. This fixes builds against libc++.
 2017-11-29 17:24:59 +00:00
Jay Graber
9eb8089e98 Fix cli help result for z_shieldcoinbase 2017-11-27 20:06:36 -08:00
syd
c72a4732cc Remove Boost conditional compilation. 
Boost is currently at version 106200 in the depends subsystem
so it is safe to remove code the refers to earlier versions.

This closes #2445
 2017-11-23 00:05:21 -05:00
Jay Graber
337a99a219 Add cli and rpc examples for z_sendmany 2017-11-17 13:17:51 -08:00
Simon
ba1dbb3040 RPC dumpwallet and z_exportwallet updated to no longer allow 
overwriting an existing file.
 2017-11-16 22:29:37 -08:00
Homu
c8ecd49574 Auto merge of #2159 - bitcartel:1.0.7_payment_disclosure, r=str4d 
Payment disclosure (experimental feature)
 2017-11-14 14:06:22 -08:00
Simon
45232b1961 Add payment disclosure as experimental feature. 2017-11-14 13:29:05 -08:00
Homu
6f9f09dfb0 Auto merge of #2670 - arielgabizon:lowmemprover, r=daira 
Low memory prover

This PR integrates @ebfull 's low memory changes:  https://github.com/zcash/zcash/pull/2243/commits
on top of @str4d 's work bringing in libsnark as a subtree
4699d0eb36
 2017-11-06 04:22:20 -08:00
Simon
c5dabd2b66 Closes #2639. Adds optional limit parameter with a default value of 50. 
The new parameter is to satisfy the principle of least astonishment
by providing a sensible default for the maximum number of transparent
inputs to shield.  If users do not configure -mempooltxinputlimit
it is possible for them to create transactions with hundreds of
inputs which suffer from mining delay, due to the current state of
the network where some miners have configured -mempooltxinputlimit
as a way to deal with the problem of quadratic hashing.
 2017-11-01 10:40:24 -07:00
Simon
c2d3bafeaa Closes #2639. z_shieldcoinbase is now supported, no longer experimental. 
This reverts commit 5023af7bd5.
 2017-10-26 11:29:36 -07:00
Sean Bowe
1a9543d064 Remove crusty old "loadVerifyingKey"/"loadProvingKey" APIs and associated invariants. 2017-10-21 15:42:41 +03:00
Homu
af549fe6ed Auto merge of #2650 - str4d:2645-listunspent-benchmark, r=str4d 
Add benchmark for listunspent

Closes #2645.
 2017-10-12 15:24:53 -07:00
Jay Graber
c16528495c s/zcash/Zcash 2017-10-04 17:06:51 -07:00
Bruno Arueira
d2c1e4a807 Removes out bitcoin mention in favor for zcash 
Bitcoin Core => Zcash
bitcoin address => Zcash address
bitcoinaddress => zcashaddress

Closes #1756
 2017-10-04 17:05:30 -07:00
Jack Grigg
99dd50c30c Add benchmark for listunspent 
Closes #2645.
 2017-10-04 12:48:50 +01:00
Simon
5023af7bd5 Closes #2637. Make z_shieldcoinbase an experimental feature where it 
can be enabled with: zcashd -experimentalfeatures -zshieldcoinbase.
 2017-09-27 10:43:54 -07:00
Simon
b85008e786 Update which lock to synchronize on when calling GetBestAnchor(). 2017-09-26 10:16:33 -07:00
Homu
f34c60de37 Auto merge of #2615 - bitcartel:2448_shield_coinbase, r=bitcartel 
Add RPC command shield_coinbase #2448.

Shield transparent coinbase funds by sending to a shielded z address. Closes #2448.
 2017-09-22 12:04:31 -07:00
Simon
06c19063bb Implement RPC shield_coinbase #2448. 2017-09-21 15:04:12 -07:00
Homu
8f16b27304 Auto merge of #2616 - nathan-at-least:importprivkey-shows-address.4, r=str4d 
Importprivkey shows address

Scratching an itch: make `importprivkey` output the corresponding address.

Without this PR, `importprivkey` shows no output. Because we're moving towards an "address-based" RPC interface, rather than "account-based", there's a gap when using `importprivkey` because there's no way to assign it to a specific account, but also no easy way to determine the address. This change fixes that wart.
 2017-09-21 14:29:03 -07:00
Homu
60b4a79000 Auto merge of #2620 - bitcartel:2583_watch_only_fspendable, r=str4d 
Closes #2583. Exclude watch-only utxos from coin selection.
 2017-09-20 04:49:48 -07:00
Simon
b17e1b4080 Closes #2583. Exclude watch-only utxos from z_sendmany coin selection. 2017-09-19 19:42:48 -07:00
Homu
6e9964ff70 Auto merge of #2613 - arielgabizon:load-wallet-benchmark, r=str4d 
Add load-wallet benchmark

Closes #2518.
 2017-09-19 01:52:22 -07:00
Ariel Gabizon
2e8aefdce1 add load-wallet benchmark 2017-09-18 21:54:53 +02:00
Homu
e0bef1de56 Auto merge of #2564 - str4d:2074-currency-units, r=str4d 
Rationalize currency unit to "ZEC"

Cherry-picked from the upstream PR bitcoin/bitcoin#6504

Part of #2074
 2017-09-18 00:07:52 -07:00
Nathan Wilcox
de422c066b [tests pass] Ensure importprivkey outputs the address in case key is already imported. 2017-09-18 15:30:42 +09:00