Pieter Wuille
c86a1cb86e
BIP143: Verification logic
...
Includes simplifications by Eric Lombrozo.
Edited for Zcash merge by Ariel Gabizon.
2018-02-20 04:22:19 +00:00
Simon
072099d788
Implementation of Overwinter transaction format ZIP 202.
2018-02-16 10:10:15 -08:00
Jack Grigg
642a1caf93
ViewingKey -> ReceivingKey per zcash/zips#117
2017-12-04 17:17:18 +00:00
Simon
45232b1961
Add payment disclosure as experimental feature.
2017-11-14 13:29:05 -08:00
ca333
9d36579649
uni3
2017-10-09 11:45:49 +02:00
Simon
b85008e786
Update which lock to synchronize on when calling GetBestAnchor().
2017-09-26 10:16:33 -07:00
Simon
b17e1b4080
Closes #2583 . Exclude watch-only utxos from z_sendmany coin selection.
2017-09-19 19:42:48 -07:00
Homu
d6e6f51724
Auto merge of #2526 - bitcartel:2480_segfault_zeroconf_from_zaddr, r=daira
...
Fixes #2480 where missing map entry would cause a segfault.
`wtxHeight = mapBlockIndex[wtx.hashBlock]->nHeight;` results in undefined behaviour when the block hash is not present in the map, returning a null value which is dereferenced via `->nHeight`. This error is triggered by a zero-conf wallet transaction which has not been mined yet. As discussed in #2480 , on some systems there is a segfault whilst on others there is a silent exit. This makes it difficult to write a test, but the fix has been tested empirically to confirm an exception is thrown. This PR fixes the segfault and complements #2525 which prevents a user from sending from a zaddr with minconf 0.
2017-07-27 22:42:59 -07:00
jl777
5101611f24
Test
2017-07-15 12:05:04 +02:00
jl777
4bfb533b13
Test
2017-07-15 11:24:57 +02:00
Simon
9b5da42745
Fixes #2480 . Null entry in map was dereferenced leading to a segfault.
2017-07-14 00:10:54 -07:00
jl777
ceb639e0e8
Test
2017-07-13 22:32:19 +02:00
jl777
a99362fad8
Test
2017-07-13 22:17:33 +02:00
jl777
3d0387c984
Test
2017-07-13 22:15:17 +02:00
jl777
f33d372c76
Test
2017-07-13 22:15:05 +02:00
Simon
b639bb1eef
Fixes #2519 . When sending from a zaddr, minconf cannot be zero.
2017-07-11 11:29:43 -07:00
Homu
59de56eeca
Auto merge of #2342 - bitcartel:1081__mempoolpatch, r=str4d
...
Add ability for node to reject tx from mempool by number of tx inputs
Implement short-term solution described in #2343 so that users can respond promptly to critical short-term problems caused by quadratic validation scaling, such as the getblocktemplate latency, block propagation latency, and mempool size inflation issues described in #2333 .
2017-06-21 14:42:13 -07:00
Simon
d8616d012a
Partial revert & fix for commit 9e84b5a ; code block in wrong location.
2017-06-19 21:11:34 -07:00
Simon
9e84b5aa0d
Check mempooltxinputlimit when creating a transaction to avoid local
...
mempool rejection.
2017-06-17 14:41:25 -07:00
Simon
c93a0872e8
Fix intermediate vpub_new leakage in multi joinsplit tx ( #1360 )
2017-06-13 23:21:53 -07:00
jl777
945f015d80
Initial merge
2017-03-30 04:35:16 +03:00
zkbot
312fbd9d0e
Auto merge of #1932 - aniemerg:1522-pause-mining-for-joinsplit, r=arcalinea
...
Pause mining during JoinSplit creation
Closes #1522 .
2017-03-02 01:23:44 +00:00
Allan Niemerg
49c2cecb9f
Pause mining during joinsplit creation
2017-03-01 16:54:26 -08:00
Jack Grigg
f54db399f2
Get rid of fPlus argument to FormatMoney in Zcash-specific code
2017-02-10 02:19:14 +00:00
Jack Grigg
0d37ae3a59
Migrate Zcash-specific code to UniValue
2017-02-10 00:52:57 +00:00
zkbot
b2e2dccc64
Auto merge of #2068 - bitcartel:2045_sendmany_fee_zero, r=bitcartel
...
Closes #2045 by allowing z_sendmany with 0 fee
2017-02-09 18:56:44 +00:00
Simon
43b6753782
Update zrpc vs zrpcunsafe logging in z_sendmany operation
2017-02-08 10:50:40 -08:00
Simon
7eccce4e44
Closes #2045 by allowing z_sendmany with 0 fee
2017-02-06 14:14:28 -08:00
Simon
ee84f279a9
Update z_sendmany logging
2017-02-01 09:27:44 -08:00
Simon
3110b793f0
Closes #2057 by adding extra zrpcunsafe logging
2017-01-31 22:00:46 -08:00
jl777
3ced93646d
Merge remote-tracking branch 'zcash/master' into dev
...
# Conflicts:
# .gitignore
# README.md
# src/Makefile.gtest.include
# src/gtest/test_checkblock.cpp
# src/init.cpp
# src/main.cpp
# src/main.h
# src/rpcserver.cpp
# src/test/checkblock_tests.cpp
# src/util.cpp
2017-01-25 09:26:28 +02:00
zkbot
f37f0805cc
Auto merge of #1980 - bitcartel:fix_z_sendmany_logging_bug_txid, r=ebfull
...
Fix bug where z_sendmany logged incorrect txid fragment when sending from taddr
Closes #1987 .
2017-01-18 05:10:18 +00:00
zkbot
c583e42e6b
Auto merge of #1977 - bitcartel:1967_z_sendmany_debug_age_of_notes, r=ebfull
...
Fixes #1967 by adding age of note to z_sendmany logging.
2017-01-18 04:29:06 +00:00
zkbot
1e8778a274
Auto merge of #1976 - bitcartel:1964_z_sendmany_exception_handling, r=ebfull
...
Fixes #1964 to catch general exception in z_sendmany and catch exceptions as reference-to-const.
2017-01-18 03:48:12 +00:00
Simon
8aa7937d44
Fixes #1960 : z_getoperationstatus/result now includes operation details.
2017-01-16 16:45:27 -08:00
Simon
4c1cd287be
Fixes a bug where the unsigned transaction was logged by z_sendmany
...
after a successful sign and send, meaning that the logged hash fragment
would be different from the txid logged by "AddToWallet". This issue
occured when sending from transparent addresses, as utxo inputs must be
signed. It did not occur when sending from shielded addresses.
2017-01-04 12:26:23 -08:00
Simon
01f6c5dbee
Fixes #1967 by adding age of note to z_sendmany logging.
2017-01-03 23:57:11 -08:00
Simon
fce7260811
Fixes #1964 to catch general exception in z_sendmany and catch
...
exceptions as reference-to-const.
2017-01-03 12:50:19 -08:00
jl777
bc17ac4928
Merge remote-tracking branch 'zcash/master' into rebase
...
# Conflicts:
# README.md
# src/Makefile.gtest.include
# src/chainparams.cpp
# src/init.cpp
# src/miner.cpp
# src/wallet/wallet.cpp
2016-12-12 12:19:13 +02:00
zkbot
a398121503
Auto merge of #1919 - ebfull:abstract-verification, r=str4d
...
Isolate verification to a ProofVerifier context object that allows verification behavior to be tuned by the caller.
This is an alternative foundation for #1892 , i.e., #1892 will have to be changed if this PR is accepted.
I think this is a safer approach because it allows us to isolate verification behavior to a single object. This will come in handy when @arielgabizon finishes the batching code.
2016-12-09 06:22:53 +00:00
zkbot
e68e26c208
Auto merge of #1911 - bitcartel:1823_witness_does_not_have_same_anchor_as_change_input, r=str4d
...
With chained joinsplits, witness anchors for input notes no longer cross block boundaries
Closes #1823
2016-12-08 01:23:40 +00:00
Simon
84e8c5f921
WitnessAnchorData only needs to store one witness per JSOutPoint.
2016-12-07 12:05:29 -08:00
Sean Bowe
bc59f53722
Isolate verification to a ProofVerifier context object that allows verification behavior to be tuned by the caller.
2016-12-05 12:40:06 -07:00
Simon
2d931e905b
Fixes #1823 . Witness anchors for input notes no longer cross block boundaries.
2016-12-03 00:22:42 -08:00
Simon
af53da0225
Closes #1903 . Add fee parameter to z_sendmany.
2016-11-30 14:23:35 -08:00
Simon
0afd3687c8
Closes #1854 . z_sendmany selects more utxos to avoid dust change output.
2016-11-15 17:12:37 -08:00
Simon
de38bfbbed
Track the correct change witness across chained joinsplits
2016-11-15 12:39:16 -08:00
jl777
09cd7f3aed
test
2016-11-11 09:30:38 -03:00
jl777
94eb04d704
osx compatibility
2016-11-11 09:25:48 -03:00
Simon
9384e74c50
Closes #1833 . Format currency amounts in z_sendmany error message.
...
Improve coverage of possible error states from z_sendmany.
Refactor qa test for z_sendmany operations.
2016-11-10 16:57:36 -08:00