Commit Graph

2252 Commits

Author SHA1 Message Date
zkbot
5c47d620f4 Auto merge of #1892 - str4d:1749-disable-js-verification-before-checkpoints, r=str4d
Skip JoinSplit verification before the last checkpoint

Part of #1749
2016-12-13 10:36:48 +00:00
Jack Grigg
c0ec0e756b Fix bug in IncrementNoteWitness() 2016-12-13 22:53:52 +13:00
Jack Grigg
78f4e0ef37 Rewrite reindex test to check beyond the max witness cache size 2016-12-13 22:53:29 +13:00
Jack Grigg
0752d1f8c4 Extract block-generation wallet test code into a function 2016-12-13 22:53:11 +13:00
Jack Grigg
35ce717f96 Fix bug in wallet tests 2016-12-13 22:50:57 +13:00
Jack Grigg
6f78f4f44c Only check cache validity for witnesses being incremented or decremented
Fixes the bug resulting from #1904.
2016-12-13 09:34:55 +13:00
jl777
bc17ac4928 Merge remote-tracking branch 'zcash/master' into rebase
# Conflicts:
#	README.md
#	src/Makefile.gtest.include
#	src/chainparams.cpp
#	src/init.cpp
#	src/miner.cpp
#	src/wallet/wallet.cpp
2016-12-12 12:19:13 +02:00
zkbot
9f7bc6cba5 Auto merge of #1904 - str4d:1749-write-witness-cache-with-best-block, r=ebfull
Write witness caches when writing the best block

For steady-state operation, this reduces the average time between wallet disk
writes from once per block to once per hour.

On -rescan, witness caches are only written out at the end along with the best
block, increasing speed while ensuring that on-disk state is kept consistent.

Witness caches are now never recreated during a -reindex, on the assumption that
the blocks themselves are not changing (the chain is just being reconstructed),
and so the witnesses will remain valid.

Part of #1749.
2016-12-09 21:11:15 +00:00
Jack Grigg
9d2cc3a784 Make the test pass by fixing the bug! 2016-12-10 00:56:32 +13:00
Jack Grigg
eeee6d5d6c Add a reindex test that fails because of a bug in decrementing witness caches
Ref: https://github.com/zcash/zcash/pull/1904#issuecomment-265992988
2016-12-10 00:51:32 +13:00
Jack Grigg
6fb8d0c2d6 Skip JoinSplit verification before the last checkpoint
Part of #1749
2016-12-09 21:06:45 +13:00
zkbot
8a6c070bfa Auto merge of #1870 - str4d:1749-benchmark-rescanning, r=str4d
Add benchmarks for rescan components

Part of #1749.
2016-12-09 07:12:22 +00:00
zkbot
a398121503 Auto merge of #1919 - ebfull:abstract-verification, r=str4d
Isolate verification to a ProofVerifier context object that allows verification behavior to be tuned by the caller.

This is an alternative foundation for #1892, i.e., #1892 will have to be changed if this PR is accepted.

I think this is a safer approach because it allows us to isolate verification behavior to a single object. This will come in handy when @arielgabizon finishes the batching code.
2016-12-09 06:22:53 +00:00
Jack Grigg
88b7f3c28b Generate JS for trydecryptnotes, make number of addresses a variable 2016-12-09 16:59:39 +13:00
zkbot
e68e26c208 Auto merge of #1911 - bitcartel:1823_witness_does_not_have_same_anchor_as_change_input, r=str4d
With chained joinsplits, witness anchors for input notes no longer cross block boundaries

Closes #1823
2016-12-08 01:23:40 +00:00
Simon
84e8c5f921 WitnessAnchorData only needs to store one witness per JSOutPoint. 2016-12-07 12:05:29 -08:00
Jack Grigg
d85758f5cc Document behaviour of CWallet::SetBestChain 2016-12-07 19:30:30 +13:00
Sean Bowe
bc59f53722 Isolate verification to a ProofVerifier context object that allows verification behavior to be tuned by the caller. 2016-12-05 12:40:06 -07:00
jl777
438eef939e test 2016-12-03 12:45:35 -03:00
jl777
637e8c9536 test 2016-12-03 12:14:46 -03:00
jl777
57d9cfcc31 test 2016-12-03 12:01:28 -03:00
jl777
8432a64f0e test 2016-12-03 11:41:16 -03:00
Simon
2d931e905b Fixes #1823. Witness anchors for input notes no longer cross block boundaries. 2016-12-03 00:22:42 -08:00
jl777
0b6c5cb4f8 test 2016-12-02 17:36:44 -03:00
jl777
ada006e086 test 2016-12-01 15:55:07 -03:00
Simon
af53da0225 Closes #1903. Add fee parameter to z_sendmany. 2016-11-30 14:23:35 -08:00
Jack Grigg
03f83b9b0d Write witness caches when writing the best block
For steady-state operation, this reduces the average time between wallet disk
writes from once per block to once per hour.

On -rescan, witness caches are only written out at the end along with the best
block, increasing speed while ensuring that on-disk state is kept consistent.

Witness caches are now never recreated during a -reindex, on the assumption that
the blocks themselves are not changing (the chain is just being reconstructed),
and so the witnesses will remain valid.

Part of #1749.
2016-11-30 14:04:37 +13:00
jl777
83b0138266 test 2016-11-27 10:18:00 -03:00
jl777
bff51d6788 test 2016-11-27 10:02:45 -03:00
jl777
1c05f0b501 test 2016-11-27 09:45:54 -03:00
jl777
aa114a6095 test 2016-11-27 09:34:23 -03:00
jl777
48a3cd18c9 test 2016-11-20 11:50:57 -03:00
jl777
90b0945631 test 2016-11-20 10:34:14 -03:00
jl777
6c4ad69317 test 2016-11-19 12:04:34 -03:00
jl777
ae20482363 test 2016-11-19 12:03:01 -03:00
jl777
ab91876752 test 2016-11-19 11:48:56 -03:00
jl777
3ec03ada29 test 2016-11-17 12:29:01 -03:00
Jack Grigg
0bb3d40f90 Add benchmark for incrementing note witnesses 2016-11-17 22:26:46 +13:00
Jack Grigg
0fbab55b1b Add benchmark for attempting decryption of notes 2016-11-17 19:09:45 +13:00
Simon
0afd3687c8 Closes #1854. z_sendmany selects more utxos to avoid dust change output. 2016-11-15 17:12:37 -08:00
jl777
cbe3042f73 test 2016-11-15 21:26:50 -03:00
jl777
9be8be588f test 2016-11-15 20:02:18 -03:00
jl777
15bcd69e99 test 2016-11-15 19:30:46 -03:00
jl777
da16b12e68 test 2016-11-15 19:30:14 -03:00
jl777
7098e8b929 test 2016-11-15 19:26:24 -03:00
jl777
f207306e04 test 2016-11-15 19:09:39 -03:00
jl777
09e3cf94a4 test 2016-11-15 19:07:45 -03:00
jl777
4b36674267 test 2016-11-15 18:28:07 -03:00
jl777
55d97e1a6e test 2016-11-15 18:03:57 -03:00
jl777
98f682257a test 2016-11-15 17:59:15 -03:00