2ad0b7bfe2
Use zcash constants
Simon
2016-09-08 16:40:31 -07:00
b99d4f9b17
Improve error reporting when attempting to spend coinbase utxos.
Simon
2016-09-08 15:05:37 -07:00
9fb18458e8
Add assert for two mutually exclusive member variables.
Simon
2016-09-08 15:03:20 -07:00
cc59ac12a9
Add ticket number to issues raised in comment.
Simon
2016-09-08 13:25:08 -07:00
00edda4ac6
Remove unused varible.
Simon
2016-09-08 12:34:01 -07:00
e2574666f6
Add lock for member variables. Clean up and clarify that id_ and creation_time_ are never to be mutated anywhere. Fix incomplete copy/assignment constructors.
Simon
2016-09-08 12:32:29 -07:00
da5e7e5185
Formatting and updated test per review.
Simon
2016-09-08 11:06:18 -07:00
03812fefe4
Fix incorrect default value for argument of GetFilteredNotes.
Simon
2016-09-07 23:36:40 -07:00
a101ef7979
Update log statement to include fee.
Simon
2016-09-07 23:35:24 -07:00
9bdad43462
Fix formatting
Simon
2016-09-07 23:07:05 -07:00
e883ffef91
Add test for calling RPC z_getbalance, z_gettotalbalance, z_listreceivedbyaddress with invalid parameters.
Simon
2016-09-07 23:01:32 -07:00
12448b6457
Add extra RPC parameter checks for minconf<0 and zaddr not belonging to wallet.
Simon
2016-09-07 23:00:47 -07:00
5e363861e0
Replace unique_lock with lock_guard, where appropriate, for consistency
Simon
2016-09-07 21:51:49 -07:00
a50fd5fdb7
Add lock guard to getNumberOfWorkers()
Simon
2016-09-07 21:48:49 -07:00
e91048f28d
Fix formatting
Simon
2016-09-07 21:47:45 -07:00
69a4cb448a
Move lock guard to start of addOperation to protect isClosed() and isFinishing()
Simon
2016-09-07 21:46:32 -07:00
61ea2abaf5
Update formatting and documentation.
Simon
2016-09-07 19:39:33 -07:00
ca0ec80b4c
Add 'DEPRECATED' to help message of zcraw* commands
Simon
2016-09-07 19:23:24 -07:00
6c41028f7c
Add z_listreceivedbyaddress RPC call
Simon
2016-09-07 16:09:16 -07:00
1b141933e5
Rename GetUnspentNotes to GetFilteredNotes
Simon
2016-09-07 16:07:26 -07:00
6d2d045c6b
Disable z_sendmany in safe mode
Simon
2016-09-07 15:39:23 -07:00
fc46069e81
Add more logging.
Simon
2016-09-07 14:36:18 -07:00
a9743bc8bf
Refactor async sendmany and getbalance calls to use GetUnspentNotes().
Simon
2016-09-07 11:54:26 -07:00
fe2f198277
Add test for GetUnspentNotes() in wallet.
Simon
2016-09-07 11:53:22 -07:00
a5ac2e25a0
Add GetUnspentNotes to wallet.
Simon
2016-09-07 11:52:32 -07:00
7b79275eba
Add tests to try and improve coverage of perform_joinsplit.
Simon
2016-09-07 11:51:29 -07:00
269310ce3c
Replace zcashParams_ with global.
Simon
2016-09-07 08:34:55 -07:00
5f8118c8a4
Revert "Reduce use of global pzcashParams with private member variable"
Simon
2016-09-07 08:29:13 -07:00
4b32c16ba5
Reduce use of global pzcashParams with private member variable
Simon
2016-09-06 22:59:14 -07:00
485145ea78
Disable proof generation when testmode is enabled in async SendMany operation.
Simon
2016-09-06 22:55:08 -07:00
4cff8a5c50
Fix typo in error message
Simon
2016-09-06 22:52:34 -07:00
a0a3334c4d
Add z_getbalance and z_gettotalbalance RPC calls to close#1201.
Simon
2016-09-06 15:15:33 -07:00
cff6f0ac46
Add friend class for testing private members of AsyncRPCOperation_sendmany.
Simon
2016-09-06 00:06:12 -07:00
9bb6162626
Add extra checking of memo data in hexadecimal string format.
Simon
2016-09-05 19:38:56 -07:00
a5905772c8
Add logging under the category "asyncrpc".
Simon
2016-09-05 11:31:51 -07:00
39c7f954d0
Remove redundant call.
Simon
2016-09-05 09:05:22 -07:00
fc4b127ed3
Add tests for async queue and rpc commands: z_getoperationstatus, z_getoperationresult, z_listoperationids, z_sendmany
Simon
2016-09-04 23:18:26 -07:00
15c83ac6b4
Remove redundant check when getting spending key for a payment address.
Simon
2016-09-04 19:08:12 -07:00
f86f625dce
Update RPCServer to use AsyncRPCQueue's shared queue.
Simon
2016-09-04 08:13:56 -07:00
423a63d0a9
Add shared queue to AsynRPCQueue.
Simon
2016-09-04 08:12:46 -07:00
b922924d14
Add test for AsyncRPCQueue and AsyncRPCOperation.
Simon
2016-09-03 22:25:13 -07:00
017b3ede33
Clear the operation queue when closing it.
Simon
2016-09-03 22:24:03 -07:00
87f7c98795
Refactor to use wallet note tracking from commit a72379
Simon
2016-09-03 14:13:27 -07:00
97b6f365a1
Fix bug where wallet was not persisting witnesses to disk. Author: str4d
Simon
2016-09-03 09:51:17 -07:00
9cd713439a
Added option to close a queue and wait for queued up operations to finish, rather than just closing a queue and immediately cancelling all operations.
Simon
2016-09-02 19:21:42 -07:00
c93d8bdf9c
Fix bug where call to sign and send a transaction was in wrong scope.
Simon
2016-09-02 08:52:44 -07:00
3fd5a615ac
Coinbase utxos can only be spent when sending to a single zaddr. Change from the transaction will be sent to the same zaddr.
Simon
2016-09-01 19:58:42 -07:00
008fccfa48
Disable option to allow multiple async rpc workers.
Simon
2016-09-01 17:02:11 -07:00
14af21e9f7
Add chaining of JoinSplits within a transaction.
Simon
2016-09-01 15:29:31 -07:00
c1eae2806cCloses#1293 by adding z_getoperationresult and making z_getoperationstatus idempotent.
Simon
2016-08-30 16:03:38 -07:00
3b54bf5813
Refactoring and small improvements to async rpc operations.
Simon
2016-08-28 19:50:39 -07:00
34f0001ccc
Implement RPC call z_listoperationids and update z_getoperationstatus to take a list parameter.
Simon
2016-08-22 09:18:44 -07:00
861513a01f
Add public method to AsycnRPCQueue to retrieve all the known operation ids.
Simon
2016-08-22 09:16:01 -07:00
c72a427274
Add public method to get state as a human readable string from an AsyncRPCOperation.
Simon
2016-08-22 09:15:22 -07:00
15d345466d
Successful result of z_sendmany returns txid so it doesn't need to return raw hex.
Simon
2016-08-22 09:14:04 -07:00
b7d7b2ad9d
z_sendmany from a taddr now routes change to a new address instead of back to the sender's taddr,
Simon
2016-08-21 23:57:12 -07:00
4876de6c6d
Update find_unspent_notes() as mapNoteAddrs_t has been replaced by mapNoteData_t.
Simon
2016-08-21 00:15:14 -07:00
dafb81614b
Implement z_sendmany RPC call.
Simon
2016-08-20 22:54:40 -07:00
4eb1a96f9a
Add public field 'memo' to JSOutput to enable creation of notes with custom memos.
Simon
2016-08-20 19:53:35 -07:00
8d08172d0d
Add config option 'rpcasyncthreads' to specify number of async rpc workers. Default is 1.
Simon
2016-08-19 12:25:33 -07:00
2e6321a154
Add prefix to async operation id so it is easier to manage on cli.
Simon
2016-08-19 12:23:46 -07:00
fc72c078be
Add async RPC queue and operation classes. Add z_getoperationstatus RPC command. Add z_sendmany RPC command (dummy implementation, does not send actual coins).
Simon
2016-08-16 10:33:04 -07:00
289b12e448
Add tests for refactored wallet code
Jack Grigg
2016-09-07 10:55:07 +12:00
ac1c94350d
Refactor wallet note code for testing
Jack Grigg
2016-09-07 10:11:04 +12:00
2271d3feda
Auto merge of #1338 - str4d:147-tweak-difficulty-adjustment-algorithm, r=ebfull
zkbot
2016-09-08 02:21:13 +00:00
0372ce1f92
Auto merge of #1355 - bitcartel:zc.v0.11.2.latest_paymentapi, r=ebfull
zkbot
2016-09-08 01:40:49 +00:00
622ced8a74
Adjust test to account for integer division precision loss
Jack Grigg
2016-09-08 12:46:00 +12:00
4b37cfd5b8
Remove unnecessary method
Jack Grigg
2016-09-08 12:22:08 +12:00
4ab24d3625
Update payment API documentation for beta 1
bitcartel
2016-09-07 16:53:24 -07:00
aea79ec053
Adjust test to avoid spurious failures
Jack Grigg
2016-09-08 11:34:50 +12:00
fa511e1084
Replace GetTxid() with GetHash() after rebase on latest.
Simon
2016-09-07 15:11:17 -07:00
33264f5b46
Remove GetTxid() from CTransaction and update test_txid
Simon
2016-08-30 12:55:05 -07:00
805344dcf4
Refactor: replace calls to GetTxid() with GetHash()
Simon
2016-08-30 12:49:38 -07:00
6c79b9a12a
Update txid gtest to verify #1144 has been removed: GetTxid() and GetHash() return the same result.
Simon
2016-08-27 16:10:30 -07:00
a64f681f2c
Remove #1144 from input data of script_tests.
Simon
2016-08-27 15:54:12 -07:00
5316bd3560
Remove #1144 from bloom_tests by reverting to commit 5012190.
Simon
2016-08-27 15:48:14 -07:00
3bdb071cc3
Remove #1144 from transaction.cpp by reverting back to commit 942bc46.
Simon
2016-08-27 13:58:50 -07:00
82f3c490b1
Remove #1144 from transaction.h.
Simon
2016-08-27 13:54:21 -07:00
02932fc9cc
Auto merge of #1341 - ebfull:fix-checktransaction-bug, r=ebfull
zkbot
2016-09-07 20:22:13 +00:00
a4b00373ab
Fix transaction test in test_bitcoin.
Sean Bowe
2016-09-07 13:55:31 -06:00
c5b5d50004
Auto merge of #1342 - ebfull:remove-todo, r=ebfull
zkbot
2016-09-07 16:55:23 +00:00
4a749674a8
Update tests for new genesis blocks
Jack Grigg
2016-09-07 09:50:28 +12:00
66f07f5d0d
Regenerate genesis blocks for new powLimits
Jack Grigg
2016-09-07 08:18:46 +12:00
3e24a533f5
Restrict powLimit due to difficulty averaging
Jack Grigg
2016-09-07 08:17:43 +12:00
7b173bd80f
Simplify difficulty averaging code
Jack Grigg
2016-09-06 23:03:36 +12:00
5fbb839f53
Add test of difficulty averaging
Jack Grigg
2016-09-06 23:01:58 +12:00
f50e8313f5
Remove accidental double-semicolon (harmless but odd)
Jack Grigg
2016-09-06 13:18:33 +12:00
8f3ec042af
Expand bounds on difficulty adjustment
Jack Grigg
2016-09-06 13:13:23 +12:00
cb708a99a5
Add comments explaining changed semantics of pow_tests
Jack Grigg
2016-09-06 11:33:28 +12:00
50aba0ec19
Remove TODO 808.
Sean Bowe
2016-09-05 13:03:32 -06:00
d7eeb7455b
Fix CheckTransaction bugs.
Sean Bowe
2016-09-05 12:18:43 -06:00
f6b6c9bed8
Update libsnark again.
Sean Bowe
2016-09-05 12:00:50 -06:00
333ea3c426
Remove testnet-only difficulty rules
Jack Grigg
2016-09-05 23:06:20 +12:00
29842505cc
Adjust from average difficulty instead of previous difficulty
Jack Grigg
2016-09-05 22:25:11 +12:00
b181f7032b
Auto merge of #1328 - bitcartel:zc.v0.11.2.latest_1298_rest_interface, r=ebfull
zkbot
2016-09-02 03:43:16 +00:00
485ace0a1b
Auto merge of #1311 - ebfull:cleanup-pp, r=ebfull
zkbot
2016-09-02 03:03:45 +00:00
8962f2a902
Update security-warnings.md about REST interface
bitcartel
2016-09-01 11:12:48 -07:00
2640989d9a
Auto merge of #1308 - str4d:1181-getmininginfo-testnet-difficulty-rules, r=ebfull
zkbot
2016-09-01 18:12:46 +00:00
8a620d507f
Auto merge of #1326 - str4d:1185-remove-mainnet-dns-seeds, r=ebfull
zkbot
2016-09-01 13:54:52 +00:00
a723794f81
Auto merge of #1233 - str4d:1199-note-tracking, r=str4d
zkbot
2016-09-01 08:17:07 +00:00
Simon