DanS
b7060c7de0
Third phase of the code-hygiene remediation: remove provably-dead code.
Each in-file deletion was adversarially verified (a per-finding investigator
plus a skeptic that greps the tree to refute deletability); the sanity grep
confirms zero dangling references, and the tree builds and self-mines clean.
Removed wholesale:
- src/cc/dapps/ (9 files, ~6,939 lines): a git-tracked but never-built Komodo
DEX / z-migration tool (hushdex.c, zmigrate.c, cJSON.c, ...). Nothing in
Makefile.am/configure.ac references it.
In-file dead code:
- pow.cpp: the `#ifdef original_algo` oldRT_CST_RST function (the macro is
never defined in source or build flags) and two `if ( 0 )` debug blocks.
- walletdb.cpp: the "orphaned staking transaction" cleanup path (deadTxns) —
DragonX is RandomX PoW with no staking, so the guard is always false and the
block never runs; also drop the now-unused static/extern decls.
- cc/eval.h: the ProcessCC / Eval::ImportCoin / ImportPayout / DisputePayout
declarations that have no definition anywhere in the tree.
- rpc/crosschain.cpp: the crosschainproof stub RPC (returned {} unconditionally)
and its registrations in rpc/server.cpp, rpc/server.h, rpc/client.cpp.
- coins.cpp: the commented-out `//TODO: delete` Sprout PushAnchor template.
- wallet.cpp: the permanently-zero KMD `interest2` term in CreateTransaction.
- rpc/net.cpp: hush_longestchain's always-zero `n` var (num > (n>>1) => num>0)
and its `if ( 0 )` debug branch.
- hush_nSPV.h / hush_nSPV_fullnode.h: three `if ( 0 && ... )` dead debug branches.
- net.cpp, crypter.h, saplingconsolidation.cpp (dup set_error_code),
shieldcoinbase.cpp (`donation < 0` on a uint8_t), cclib.cpp (unused
FAUCET2SIZE): single-line dead-code fixes.
Deliberately NOT touched (verification refuted the audit's "dead on DragonX"
premise): the ~2,250-line HUSH3 checkpoint block, the miner notary/timelock
paths, and hush_gateway.h — all reachable at runtime via -ac_name / -ac_*
args (the inherited Komodo assetchain model), and hush_gateway's
hush_opretvalidate is called from ConnectBlock (consensus). Dropping those
requires a deliberate decision to remove HAC/HUSH3 mode, tracked separately.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
178 lines
2.2 KiB
Plaintext
178 lines
2.2 KiB
Plaintext
*.tar.gz
|
|
*.deb
|
|
src/bitcoin
|
|
src/test/test_bitcoin
|
|
src/core
|
|
test-*.txt
|
|
|
|
*zcashTest.pk
|
|
*zcashTest.vk
|
|
|
|
# autoreconf
|
|
#Makefile.in
|
|
aclocal.m4
|
|
autom4te.cache/
|
|
build-aux/config.guess
|
|
build-aux/config.sub
|
|
build-aux/depcomp
|
|
build-aux/install-sh
|
|
build-aux/ltmain.sh
|
|
build-aux/m4/libtool.m4
|
|
build-aux/m4/lt~obsolete.m4
|
|
build-aux/m4/ltoptions.m4
|
|
build-aux/m4/ltsugar.m4
|
|
build-aux/m4/ltversion.m4
|
|
build-aux/missing
|
|
build-aux/compile
|
|
build-aux/test-driver
|
|
config.log
|
|
config.status
|
|
configure
|
|
configure~
|
|
libtool
|
|
src/config/bitcoin-config.h
|
|
src/config/bitcoin-config.h.in
|
|
src/config/stamp-h1
|
|
|
|
cache/
|
|
venv-mnf/
|
|
src/univalue/gen
|
|
|
|
.deps
|
|
.dirstamp
|
|
.idea
|
|
.libs
|
|
.*.sw?
|
|
*.*~*
|
|
*.bak
|
|
*.rej
|
|
*.orig
|
|
*.pyc
|
|
*.o
|
|
*.o-*
|
|
.zcash
|
|
*.a
|
|
*.pb.cc
|
|
*.pb.h
|
|
.vscode
|
|
|
|
*.log
|
|
*.trs
|
|
*.dmg
|
|
|
|
*.json.h
|
|
*.raw.h
|
|
|
|
#libtool object files
|
|
*.lo
|
|
*.la
|
|
|
|
# Compilation
|
|
Makefile
|
|
|
|
# Unit-tests
|
|
Makefile.test
|
|
src/test/buildenv.py
|
|
|
|
# Resources cpp
|
|
qrc_*.cpp
|
|
|
|
# Mac specific
|
|
.DS_Store
|
|
build
|
|
|
|
#lcov
|
|
*.gcno
|
|
*.gcda
|
|
/*.info
|
|
test_bitcoin.coverage/
|
|
zcash-gtest.coverage/
|
|
total.coverage/
|
|
coverage_percent.txt
|
|
|
|
#build tests
|
|
linux-coverage-build
|
|
linux-build
|
|
win32-build
|
|
qa/pull-tester/run-bitcoind-for-test.sh
|
|
qa/pull-tester/tests-config.sh
|
|
qa/pull-tester/cache/*
|
|
qa/pull-tester/test.*/*
|
|
|
|
!src/leveldb*/Makefile
|
|
|
|
/doc/doxygen/
|
|
|
|
libzcashconsensus.pc
|
|
|
|
src/fiat/-usd
|
|
contrib/debian/files
|
|
contrib/debian/substvars
|
|
|
|
src/rpcmisc~.cpp
|
|
src/wallet-utility
|
|
|
|
src/hush-cli
|
|
src/hushd
|
|
src/hush-tx
|
|
src/hush-test
|
|
src/hush-cli.exe
|
|
src/hushd.exe
|
|
src/hush-tx.exe
|
|
|
|
#output during builds, symbol tables?
|
|
*.dSYM
|
|
|
|
|
|
src/cryptoconditions/compile
|
|
|
|
src/cc/rogue/rogue
|
|
|
|
src/cc/rogue/rogue.so
|
|
|
|
src/cc/rogue/test.zip
|
|
src/checkfile
|
|
|
|
src/foo.zip
|
|
|
|
src/log
|
|
|
|
src/rogue.530623577502174316.0
|
|
|
|
src/rogue.530623577502174316.pack
|
|
|
|
src/rogue.530623577502174316.player
|
|
|
|
|
|
src/cc/rogue/config.h
|
|
|
|
src/ROGUE.conf
|
|
|
|
src/rogue.scr
|
|
|
|
src/cc/rogue/confdefs.h
|
|
src/cc/rogue/x64
|
|
|
|
src/Makefile.in
|
|
doc/man/Makefile.in
|
|
Makefile.in
|
|
src/libcc.so
|
|
src/libcc.dll
|
|
src/libcc.dylib
|
|
src/cc/customcc.so
|
|
src/cc/customcc.dll
|
|
src/cc/customcc.dylib
|
|
src/HUSH3_7776
|
|
REGTEST_7776
|
|
src/cc/librogue.so
|
|
src/cc/games/prices
|
|
src/cc/games/tetris
|
|
release-linux/
|
|
release/
|
|
src/dragonxd
|
|
src/dragonx-cli
|
|
src/dragonx-tx
|
|
src/dragonxd.exe
|
|
src/dragonx-cli.exe
|
|
src/dragonx-tx.exe
|
|
doc/relnotes/ |