From 32400168c10fd91cdbddfea79fffe261a5e4a8c6 Mon Sep 17 00:00:00 2001
From: Duke Leto <duke@leto.net>
Date: Tue, 7 Apr 2020 21:15:39 -0400
Subject: [PATCH] Add logging for rare error cases in transaction builder

---
 src/transaction_builder.cpp | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/src/transaction_builder.cpp b/src/transaction_builder.cpp
index 3964617ca..8b1acaca9 100644
--- a/src/transaction_builder.cpp
+++ b/src/transaction_builder.cpp
@@ -142,6 +142,7 @@ boost::optional<CTransaction> TransactionBuilder::Build()
         change -= tOut.nValue;
     }
     if (change < 0) {
+        LogPrintf("%s: negative change!\n", __func__);
         return boost::none;
     }
 
@@ -182,6 +183,7 @@ boost::optional<CTransaction> TransactionBuilder::Build()
         auto nf = spend.note.nullifier(
             spend.expsk.full_viewing_key(), spend.witness.position());
         if (!(cm && nf)) {
+            LogPrintf("%s: Invalid commitment or nullifier!\n", __FUNCTION__);
             librustzcash_sapling_proving_ctx_free(ctx);
             return boost::none;
         }
@@ -205,6 +207,7 @@ boost::optional<CTransaction> TransactionBuilder::Build()
                 sdesc.rk.begin(),
                 sdesc.zkproof.data())) {
             librustzcash_sapling_proving_ctx_free(ctx);
+            LogPrintf("%s: Invalid sapling spend proof!\n", __FUNCTION__);
             return boost::none;
         }
 
@@ -218,6 +221,7 @@ boost::optional<CTransaction> TransactionBuilder::Build()
     for (auto output : outputs) {
         auto cm = output.note.cm();
         if (!cm) {
+            LogPrintf("%s: Invalid sapling note commitment!\n", __FUNCTION__);
             librustzcash_sapling_proving_ctx_free(ctx);
             return boost::none;
         }
@@ -243,6 +247,7 @@ boost::optional<CTransaction> TransactionBuilder::Build()
                 odesc.cv.begin(),
                 odesc.zkproof.begin())) {
             librustzcash_sapling_proving_ctx_free(ctx);
+            LogPrintf("%s: Invalid sapling output proof!\n", __FUNCTION__);
             return boost::none;
         }
 
@@ -275,6 +280,7 @@ boost::optional<CTransaction> TransactionBuilder::Build()
         dataToBeSigned = SignatureHash(scriptCode, mtx, NOT_AN_INPUT, SIGHASH_ALL, 0, consensusBranchId);
     } catch (std::logic_error ex) {
         librustzcash_sapling_proving_ctx_free(ctx);
+        LogPrintf("%s: SignatureHash exception!\n", __func__);
         return boost::none;
     }
 
@@ -293,6 +299,7 @@ boost::optional<CTransaction> TransactionBuilder::Build()
         mtx.bindingSig.data());
 
     librustzcash_sapling_proving_ctx_free(ctx);
+    LogPrintf("%s: Created spendAuth and binding sigs\n", __func__);
 
     // Transparent signatures
     CTransaction txNewConst(mtx);