DragonX/hush3
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Don't increase banscore if the transaction only just expired.

Browse Source 
Author: Jack Grigg <str4d@z.cash>
This commit is contained in:
Daira Hopwood
2018-04-04 01:28:57 +01:00
parent a0ea82301a
commit 473a113241
2 changed files with 17 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
qa/rpc-tests/p2p_txexpiry_dos.py
View File

@@ -97,7 +97,7 @@ class TxExpiryDoSTest(BitcoinTestFramework):
# Mininodes send transaction to zcashd node.
def setExpiryHeight(tx):
tx.nExpiryHeight = 1
tx.nExpiryHeight = 101
spendtx = self.create_transaction(self.nodes[0],
self.coinbase_blocks[0],
@@ -114,6 +114,19 @@ class TxExpiryDoSTest(BitcoinTestFramework):
assert_equal(1, versions.count(OVERWINTER_PROTO_VERSION))
assert_equal(0, peerinfo[0]["banscore"])
# Mine a block and resend the transaction
self.nodes[0].generate(1)
test_node.send_message(msg_tx(spendtx))
time.sleep(3)
# Verify test mininode has not been dropped
# but has a banscore of 10.
peerinfo = self.nodes[0].getpeerinfo()
versions = [x["version"] for x in peerinfo]
assert_equal(1, versions.count(OVERWINTER_PROTO_VERSION))
assert_equal(10, peerinfo[0]["banscore"])
[ c.disconnect_node() for c in connections ]
if __name__ == '__main__':