diff --git a/src/main.cpp b/src/main.cpp index 634dc177b..cb6cef5bb 100644 --- a/src/main.cpp +++ b/src/main.cpp @@ -1039,12 +1039,14 @@ bool CheckTransactionWithoutProofVerification(const CTransaction& tx, CValidatio } } - // Transactions can contain empty `vin` and `vout` so long as - // either `vjoinsplit` or `vShieldedSpend` are non-empty. + // Transactions containing empty `vin` must have either non-empty + // `vjoinsplit` or non-empty `vShieldedSpend`. if (tx.vin.empty() && tx.vjoinsplit.empty() && tx.vShieldedSpend.empty()) return state.DoS(10, error("CheckTransaction(): vin empty"), REJECT_INVALID, "bad-txns-vin-empty"); - if (tx.vout.empty() && tx.vjoinsplit.empty() && tx.vShieldedSpend.empty()) + // Transactions containing empty `vout` must have either non-empty + // `vjoinsplit` or non-empty `vShieldedOutput`. + if (tx.vout.empty() && tx.vjoinsplit.empty() && tx.vShieldedOutput.empty()) return state.DoS(10, error("CheckTransaction(): vout empty"), REJECT_INVALID, "bad-txns-vout-empty"); diff --git a/src/test/transaction_tests.cpp b/src/test/transaction_tests.cpp index 8524e1bc2..30c69882a 100644 --- a/src/test/transaction_tests.cpp +++ b/src/test/transaction_tests.cpp @@ -408,6 +408,16 @@ void test_simple_sapling_invalidity(uint32_t consensusBranchId, CMutableTransact BOOST_CHECK(!CheckTransactionWithoutProofVerification(newTx, state)); BOOST_CHECK(state.GetRejectReason() == "bad-txns-vin-empty"); } + { + CMutableTransaction newTx(tx); + CValidationState state; + + newTx.vShieldedSpend.push_back(SpendDescription()); + newTx.vShieldedSpend[0].nullifier = GetRandHash(); + + BOOST_CHECK(!CheckTransactionWithoutProofVerification(newTx, state)); + BOOST_CHECK(state.GetRejectReason() == "bad-txns-vout-empty"); + } { // Ensure that nullifiers are never duplicated within a transaction. CMutableTransaction newTx(tx); @@ -415,6 +425,9 @@ void test_simple_sapling_invalidity(uint32_t consensusBranchId, CMutableTransact newTx.vShieldedSpend.push_back(SpendDescription()); newTx.vShieldedSpend[0].nullifier = GetRandHash(); + + newTx.vShieldedOutput.push_back(OutputDescription()); + newTx.vShieldedSpend.push_back(SpendDescription()); newTx.vShieldedSpend[1].nullifier = newTx.vShieldedSpend[0].nullifier;