DragonX/hush3
1
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

Auto merge of #2894 - per-gron:dont-export-unless-needed, r=str4d

Browse Source 
Make some globals static that can be

I wrote this patch as part of making a Bazel build system but it really is independent from that so I'm putting this as a separate PR.

External linkage does not help and just encourages sloppy dependencies (ie using symbols only declared in a cpp file in some other cpp file) and can lead to weird issues when there are name collisions.
This commit is contained in:
Homu
2018-05-04 15:05:43 -07:00
parent d97bfb766b 39d2e9e0cb
commit 8ef1d333b5
9 changed files with 36 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/zcash/JoinSplit.cpp
View File

@@ -24,8 +24,7 @@ namespace libzcash {
#include "zcash/circuit/gadget.tcc"
CCriticalSection cs_ParamsIO;
CCriticalSection cs_LoadKeys;
static CCriticalSection cs_ParamsIO;
template<typename T>
void saveToFile(const std::string path, T& obj) {