Auto merge of #3206 - bitcartel:3194_polymorphic_note_class, r=str4d

Update note classes to be polymorphic Closes #3194. Lays foundation for introduction of Sapling notes through refactoring and creation of a class hierarchy for Sprout notes. This PR updates some tests, but otherwise is a no-op.
2018-05-02 08:07:35 -07:00
parent 53fa6f1315 debf6af9f8
commit 9e5398686c
24 changed files with 206 additions and 148 deletions
--- a/src/primitives/transaction.cpp
+++ b/src/primitives/transaction.cpp
@@ -20,7 +20,7 @@ JSDescription::JSDescription(ZCJoinSplit& params,
            uint256 *esk // payment disclosure
            ) : vpub_old(vpub_old), vpub_new(vpub_new), anchor(anchor)
 {
-    boost::array<libzcash::Note, ZC_NUM_JS_OUTPUTS> notes;
+    boost::array<libzcash::SproutNote, ZC_NUM_JS_OUTPUTS> notes;

    proof = params.prove(
        inputs,