Fixed CCs RPC tests (#1314)

* updated diceaddress rpc keys, added prints for diceaddress key / value

        # removed Dicemarker
        # fixed DiceCCaddress spelling to DiceCCAddress
        # NOTE myaddress/myAddress is duplicated
        # added DiceCCTokensAddress DiceNormalAddress
        # removed CCaddress

* Updated keys for faucetaddress

* Update cryptoconditions_oracles.py

Updated address keys.

* update test-rpc keys

* fixed rewards test

* fixed channels tests

* fixed tokenCC tests

qa/rpc-tests/cryptoconditions_channels.py

@@ -31,7 +31,8 @@ class CryptoconditionsChannelsTest(CryptoconditionsTestFramework):
         result = rpc.channelsaddress(self.pubkey)
         assert_success(result)
         # test that additional CCaddress key is returned
-        for x in ['myCCaddress', 'ChannelsCCaddress', 'Channelsmarker', 'myaddress', 'CCaddress']:
+        for x in ['ChannelsCC1of2TokensAddress', 'myCCAddress(Channels)', 'ChannelsCC1of2Address', 'myAddress', \
+                  'myCCaddress', 'ChannelsNormalAddress', 'PubkeyCCaddress(Channels)', 'ChannelsCCAddress']:
             assert_equal(result[x][0], 'R')
 
         # getting empty channels list

qa/rpc-tests/cryptoconditions_dice.py

@@ -24,15 +24,19 @@ class CryptoconditionsDiceTest(CryptoconditionsTestFramework):
         result = rpc1.getbalance()
         assert_greater_than(result, 100000)
 
-        dice  = rpc.diceaddress()
+        result  = rpc.diceaddress()
-        assert_equal(dice['result'], 'success')
+        for x in result.keys():
-        for x in ['myCCaddress', 'DiceCCaddress', 'Dicemarker', 'myaddress']:
+            print(x+": "+str(result[x]))  
-            assert_equal(dice[x][0], 'R')
+        assert_equal(result['result'], 'success')
+        for x in ['myCCaddress', 'DiceCCAddress', 'myaddress']:
+            assert_equal(result[x][0], 'R')
 
-        dice  = rpc.diceaddress(self.pubkey)
+        result  = rpc.diceaddress(self.pubkey)
-        assert_equal(dice['result'], 'success')
+        for x in result.keys():
-        for x in ['myCCaddress', 'DiceCCaddress', 'Dicemarker', 'myaddress', 'CCaddress']:
+            print(x+": "+str(result[x]))   
-            assert_equal(dice[x][0], 'R')
+        assert_equal(result['result'], 'success')
+        for x in ['myCCaddress', 'DiceCCAddress', 'myaddress', 'DiceCCTokensAddress', 'DiceNormalAddress']:
+            assert_equal(result[x][0], 'R')
 
         # no dice created yet
         result  = rpc.dicelist()

qa/rpc-tests/cryptoconditions_faucet.py

@@ -24,16 +24,20 @@ class CryptoconditionsFaucetTest(CryptoconditionsTestFramework):
         assert_greater_than(result['balance'], 0.0)
         balance = result['balance']
 
-        faucet  = rpc.faucetaddress()
+        result  = rpc.faucetaddress()
-        assert_equal(faucet['result'], 'success')
+        assert_equal(result['result'], 'success')
+        for x in result.keys():
+            print(x+": "+str(result[x]))   
         # verify all keys look like valid AC addrs, could be better
-        for x in ['myCCaddress', 'FaucetCCaddress', 'Faucetmarker', 'myaddress']:
+        for x in ['myCCaddress', 'FaucetCCTokensAddress', 'FaucetNormalAddress', 'myaddress']:
-            assert_equal(faucet[x][0], 'R')
+            assert_equal(result[x][0], 'R')
 
         result  = rpc.faucetaddress(self.pubkey)
         assert_success(result)
+        for x in result.keys():
+            print(x+": "+str(result[x]))   
         # test that additional CCaddress key is returned
-        for x in ['myCCaddress', 'FaucetCCaddress', 'Faucetmarker', 'myaddress', 'CCaddress']:
+        for x in ['myCCaddress', 'FaucetCCTokensAddress', 'FaucetNormalAddress', 'myaddress']:
             assert_equal(result[x][0], 'R')
 
         # no funds in the faucet yet

qa/rpc-tests/cryptoconditions_heir.py

@@ -20,16 +20,16 @@ class CryptoconditionsHeirTest(CryptoconditionsTestFramework):
         rpc = self.nodes[0]
         rpc1 = self.nodes[1]
 
-        result = rpc.heiraddress()
+        result = rpc.heiraddress('')
         assert_success(result)
         # verify all keys look like valid AC addrs, could be better
-        for x in ['myCCaddress', 'HeirCCaddress', 'Heirmarker', 'myaddress']:
+        for x in ['HeirNormalAddress', 'HeirCCTokensAddress', 'myaddress', 'myCCaddress', 'HeirCCAddress']:
             assert_equal(result[x][0], 'R')
 
         result = rpc.heiraddress(self.pubkey)
         assert_success(result)
         # test that additional CCaddress key is returned
-        for x in ['myCCaddress', 'HeirCCaddress', 'Heirmarker', 'myaddress', 'CCaddress']:
+        for x in ['HeirNormalAddress', 'myCCaddress', 'myaddress', 'HeirCC1of2Address', 'HeirCCAddress', 'HeirCC1of2TokensAddress']:
             assert_equal(result[x][0], 'R')
 
         # getting empty heir list

qa/rpc-tests/cryptoconditions_oracles.py

@@ -22,12 +22,12 @@ class CryptoconditionsOraclesTest(CryptoconditionsTestFramework):
 
         result = rpc.oraclesaddress()
         assert_success(result)
-        for x in ['OraclesCCaddress', 'Oraclesmarker', 'myCCaddress', 'myaddress']:
+        for x in ['myCCaddress', 'OraclesCCAddress', 'OraclesNormalAddress', 'myaddress', 'OraclesCCTokensAddress']:
             assert_equal(result[x][0], 'R')
 
         result = rpc.oraclesaddress(self.pubkey)
         assert_success(result)
-        for x in ['OraclesCCaddress', 'Oraclesmarker', 'myCCaddress', 'myaddress']:
+        for x in ['myCCaddress', 'OraclesCCAddress', 'OraclesNormalAddress', 'myaddress', 'OraclesCCTokensAddress']:
             assert_equal(result[x][0], 'R')
 
         # there are no oracles created yet

qa/rpc-tests/cryptoconditions_rewards.py

@@ -15,13 +15,15 @@ from cryptoconditions import assert_success, assert_error, generate_random_strin
 class CryptoconditionsRewardsTest(CryptoconditionsTestFramework):
 
     def run_rewards_tests(self):
+
         rpc = self.nodes[0]
+
         result = rpc.rewardsaddress()
-        for x in ['RewardsCCaddress', 'myCCaddress', 'Rewardsmarker', 'myaddress']:
+        for x in ['myCCaddress', 'myaddress', 'RewardsCCAddress', 'RewardsCCTokensAddress', 'RewardsNormalAddress']:
             assert_equal(result[x][0], 'R')
 
         result = rpc.rewardsaddress(self.pubkey)
-        for x in ['RewardsCCaddress', 'myCCaddress', 'Rewardsmarker', 'myaddress', 'CCaddress']:
+        for x in ['myCCaddress', 'myaddress', 'RewardsCCAddress', 'RewardsCCTokensAddress', 'RewardsNormalAddress']:
             assert_equal(result[x][0], 'R')
 
         # no rewards yet

qa/rpc-tests/cryptoconditions_token.py

@@ -21,22 +21,22 @@ class CryptoconditionsTokenTest(CryptoconditionsTestFramework):
 
         result = rpc.tokenaddress()
         assert_success(result)
-        for x in ['TokensCCaddress', 'myCCaddress', 'Tokensmarker', 'myaddress']:
+        for x in ['TokensCCAddress', 'myCCaddress', 'myCCAddress(Tokens)', 'myaddress', 'TokensNormalAddress']:
             assert_equal(result[x][0], 'R')
 
         result = rpc.tokenaddress(self.pubkey)
         assert_success(result)
-        for x in ['TokensCCaddress', 'myCCaddress', 'Tokensmarker', 'myaddress', 'CCaddress']:
+        for x in ['TokensCCAddress', 'myCCaddress', 'myCCAddress(Tokens)', 'myaddress', 'TokensNormalAddress']:
             assert_equal(result[x][0], 'R')
 
         result = rpc.assetsaddress()
         assert_success(result)
-        for x in ['AssetsCCaddress', 'myCCaddress', 'Assetsmarker', 'myaddress']:
+        for x in ['AssetsCCAddress', 'myCCaddress', 'myCCAddress(Assets)', 'myaddress', 'AssetsNormalAddress']:
             assert_equal(result[x][0], 'R')
 
         result = rpc.assetsaddress(self.pubkey)
         assert_success(result)
-        for x in ['AssetsCCaddress', 'myCCaddress', 'Assetsmarker', 'myaddress', 'CCaddress']:
+        for x in ['AssetsCCAddress', 'myCCaddress', 'myCCAddress(Assets)', 'myaddress', 'AssetsNormalAddress']:
             assert_equal(result[x][0], 'R')
 
         # there are no tokens created yet
@@ -61,7 +61,7 @@ class CryptoconditionsTokenTest(CryptoconditionsTestFramework):
         assert_equal(result[0], tokenid)
 
         # there are no token orders yet
-        result = rpc.tokenorders()
+        result = rpc.tokenorders(tokenid)
         assert_equal(result, [])
 
         # getting token balance for non existing tokenid
@@ -117,7 +117,7 @@ class CryptoconditionsTokenTest(CryptoconditionsTestFramework):
         tokenask = rpc.tokenask("100", tokenid, "7.77")
         tokenaskhex = tokenask['hex']
         tokenaskid = self.send_and_mine(tokenask['hex'], rpc)
-        result = rpc.tokenorders()
+        result = rpc.tokenorders(tokenid)
         order = result[0]
         assert order, "found order"
 
@@ -136,7 +136,7 @@ class CryptoconditionsTokenTest(CryptoconditionsTestFramework):
         assert txid, "found txid"
 
         # should be no token orders
-        result = rpc.tokenorders()
+        result = rpc.tokenorders(tokenid)
         assert_equal(result, [])
 
         # checking ask cancellation
@@ -157,7 +157,7 @@ class CryptoconditionsTokenTest(CryptoconditionsTestFramework):
         # from valid node
         cancel = rpc.tokencancelask(tokenid, testorderid)
         self.send_and_mine(cancel["hex"], rpc)
-        result = rpc.tokenorders()
+        result = rpc.tokenorders(tokenid)
         assert_equal(result, [])
 
 
@@ -184,7 +184,7 @@ class CryptoconditionsTokenTest(CryptoconditionsTestFramework):
         tokenbid = rpc.tokenbid("100", tokenid, "10")
         tokenbidhex = tokenbid['hex']
         tokenbidid = self.send_and_mine(tokenbid['hex'], rpc)
-        result = rpc.tokenorders()
+        result = rpc.tokenorders(tokenid)
         order = result[0]
         assert order, "found order"
 
@@ -203,7 +203,7 @@ class CryptoconditionsTokenTest(CryptoconditionsTestFramework):
         assert txid, "found txid"
 
         # should be no token orders
-        result = rpc.tokenorders()
+        result = rpc.tokenorders(tokenid)
         assert_equal(result, [])
 
         # checking bid cancellation
@@ -220,7 +220,7 @@ class CryptoconditionsTokenTest(CryptoconditionsTestFramework):
         # from valid node
         cancel = rpc.tokencancelbid(tokenid, testorderid)
         self.send_and_mine(cancel["hex"], rpc)
-        result = rpc.tokenorders()
+        result = rpc.tokenorders(tokenid)
         assert_equal(result, [])
 
         # invalid token transfer amount (have to add status to CC code!)