From ba63dacbbbc647e4a84824a7aee5838c5bcabab4 Mon Sep 17 00:00:00 2001 From: Jack Grigg Date: Thu, 13 Sep 2018 22:04:00 +0100 Subject: [PATCH] Use the correct empty memo for Sapling outputs --- src/transaction_builder.cpp | 4 ++-- src/transaction_builder.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/transaction_builder.cpp b/src/transaction_builder.cpp index e137cbdb8..880edbbc7 100644 --- a/src/transaction_builder.cpp +++ b/src/transaction_builder.cpp @@ -128,7 +128,7 @@ boost::optional TransactionBuilder::Build() // Send change to the specified change address. If no change address // was set, send change to the first Sapling address given as input. if (zChangeAddr) { - AddSaplingOutput(zChangeAddr->first, zChangeAddr->second, change, {}); + AddSaplingOutput(zChangeAddr->first, zChangeAddr->second, change); } else if (tChangeAddr) { // tChangeAddr has already been validated. assert(AddTransparentOutput(tChangeAddr.value(), change)); @@ -136,7 +136,7 @@ boost::optional TransactionBuilder::Build() auto fvk = spends[0].expsk.full_viewing_key(); auto note = spends[0].note; libzcash::SaplingPaymentAddress changeAddr(note.d, note.pk_d); - AddSaplingOutput(fvk.ovk, changeAddr, change, {}); + AddSaplingOutput(fvk.ovk, changeAddr, change); } else { return boost::none; } diff --git a/src/transaction_builder.h b/src/transaction_builder.h index 560898381..c7eca80f1 100644 --- a/src/transaction_builder.h +++ b/src/transaction_builder.h @@ -86,7 +86,7 @@ public: uint256 ovk, libzcash::SaplingPaymentAddress to, CAmount value, - std::array memo); + std::array memo = {{0xF6}}); // Assumes that the value correctly corresponds to the provided UTXO. void AddTransparentInput(COutPoint utxo, CScript scriptPubKey, CAmount value);