From 05ec7887f1cd3f84a655fc4b0b0769652b350adb Mon Sep 17 00:00:00 2001 From: Sean Bowe Date: Thu, 9 Feb 2017 14:34:53 -0700 Subject: [PATCH 1/2] Fix use after free in transaction_tests. --- src/test/transaction_tests.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/test/transaction_tests.cpp b/src/test/transaction_tests.cpp index 64fa4b298..7568989cd 100644 --- a/src/test/transaction_tests.cpp +++ b/src/test/transaction_tests.cpp @@ -475,6 +475,7 @@ BOOST_AUTO_TEST_CASE(test_simple_joinsplit_invalidity) jsdesc->nullifiers[1] = GetRandHash(); newTx.vjoinsplit.push_back(JSDescription()); + jsdesc = &newTx.vjoinsplit[0]; JSDescription *jsdesc2 = &newTx.vjoinsplit[1]; jsdesc2->nullifiers[0] = GetRandHash(); From 6605125d4e9cd2bf0a02727ded12fade0a7d9f13 Mon Sep 17 00:00:00 2001 From: Simon Date: Thu, 9 Feb 2017 15:17:21 -0800 Subject: [PATCH 2/2] Add comment about fix for #2026. --- src/test/transaction_tests.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/test/transaction_tests.cpp b/src/test/transaction_tests.cpp index 7568989cd..f717a5f3e 100644 --- a/src/test/transaction_tests.cpp +++ b/src/test/transaction_tests.cpp @@ -475,7 +475,7 @@ BOOST_AUTO_TEST_CASE(test_simple_joinsplit_invalidity) jsdesc->nullifiers[1] = GetRandHash(); newTx.vjoinsplit.push_back(JSDescription()); - jsdesc = &newTx.vjoinsplit[0]; + jsdesc = &newTx.vjoinsplit[0]; // Fixes #2026. Related PR #2078. JSDescription *jsdesc2 = &newTx.vjoinsplit[1]; jsdesc2->nullifiers[0] = GetRandHash();