DragonX/hush3
1
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity
9,774 Commits 1 Branch 1 Tag
07c967aca7bef2789f7dfbd84e85dac0b1e5514c
Commit Graph

6683 Commits

Author SHA1 Message Date
zkbot
6bad499c2a Auto merge of #1640 - daira:upstream-update-tinyformat, r=daira 
util: Update tinyformat

Updates `tinyformat.h` to commit
3a33bbf654 upstream.

Makes sure that our local changes are kept:

- bitcoin/bitcoin#3767 1b8fd35aad Make tinyformat errors raise an exception instead of assert()ing
- bitcoin/bitcoin#4735 9b6d4c5cdc Move strprintf define to tinyformat.h
- bitcoin/bitcoin#4748 6e5fd003e0 include stdexcept (for std::exception)
- bitcoin/bitcoin#8000 9eaa0afa6ec5d3dd01e4d01121314ef51f2bc305 force USE_VARIADIC_TEMPLATES
- Add `std::string format(const std::string &fmt...` added this
  at the time, as we want to be able to do `strprintf(_(...), ...)`

Inspired by bitcoin/bitcoin#8264.

For Zcash: ref #1349
 2016-10-25 18:29:45 -04:00
zkbot
489f1d38ee Auto merge of #1629 - bitcartel:1616_wallet_disallow_coinbase_change, r=daira 
Add z_sendmany rule that when coinbase utxos must be spent in their entirety, with no change

See #1616 - coinbase utxos must be consumed entirely, without any change, since there
is currently no way to specify a change address in z_sendmany.
 2016-10-25 15:40:36 -04:00
zkbot
a1f81867f0 Auto merge of #1620 - bitcartel:1616_z_sendmany_need_0_message_bug, r=bitcartel 
Fix incorrect error message in z_sendmany

Fixes one of the problems in #1616.
 2016-10-25 15:02:29 -04:00
Daira Hopwood
c5b9bd9cad util: Update tinyformat 
Updates `tinyformat.h` to commit
3a33bbf654 upstream.

Makes sure that our local changes are kept:

- #3767 1b8fd35aad Make tinyformat errors raise an exception instead of assert()ing
- #4735 9b6d4c5cdc Move strprintf define to tinyformat.h
- #4748 6e5fd003e0 include stdexcept (for std::exception)
- #8000 9eaa0afa6ec5d3dd01e4d01121314ef51f2bc305 force USE_VARIADIC_TEMPLATES
- Add `std::string format(const std::string &fmt...` added this
  at the time, as we want to be able to do `strprintf(_(...), ...)`

Inspired by #8264.
 2016-10-25 19:48:38 +01:00
Simon
ad0ba9467d Add assert to AsyncRPCOperation_sendmany 2016-10-25 11:25:05 -07:00
zkbot
511c5ec1d0 Auto merge of #1615 - arithmetric:1612.fix-floating-point-exception, r=daira 
Fixing floating point exception in non-TTY environments

As reported in #1612, a floating point exception occurs when zcashd is started with `showmetrics` enabled in environments without a TTY, such as when started as a service or piped to a file.

The root cause is that the metrics code attempts to get the screen width and uses this as a divisor in calculations. For non-TTY environments, this value is 0, leading to a division by zero error.

This PR adds a default screen width of 80 and uses the actual screen width only if the width can be fetched (and in a TTY environment).
 2016-10-25 11:43:28 -04:00
Pieter Wuille
bf673640e3 Use std::atomic for fRequestShutdown and fReopenDebugLog 2016-10-24 21:55:52 -07:00
Pieter Wuille
3f97a535ee Revert "Include signal.h for sig_atomic_t in WIN32" 
This reverts commit 88f14b999cb70f6c556633f2889e698a05305158.
 2016-10-24 21:55:40 -07:00
Pieter Wuille
bf3905fe8f Include signal.h for sig_atomic_t in WIN32 2016-10-24 21:55:26 -07:00
Chirag Davé
7a4e0e0932 fReopenDebugLog and fRequestShutdown should be type sig_atomic_t 
This allows access as an atomic variable in the presence
of async interrupts.

See issue #7433 for more details
fixes: #7433
 2016-10-24 21:54:50 -07:00
Simon
db026807b8 Add z_sendmany rule that when sending coinbase utxos to a zaddr 
they must be consumed entirely, without any change, since there
is currently no way to specify a change address in z_sendmany.
 2016-10-24 21:34:16 -07:00
Simon
10d1b90987 Fix incorrect error message in z_sendmany 2016-10-24 07:59:32 -07:00
Joe Turgeon
1da44b346c Adding handling for ioctl failure. Updates from code review in PR #1615. 2016-10-23 21:23:56 -05:00
Joe Turgeon
c0876672fa Fixing floating point exception caused by metrics. Using default column width unless in a TTY. 2016-10-23 10:54:50 -05:00
Daira Hopwood
5c5f70f0fc Update pchMessageStart strings for rc2. 
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
 2016-10-23 02:22:08 +01:00
Daira Hopwood
d14207f6f4 Bump version numbers to 1.0.0-rc2. 
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
 2016-10-23 02:22:08 +01:00
zkbot
a294b26db7 Auto merge of #1375 - str4d:1331-node-metrics, r=daira 
Add node metrics screen

Continuation of #1336
Closes #1331
 2016-10-22 20:21:11 -04:00
Jack Grigg
dccc140bf1 Comment out print statements in tromp's solver 
This prevents the solver interfering with the metrics screen.
 2016-10-22 15:59:44 -05:00
Jack Grigg
199b3aafd3 Use solutions per second (Sol/s) 
Part of #1422
 2016-10-22 15:50:23 -05:00
Jack Grigg
f8ada2435b Be excited about validating transactions! 2016-10-22 15:50:21 -05:00
Jack Grigg
e7d59bbc12 Add average hash rate to metrics 2016-10-22 15:50:20 -05:00
Jack Grigg
db853f8a46 Handle wrapping of potentially long lines 2016-10-22 15:50:18 -05:00
Jack Grigg
0ddd6d1cd8 Tag metrics strings for translation 2016-10-22 15:50:17 -05:00
Jack Grigg
d30273f919 Split out screen sections into separate functions 2016-10-22 15:50:16 -05:00
Jack Grigg
4482bd8fd7 Adjust copy 2016-10-22 15:50:14 -05:00
Jack Grigg
d934e68967 Fit metrics screen into an 80-column terminal without wrapping 2016-10-22 15:50:13 -05:00
Jack Grigg
4ace963c80 Show important console messages on metrics screen 2016-10-22 15:50:11 -05:00
Jack Grigg
a6df7ab567 Add a persistent screen showing basic node metrics 
The screen is implemented using ANSI Escape sequences.

Closes #1331
 2016-10-22 15:50:06 -05:00
zkbot
026c3f784f Auto merge of #1602 - str4d:1424-minimal-getblocktemplate, r=daira 
Minimal modifications to getblocktemplate

A simpler alternative to #1435 that ensures Zcash GBT will remain compatible with BIP 22.

Closes #1424
 2016-10-22 16:40:59 -04:00
zkbot
30d3d2dfd4 Auto merge of #1603 - str4d:1556-reject-old-block-versions, r=daira 
Reject block versions lower than 4

Includes parts of #1554
Closes #1556
 2016-10-22 14:32:40 -04:00
zkbot
f82273829a Auto merge of #1600 - str4d:1557-consensus-rule-disallow-v0-txns, r=daira 
Disallow v0 transactions as a consensus rule

Closes #1557
 2016-10-22 13:50:52 -04:00
zkbot
e3c8e88e9b Auto merge of #1588 - bitcartel:upstream_8427_dos_logging, r=daira 
Upstream: Prevent possible DoS in logging

bitcoin/bitcoin#8427
 2016-10-22 13:08:26 -04:00
Simon
432bc22ade Patch backport of upstream 1588 as we don't (yet) use the NetMsgType namespace 2016-10-22 09:49:35 -07:00
Jack Grigg
f4f1b4b097 Update sighash tests for new consensus rule 2016-10-22 11:09:07 -05:00
Jack Grigg
77175766f4 Enforce standard transaction rules on testnet 
Closes #1582
 2016-10-22 09:03:09 -05:00
Daira Hopwood
789914e7b0 Update comments in chainparams.cpp. 
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
 2016-10-22 13:46:22 +01:00
Daira Hopwood
a5fd8da7ba Static assertion that standard and network min tx versions are consistent. 
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
 2016-10-22 13:46:22 +01:00
Daira Hopwood
cb1246194e Update the error message string for tx version too low. ref #1600 
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
 2016-10-22 13:26:44 +01:00
zkbot
0b3809464c Auto merge of #1601 - str4d:1459-revert-reversion, r=daira 
Revert "Revert "Avoid boost::posix_time functions that have potential out-of-bounds read bugs. ref #1459""

This reverts commit f19cb7b7ee.

Closes #1459.
 2016-10-22 07:06:40 -04:00
Jack Grigg
86d2c90468 Update tests for new genesis blocks 2016-10-22 00:52:58 -05:00
Jack Grigg
8c54e34a68 Use tromp's solver to regenerate miner tests 
When using, comment out tromp's solver in miner.cpp to avoid linker errors.
 2016-10-22 00:52:56 -05:00
Jack Grigg
6be6762237 Regenerate genesis blocks with nVersion = 4 
Includes parts of #1554
 2016-10-22 00:52:45 -05:00
Jack Grigg
80f4cdcf8f Reject block versions lower than 4 
Closes #1556
 2016-10-22 00:43:26 -05:00
Jack Grigg
7ac924cdb7 Disallow v0 transactions as a consensus rule 
Closes #1557
 2016-10-22 00:40:50 -05:00
zkbot
a12eaa2bf2 Auto merge of #1581 - bitcartel:1464_ncc_2016_008, r=str4d 
Fixes for NCC-2016-008

To close #1464 NCC-2016-088

- This PR
- https://github.com/zcash/libsnark/pull/8

Of the 101 issues in NCC-2016-088, 62 are in dependencies, and many of the remainder are duplicates of the CIDs fixed in this PR.

Commit log message is: CID Type (Type is from scan.coverity Type column)
 2016-10-22 00:56:08 -04:00
Simon
e11e61ddb1 Workaround g++ 5.x bug with brace enclosed initializer. 
http://stackoverflow.com/questions/32912921/whats-wrong-with-this-inline-initialization-of-stdarray/32912976#32912976
 2016-10-21 21:50:25 -07:00
Jack Grigg
89aa746ca1 GBT: Add informational founders' reward value to coinbasetxn 2016-10-21 23:36:04 -05:00
Jack Grigg
53ddbaed16 GBT: Support coinbasetxn instead of coinbasevalue 
Once a Zcash GBT spec has been written, we can re-enable coinbasevalue.
 2016-10-21 23:32:24 -05:00
Jack Grigg
09864abc55 Revert "Revert "Avoid boost::posix_time functions that have potential out-of-bounds read bugs. ref #1459"" 
This reverts commit f19cb7b7ee.
 2016-10-21 23:14:00 -05:00
zkbot
7ccbcca62c Auto merge of #1591 - bitcartel:upstream_7933_fix_out_of_memory_deserializing_utxo, r=daira 
Upstream: fix out of memory problem when deserializing utxo

bitcoin/bitcoin#7933
 2016-10-21 23:32:51 -04:00