CMAKE_SIZEOF_VOID_P EQUAL 8 was added in newer versions of RandomX and breaks cross-compiling with MXE for Windows builds even though they are 64-bit.
3f69ad7b79
Array index 2 does not exist, which caused the foundersrewardaddress
key of getblocktemplate to be incorrect. It would either show the next
address in the list or be empty if it caused a read past the end of the
2D DEVTAX_DATA array. This is what happens in gcc 9.4.0 but since this
is technically Undefined Behavior according to the C Standard it could
cause a crash or even make demons fly out of your nose.
See http://catb.org/jargon/html/N/nasal-demons.html for details.
This option can disable automatic resending of txs. It defaults to the
normal behavior of resending txs automatically and resending can be disabled
with -resendtx=0 .
This is not intended for normal usage and is undocumented for now. It is
useful for devs who are debugging internals and also when rescanning large
wallets. We seem to have either some bugs and/or performance problems when
rescanning wallets with many txs.
This is a greatly simplified and slightly tweaked version of
af2e3713e2
Their version will detect duplicate zkproofs across transactions while
this code will only detect duplicate zkproofs in a single ztx. If dupes
are found, the tx will be denied entry into the mempool.
This provides most of the benefit (increased CPU cost to attackers) with the
least code change and no annoyance to full node operators. Detecting
duplicate zkproofs across transactions requires a one-time reindex of
all of history, which means significant downtime for nodes.
Since Hush + HSCs have a much more strict policy on number of shielded
outputs and shielded inputs, only detecting duplicate zkproofs in
individual ztxs seems sufficient for now.
No correctly functioning node or wallet will ever create duplicate
zkproofs, so there is no worry of this accidentally affecting normal
users. Currently this is not a consensus rule but it could become one
in the future.
