DragonX/hush3
1
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity
10,687 Commits 1 Branch 1 Tag
26a8f68ea8a021c1fa096fd4528b6b98e89a2e62
Commit Graph

7233 Commits

Author SHA1 Message Date
Sean Bowe
26a8f68ea8 Remove libsnark from depends system and integrate it into build system. 2017-08-02 15:49:30 +01:00
Jack Grigg
a06446408c Merge commit '51e448641d6cbcd582afa22cd8475f8c3086dad7' as 'src/snark' 2017-08-02 11:17:32 +01:00
Jack Grigg
51e448641d Squashed 'src/snark/' content from commit 9ada3f8 
git-subtree-dir: src/snark
git-subtree-split: 9ada3f84ab484c57b2247c2f41091fd6a0916573
 2017-08-02 11:17:25 +01:00
Ariel Gabizon
fcf824e9f1 make-release.py: Versioning changes for 1.0.11-rc1. 2017-08-01 17:11:57 +02:00
Homu
10acd8a1fb Auto merge of #2484 - str4d:block-download-completion, r=daira 
Add block download progress to metrics UI
 2017-07-28 21:57:19 -07:00
Jack Grigg
92bfde0edf Improve network height estimation 2017-07-28 10:50:07 +00:00
Jack Grigg
4a651837be Correct and extend EstimateNetHeightInner tests 
Corrections are to the median block times, which were generated by subtracting
CBlockIndex::nMedianTimeSpan / 2 from the block height and then multiplying by
the target spacing. GetMedianTimePast() takes an array sorted by std::sort() and
returns element CBlockIndex::nMedianTimeSpan / 2, meaning that if
CBlockIndex::nMedianTimeSpan is odd (which it is), there is an out-by-one error
in the subtraction.
 2017-07-28 10:45:44 +00:00
Homu
d6e6f51724 Auto merge of #2526 - bitcartel:2480_segfault_zeroconf_from_zaddr, r=daira 
Fixes #2480 where missing map entry would cause a segfault.

`wtxHeight = mapBlockIndex[wtx.hashBlock]->nHeight;` results in undefined behaviour when the block hash is not present in the map, returning a null value which is dereferenced via `->nHeight`.  This error is triggered by a zero-conf wallet transaction which has not been mined yet.  As discussed in #2480, on some systems there is a segfault whilst on others there is a silent exit.  This makes it difficult to write a test, but the fix has been tested empirically to confirm an exception is thrown.  This PR fixes the segfault and complements #2525 which prevents a user from sending from a zaddr with minconf 0.
 2017-07-27 22:42:59 -07:00
Jack Grigg
047aec1e0e Add block download progress to metrics UI 2017-07-26 00:51:12 +00:00
Homu
e88ab1a920 Auto merge of #2529 - str4d:2444-rpc-www-authenticate, r=daira 
[rpc] Add WWW-Authenticate header to 401 response

Fix cherry-picked from upstream PR bitcoin/bitcoin#7472.

Closes #2444.
 2017-07-25 15:36:33 -07:00
Homu
a698116b28 Auto merge of #2478 - bitcartel:2477_send_alert_1.0.10, r=daira 
Alert for 2017-06-23.a degraded networking (fixed in 1.0.10-1)

Alert 1004 (version 1.0.10 only) Issue #2477
 2017-07-25 13:03:53 -07:00
Homu
95d18784ec Auto merge of #2525 - bitcartel:2519_no_zero_minconf_from_zaddr_zsendmany, r=daira 
When sending from a zaddr, minconf cannot be zero.

Closes #2519.
 2017-07-20 08:24:54 -07:00
Homu
d2627bc65d Auto merge of #2504 - daira:2501.remove-upnp, r=daira 
Remove UPnP support. fixes #2500

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
 2017-07-16 03:43:54 -07:00
Simon
9b5da42745 Fixes #2480. Null entry in map was dereferenced leading to a segfault. 2017-07-14 00:10:54 -07:00
Wladimir J. van der Laan
20fb708e6f rpc: Add WWW-Authenticate header to 401 response 
A WWW-Authenticate header must be present in the 401
response to make clients know that they can authenticate,
and how.

    WWW-Authenticate: Basic realm="jsonrpc"

Fixes #7462.
 2017-07-12 16:37:48 -05:00
Jack Grigg
689264bbff Add test for issue #2444 
A WWW-Authenticate header must be present in the 401 response to make clients
know that they can authenticate, and how.
 2017-07-12 16:34:58 -05:00
Simon
b639bb1eef Fixes #2519. When sending from a zaddr, minconf cannot be zero. 2017-07-11 11:29:43 -07:00
Simon
d77a0ac4a0 Closes #2446 by adding generated field to listunspent. 
If generated is true, the unspent transaction output is from a
coinbase transaction and can only be sent to a shielded address.
 2017-07-11 10:44:36 -07:00
Homu
90a255a747 Auto merge of #2464 - str4d:torcontrol-rbf-resource-leak, r=daira 
Net: Fix resource leak in ReadBinaryFile(...)

Introduced in 3290567bbd via PR #2177.

Cherry-picked from Bitcoin PR https://github.com/bitcoin/bitcoin/pull/10408
 2017-07-10 10:43:22 -07:00
Daira Hopwood
506a21850a Remove UPnP support. fixes #2500 
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
 2017-07-03 08:57:05 +01:00
Daira Hopwood
262fc5f4e3 Alert 1004 (version 1.0.10 only) 
Author: Simon <simon@bitcartel.com>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
 2017-06-24 19:49:41 +01:00
Simon
d444e1cf40 make-release.py: Versioning changes for 1.0.10-1. 2017-06-23 19:43:29 -07:00
Sean Bowe
15a9937654 Revert "Delete old protocol version constants and simplify code that used them." 
This reverts commit 5a49c929dd.
 2017-06-23 18:19:25 -06:00
Sean Bowe
9ad9a25eff Revert "Remove an unneeded version workaround as per @str4d's review comment." 
This reverts commit 1e9db0b38a.
 2017-06-23 18:19:17 -06:00
practicalswift
1240717431 Net: Fix resource leak in ReadBinaryFile(...) 
Introduced in 3290567bbd via PR #2177.
 2017-06-23 18:49:43 +12:00
Jack Grigg
dc2ead6021 make-release.py: Versioning changes for 1.0.10. 2017-06-22 14:47:15 +12:00
Homu
59de56eeca Auto merge of #2342 - bitcartel:1081__mempoolpatch, r=str4d 
Add ability for node to reject tx from mempool by number of tx inputs

Implement short-term solution described in #2343 so that users can respond promptly to critical short-term problems caused by quadratic validation scaling, such as the getblocktemplate latency, block propagation latency, and mempool size inflation issues described in #2333.
 2017-06-21 14:42:13 -07:00
Homu
02e5fffadc Auto merge of #2360 - daira:2359.remove-lax-der-validation, r=arcalinea 
Remove unneeded lax ECDSA signature verification

Fixes #2359. Removes code for lax ECDSA verification, and the SCRIPT_VERIFY_DERSIG flag that controlled it. The behaviour is as-if the flag is always set.
 2017-06-20 19:05:58 -07:00
Simon
d8616d012a Partial revert & fix for commit 9e84b5a ; code block in wrong location. 2017-06-19 21:11:34 -07:00
Jack Grigg
4ef014151d Additional testing of -mempooltxinputlimit 2017-06-20 15:58:46 +12:00
Kevin Pan
26d27a15ce "getblocktemplate" could work without wallet 2017-06-20 10:41:46 +08:00
Daira Hopwood
c2a722d3c4 Fix a comment that was made stale before launch by #1016 (commit 542da61). 
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
 2017-06-19 16:33:18 +01:00
Daira Hopwood
00fde35b1c Make transaction test failures print the comments preceding the test JSON. 
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
 2017-06-19 16:33:18 +01:00
Daira Hopwood
4a785b0a5b Repair tests for strict DER signatures. 
While we're at it, repair a similar test for CLTV, and make the repaired RPC tests run by default.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
 2017-06-19 16:32:15 +01:00
Simon
9e84b5aa0d Check mempooltxinputlimit when creating a transaction to avoid local 
mempool rejection.
 2017-06-17 14:41:25 -07:00
Daira Hopwood
de609b8c54 Strict DER signatures are always enforced; remove the flag and code that used it. 
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
 2017-06-17 17:19:08 +01:00
Daira Hopwood
3c985d26ce Remove unneeded lax ECDSA signature verification. 
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
 2017-06-17 17:19:08 +01:00
Homu
ef24e8e6be Auto merge of #2335 - str4d:2333-validation-speed, r=str4d 
Switch to libsecp256k1-based validation for ECDSA

Cherry-picked from the following upstream PRs:

- bitcoin/bitcoin#6983
- bitcoin/bitcoin#6954

Part of #2333.
 2017-06-17 07:18:25 -07:00
Jack Grigg
b661736b87 Hold an ECCVerifyHandle in zcash-gtest 2017-06-18 02:15:05 +12:00
Jack Grigg
5799c5f8c0 Add test for -mempooltxinputlimit 2017-06-17 14:59:16 +12:00
Simon
da6d93916d Add option 'mempooltxinputlimit' so the mempool can reject a transaction 
based on the number of transparent inputs.
 2017-06-16 19:31:33 -07:00
Jack Grigg
fd0d1c7d60 Ensure that ECDSA constant sizes are correctly-sized 2017-06-17 12:10:15 +12:00
Jack Grigg
1f5941062a Remove redundant = 0 initialisations 2017-06-17 12:10:14 +12:00
Jack Grigg
877964c82f Specify ECDSA constant sizes as constants 2017-06-17 12:10:14 +12:00
Jack Grigg
c032f1b687 Add comments 2017-06-17 12:09:44 +12:00
Homu
dfa4ed19bb Auto merge of #2440 - bitcartel:1360_reduce_info_leakage_vpub_new, r=str4d 
Fix intermediate vpub_new leakage in multi joinsplit tx

Resolves information leakage discussed here https://github.com/zcash/zcash/issues/1360#issuecomment-284561331

Example output in debug.log showing how intermediate vpub_new is now 0
https://gist.github.com/bitcartel/86ca316b74f0b1ec6d8de3ac132006da

When reviewing, note that the indentation of a large chunk of code (scenario 3 part 2) changed, so use `git diff -w` (or similar) or append `?w=1` to the Github URL e.g. https://github.com/zcash/zcash/pull/2440/files?w=1
 2017-06-15 21:33:01 -07:00
Homu
3440de74ee Auto merge of #2386 - str4d:2385-consensus-correction, r=str4d 
Correct consensus logic in ContextualCheckInputs

Closes #2385.
 2017-06-15 18:50:03 -07:00
Jack Grigg
30006a2e79 Correct consensus logic in ContextualCheckInputs 
Closes #2385.
 2017-06-16 13:45:19 +12:00
Jack Grigg
1b786a93c3 Add test for incorrect consensus logic 2017-06-16 13:45:14 +12:00
Homu
0a80a1cea3 Auto merge of #2227 - str4d:2074-ignore-virtual-cores, r=str4d 
Use real number of cores, ignore virtual cores

Cherry-picked from the following upstream PRs:

- bitcoin/bitcoin#6361
- bitcoin/bitcoin#6370

Part of #2074.
 2017-06-15 17:05:02 -07:00