Commit Graph

15515 Commits

Author SHA1 Message Date
David Dawes
63713e5567 Force unsigned 64 bit, not u32. 2018-10-14 21:23:03 -07:00
miketout
9befb850b6 Comment out test code 2018-10-14 17:03:26 -07:00
miketout
75c34b7494 Latest Zcash bug fixes 2018-10-14 15:09:50 -07:00
miketout
d738023b12 Stop removing future txes for later resend 2018-10-14 14:46:40 -07:00
miketout
d565e7b73c Eliminate mapBlockIndex risk of nulls across VRSC 2018-10-14 11:59:13 -07:00
miketout
aeadfa0490 Debugging 2018-10-14 03:21:49 -07:00
miketout
98760e4a4b Update minimum chain work for Verus and test chains 2018-10-14 02:25:33 -07:00
miketout
5106eab4d1 C string vs. std::string 2018-10-14 01:49:14 -07:00
miketout
ba375e2e92 Debugging network messages 2018-10-14 01:43:51 -07:00
miketout
41e9e058e0 Additional null pindex checks 2018-10-14 01:31:58 -07:00
miketout
e82ee7e3cc Don't stake on null wallet call 2018-10-14 00:01:16 -07:00
miketout
ec8a120b4d Cleanup, comment out test code, prepare for release PR 2018-10-13 22:49:45 -07:00
miketout
11f4f605e2 Update signing to deal with NULL keystore 2018-10-13 21:42:30 -07:00
miketout
6c621e0e43 Allow NULL keystore to actually work 2018-10-13 21:03:47 -07:00
miketout
51848bbce5 Remove debug outs 2018-10-13 19:46:30 -07:00
Michael Toutonghi
09dc47493c Check unserialized tx 2018-10-13 19:04:50 -07:00
miketout
26bf01e90e Correct script serialization 2018-10-13 18:21:44 -07:00
Homu
89f5ee5dec Auto merge of #3599 - bitcartel:update_checkpoints_201, r=bitcartel
Update mainnet checkpoint for block 410100.
2018-10-13 18:19:49 -07:00
miketout
e5ea351a13 Clip subscript end for cc properly 2018-10-13 16:43:48 -07:00
miketout
9c0342676d Update handling of relayed stake transactions 2018-10-13 16:04:44 -07:00
miketout
c8700efe63 Change default note contents in Tx builder and cheat message change 2018-10-13 14:29:17 -07:00
Michael Toutonghi
60b798c4b7 Update stake cheat spend 2018-10-13 14:23:20 -07:00
Simon
85809c75ad Update mainnet checkpoint for block 410100. 2018-10-13 08:55:38 -07:00
Simon
61caa46619 For #3359. Return error if Sapling addresses passed to RPC z_mergetoaddress.
RPC z_mergetoaddress does not support Sapling yet but the existing error
reporting was not clear to users.
2018-10-13 08:10:10 -07:00
miketout
351733339e Prepare for release keys 2018-10-13 02:04:15 -07:00
miketout
ac2b240436 Add value to cheat catcher through SendChangeTo 2018-10-13 01:24:36 -07:00
miketout
3abeed2c60 Fix reference and test signature 2018-10-13 00:45:41 -07:00
Simon
de1b86a429 For #3359. RPCs transferring funds return error if Sapling addresses are used before Sapling activation. 2018-10-12 23:14:06 -07:00
miketout
56ac817fb8 Fix height or greater check 2018-10-12 22:44:52 -07:00
miketout
1ca4abe444 Cleanup cheatcatcher 2018-10-12 22:41:43 -07:00
miketout
54036e72cd Revert POS change 2018-10-12 21:51:30 -07:00
miketout
4326041663 Cheatcatcher tests to remove and change to max sequential POS 2018-10-12 21:09:45 -07:00
Michael Toutonghi
a5d8fff5e5 Auto rescan if note witnesses are off 2018-10-12 19:15:38 -07:00
miketout
47ab0926c4 Auto-rescan wallets on reorg if note witnesses get out of sync 2018-10-12 18:05:32 -07:00
miketout
83a426bc91 Adjust cheat catcher height 2018-10-12 16:53:53 -07:00
miketout
bb3d3ab770 Keep cheatcatcher's lists in sync 2018-10-12 15:43:15 -07:00
Homu
527b7feef5 Auto merge of #3592 - Eirik0:z-sendmany-better-error, r=bitcartel
Better error message when sending to both sprout and sapling

When trying to send to both Sprout and Sapling (not currently supported with z_sendmany) we were getting the following error in our operation result: `general exception: boost::bad_get: failed value get using boost::get`.

This PR changes this to fail with a better error message before the async operation begins:
```
error code: -8
error message:
Cannot send to both Sprout and Sapling addresses using z_sendmany
```
2018-10-12 15:30:34 -07:00
miketout
79b0432dc1 Fix false positive error 2018-10-12 14:56:01 -07:00
miketout
085c3640bb Improve error reporting and wallet cleanup 2018-10-12 13:54:31 -07:00
Eirik Ogilvie-Wigley
0917c84d9a Better error message when sending to both sprout and sapling
Co-authored-by mdr0id <marshall@z.cash>
2018-10-12 14:12:21 -06:00
miketout
8c3a9bc7ae Clean up POS checks 2018-10-12 01:12:08 -07:00
miketout
a8d2188651 Timeout adjustment 2018-10-11 22:47:07 -07:00
miketout
69fa3d0e00 Reduce lag timeouts 2018-10-11 22:28:37 -07:00
miketout
af2e212d7a Remove spurios opret in tx builder, don't wait forever for blocks before mining, add delay to getblocktemplate 2018-10-11 21:35:09 -07:00
Simon
cd10562c73 Resolves Sapling nullifier persistence issue when importing a key.
During a rescan, a CWalletTx was persisted to disk before it had its
note data set.  This meant that upon restart, the CWalletTx would
potentially be missing its nullifiers causing the wallet's balance
to include notes which had already been spent.

The resolution is to ensure that after a rescan, a CWalletTx is
persisted after it has had its nullifiers set correctly.

Co-authored-by: Eirik Ogilvie-Wigley <eirik@z.cash>
2018-10-11 21:25:53 -07:00
miketout
271326fafd Clean up stake rebroadcasting and mempool checking 2018-10-11 19:52:32 -07:00
miketout
ae773246f8 Error message only when cheatstaker parameter is invalid, not missing 2018-10-11 14:52:05 -07:00
miketout
8b57c15f6a Zcash latest changes 2018-10-11 14:30:42 -07:00
miketout
1021455845 Fix negative height issues for pruning cheat lists 2018-10-11 14:23:14 -07:00
miketout
16ef4f1e3d update comments 2018-10-10 22:14:05 -07:00