Homu
6f9f09dfb0
Auto merge of #2670 - arielgabizon:lowmemprover, r=daira
...
Low memory prover
This PR integrates @ebfull 's low memory changes: https://github.com/zcash/zcash/pull/2243/commits
on top of @str4d 's work bringing in libsnark as a subtree
4699d0eb36
2017-11-06 04:22:20 -08:00
Simon
c5dabd2b66
Closes #2639 . Adds optional limit parameter with a default value of 50.
...
The new parameter is to satisfy the principle of least astonishment
by providing a sensible default for the maximum number of transparent
inputs to shield. If users do not configure -mempooltxinputlimit
it is possible for them to create transactions with hundreds of
inputs which suffer from mining delay, due to the current state of
the network where some miners have configured -mempooltxinputlimit
as a way to deal with the problem of quadratic hashing.
2017-11-01 10:40:24 -07:00
Simon
c2d3bafeaa
Closes #2639 . z_shieldcoinbase is now supported, no longer experimental.
...
This reverts commit 5023af7bd5 .
2017-10-26 11:29:36 -07:00
Sean Bowe
1a9543d064
Remove crusty old "loadVerifyingKey"/"loadProvingKey" APIs and associated invariants.
2017-10-21 15:42:41 +03:00
Homu
af549fe6ed
Auto merge of #2650 - str4d:2645-listunspent-benchmark, r=str4d
...
Add benchmark for listunspent
Closes #2645 .
2017-10-12 15:24:53 -07:00
Jay Graber
c16528495c
s/zcash/Zcash
2017-10-04 17:06:51 -07:00
Bruno Arueira
d2c1e4a807
Removes out bitcoin mention in favor for zcash
...
Bitcoin Core => Zcash
bitcoin address => Zcash address
bitcoinaddress => zcashaddress
Closes #1756
2017-10-04 17:05:30 -07:00
Jack Grigg
99dd50c30c
Add benchmark for listunspent
...
Closes #2645 .
2017-10-04 12:48:50 +01:00
Simon
5023af7bd5
Closes #2637 . Make z_shieldcoinbase an experimental feature where it
...
can be enabled with: zcashd -experimentalfeatures -zshieldcoinbase.
2017-09-27 10:43:54 -07:00
Homu
f34c60de37
Auto merge of #2615 - bitcartel:2448_shield_coinbase, r=bitcartel
...
Add RPC command shield_coinbase #2448 .
Shield transparent coinbase funds by sending to a shielded z address. Closes #2448 .
2017-09-22 12:04:31 -07:00
Simon
06c19063bb
Implement RPC shield_coinbase #2448 .
2017-09-21 15:04:12 -07:00
Homu
6e9964ff70
Auto merge of #2613 - arielgabizon:load-wallet-benchmark, r=str4d
...
Add load-wallet benchmark
Closes #2518 .
2017-09-19 01:52:22 -07:00
Ariel Gabizon
2e8aefdce1
add load-wallet benchmark
2017-09-18 21:54:53 +02:00
Homu
e0bef1de56
Auto merge of #2564 - str4d:2074-currency-units, r=str4d
...
Rationalize currency unit to "ZEC"
Cherry-picked from the upstream PR bitcoin/bitcoin#6504
Part of #2074
2017-09-18 00:07:52 -07:00
Jack Grigg
a76174b76b
Benchmark time to call sendtoaddress with many UTXOs
2017-08-31 02:15:06 +01:00
Jack Grigg
6dec2d0355
Rationalize currency unit to "ZEC"
2017-08-03 18:49:04 +01:00
Ross Nicoll
091b2116a0
Rationalize currency unit to "BTC"
...
Previously various user-facing strings have used inconsistent currency units "BTC",
"btc" and "bitcoins". This adds a single constant and uses it for each reference to
the currency unit.
Also adds a description of the unit for --maxtxfee, and adds the missing "amount"
field description to the (deprecated) move RPC command.
2017-08-03 16:32:41 +01:00
Simon
d77a0ac4a0
Closes #2446 by adding generated field to listunspent.
...
If generated is true, the unspent transaction output is from a
coinbase transaction and can only be sent to a shielded address.
2017-07-11 10:44:36 -07:00
Jack Grigg
c66c731adf
Add a benchmark for calling ConnectBlock on a block with many inputs
...
Requires placing block-107134.tar.gz (containing the block, and a fake CoinsDB
containing its inputs) into the base directory of the repository. This can be
generated using qa/zcash/create_benchmark_archive.py (see the script for usage
details).
To facilitate generation of the fake CoinsDB, an additional field 'valueZat' has
been added to 'getrawtransaction' containing the integer number of zatoshis
instead of a decimal number of ZEC.
Closes #2355 .
2017-05-18 11:03:46 +12:00
Jay Graber
704547965a
Change help text examples to use Zcash addresses
2017-03-24 14:52:28 -07:00
Jack Grigg
3c014397a9
BTC -> ZEC in paytxfee RPC docs
...
Revert before merging bitcoin/bitcoin#6504 .
2017-03-02 13:26:34 -08:00
Matt Corallo
3d8013a01b
Add fundrawtransaction RPC method
2017-03-02 13:23:03 -08:00
Stephen
6699b42518
Add paytxfee to getwalletinfo, warnings to getnetworkinfo
2017-03-02 13:23:03 -08:00
Simon
2f21206cfc
Closes #2112 where z_getoperationresult could return stale status.
2017-02-22 16:14:56 -08:00
Jack Grigg
f54db399f2
Get rid of fPlus argument to FormatMoney in Zcash-specific code
2017-02-10 02:19:14 +00:00
Jack Grigg
c24109ecc3
UniValue::getValues const reference
2017-02-10 02:19:12 +00:00
Wladimir J. van der Laan
e76a3849c6
Changes necessary now that zero values accepted in AmountFromValue
...
- Add an accept test for zero amounts, and a reject test for negative
amounts
- Remove ugly hack in `settxfee` that is no longer necessary
- Do explicit zero checks in wallet RPC functions
- Don't add a check for zero amounts in `createrawtransaction` - this
could be seen as a feature
2017-02-10 02:18:57 +00:00
Jonas Schnelli
a10a6e2a0e
[Univalue] add univalue over subtree
...
similar to secp256k1 include and compile univalue over a subtree
2017-02-10 02:18:51 +00:00
Jack Grigg
cc71666a51
unsigned int -> size_t for comparing with UniValue.size()
2017-02-10 00:53:13 +00:00
Jack Grigg
0d37ae3a59
Migrate Zcash-specific code to UniValue
2017-02-10 00:52:57 +00:00
Jonas Schnelli
d014114d67
Remove JSON Spirit wrapper, remove JSON Spirit leftovers
...
- implement find_value() function for UniValue
- replace all Array/Value/Object types with UniValues, remove JSON Spirit to UniValue wrapper
- remove JSON Spirit sources
2017-02-10 00:35:24 +00:00
Jonas Schnelli
851f58f94e
remove JSON Spirit UniValue wrapper
2017-02-10 00:35:24 +00:00
Jonas Schnelli
38fc4b7090
expicit set UniValue type to avoid empty values
2017-02-10 00:35:24 +00:00
Jonas Schnelli
9756b7bd29
extend conversion to UniValue
2017-02-10 00:35:24 +00:00
Jeff Garzik
ed21d5bd4b
Convert tree to using univalue. Eliminate all json_spirit uses.
2017-02-10 00:35:24 +00:00
Jack Grigg
b8eb37757b
Require -experimentalmode for wallet encryption
2017-02-09 22:10:58 +00:00
zkbot
b2e2dccc64
Auto merge of #2068 - bitcartel:2045_sendmany_fee_zero, r=bitcartel
...
Closes #2045 by allowing z_sendmany with 0 fee
2017-02-09 18:56:44 +00:00
Simon
7eccce4e44
Closes #2045 by allowing z_sendmany with 0 fee
2017-02-06 14:14:28 -08:00
Jack Grigg
2cc0a252ad
Add compile flag to disable compilation of mining code
2017-01-30 21:14:46 +01:00
zkbot
4458f87138
Auto merge of #2028 - bitcartel:std_numeric_gcc_620_compile_issue, r=ebfull
...
Add missing header
Closes #2027 where gcc 6.2.0 identified that `rpcwallet.cpp` was missing a header file `<numeric>` which is required due to usage of `std::accumulate`.
2017-01-18 19:45:02 +00:00
Simon
bcbde86a87
Add missing header required by std::accumulate
2017-01-18 10:52:37 -08:00
zkbot
63e0e895a5
Auto merge of #2006 - bitcartel:1497_destination_path_validation_when_exporting, r=bitcartel
...
Fixes #1497 ZCA-009 by restricting export to a user defined folder and sanitizing filenames
2017-01-18 18:19:50 +00:00
zkbot
4d52160de3
Auto merge of #2001 - bitcartel:1957_add_size_to_listtransactions, r=ebfull
...
Closes #1957 by adding tx serialization size to listtransactions output.
2017-01-18 07:15:35 +00:00
zkbot
1e8778a274
Auto merge of #1976 - bitcartel:1964_z_sendmany_exception_handling, r=ebfull
...
Fixes #1964 to catch general exception in z_sendmany and catch exceptions as reference-to-const.
2017-01-18 03:48:12 +00:00
zkbot
ee2f1ebb9d
Auto merge of #1942 - str4d:1940-threaded-createjoinsplit, r=ebfull
...
Extend createjoinsplit to benchmark parallel JoinSplits
Closes #1940
2017-01-18 01:04:05 +00:00
zkbot
4169cddd64
Auto merge of #1991 - bitcartel:1960_z_getoperation_include_call_details, r=ebfull
...
Fixes #1960 : z_getoperationstatus/result now includes operation details.
2017-01-17 19:24:07 +00:00
Simon
8aa7937d44
Fixes #1960 : z_getoperationstatus/result now includes operation details.
2017-01-16 16:45:27 -08:00
Simon
f32cade8fd
Closes #1957 by adding tx serialization size to listtransactions output.
2017-01-16 11:07:16 -08:00
Simon
9064d73bf8
Fixes #1497 ZCA-009 by restricting data exporting to user defined folder.
...
Previously the RPC interface allowed z_exportwallet, backupwallet and
dumpwallet to write data to an arbitrary filename. ZCA-009 demonstrates
how this is vulnerable. The resolution is to only allow data to
written when the -exportdir has been configured. Also filenames are
restricted to alphanumeric characters.
2017-01-16 10:56:06 -08:00
Simon
2d2f3d1806
Closes #1780 . Result of z_getoperationstatus now sorted by creation time of operation
2017-01-11 11:49:10 -08:00