320 Commits

Author	SHA1	Message	Date
Philip Kaufmann	db954a65ac	use const references where appropriate	2017-03-03 10:57:05 -08:00
zkbot	312fbd9d0e	Auto merge of #1932 - aniemerg:1522-pause-mining-for-joinsplit, r=arcalinea ... Pause mining during JoinSplit creation Closes #1522 .	2017-03-02 01:23:44 +00:00
Allan Niemerg	49c2cecb9f	Pause mining during joinsplit creation	2017-03-01 16:54:26 -08:00
Simon	2f21206cfc	Closes #2112 where z_getoperationresult could return stale status.	2017-02-22 16:14:56 -08:00
Jack Grigg	f54db399f2	Get rid of fPlus argument to FormatMoney in Zcash-specific code	2017-02-10 02:19:14 +00:00
Jack Grigg	c24109ecc3	UniValue::getValues const reference	2017-02-10 02:19:12 +00:00
Jack Grigg	2cc6bab201	Update UniValue includes in Zcash-specific code	2017-02-10 02:19:06 +00:00
Wladimir J. van der Laan	e76a3849c6	Changes necessary now that zero values accepted in AmountFromValue ... - Add an accept test for zero amounts, and a reject test for negative amounts - Remove ugly hack in `settxfee` that is no longer necessary - Do explicit zero checks in wallet RPC functions - Don't add a check for zero amounts in `createrawtransaction` - this could be seen as a feature	2017-02-10 02:18:57 +00:00
Jonas Schnelli	a10a6e2a0e	[Univalue] add univalue over subtree ... similar to secp256k1 include and compile univalue over a subtree	2017-02-10 02:18:51 +00:00
Jack Grigg	cc71666a51	unsigned int -> size_t for comparing with UniValue.size()	2017-02-10 00:53:13 +00:00
Jack Grigg	0d37ae3a59	Migrate Zcash-specific code to UniValue	2017-02-10 00:52:57 +00:00
Jonas Schnelli	d014114d67	Remove JSON Spirit wrapper, remove JSON Spirit leftovers ... - implement find_value() function for UniValue - replace all Array/Value/Object types with UniValues, remove JSON Spirit to UniValue wrapper - remove JSON Spirit sources	2017-02-10 00:35:24 +00:00
Jonas Schnelli	851f58f94e	remove JSON Spirit UniValue wrapper	2017-02-10 00:35:24 +00:00
Jonas Schnelli	38fc4b7090	expicit set UniValue type to avoid empty values	2017-02-10 00:35:24 +00:00
Jonas Schnelli	9756b7bd29	extend conversion to UniValue	2017-02-10 00:35:24 +00:00
Jeff Garzik	ed21d5bd4b	Convert tree to using univalue. Eliminate all json_spirit uses.	2017-02-10 00:35:24 +00:00
Jack Grigg	b8eb37757b	Require -experimentalmode for wallet encryption	2017-02-09 22:10:58 +00:00
zkbot	0c78782662	Auto merge of #1965 - str4d:1955-single-address-mining, r=bitcartel ... Switch miner to P2PKH, add -mineraddress option Closes #945 and #1955.	2017-02-09 20:58:00 +00:00
zkbot	b2e2dccc64	Auto merge of #2068 - bitcartel:2045_sendmany_fee_zero, r=bitcartel ... Closes #2045 by allowing z_sendmany with 0 fee	2017-02-09 18:56:44 +00:00
zkbot	80a32b2845	Auto merge of #1863 - str4d:1795-config-flag-disable-miner, r=bitcartel ... Add compile flag to disable compilation of mining code Closes #1795	2017-02-09 17:43:43 +00:00
zkbot	138f19b0ba	Auto merge of #2072 - bitcartel:2060_debug_zrpc_zrpcunsafe, r=bitcartel ... Closes #2060 by updating zrpc and zrpcunsafe logging	2017-02-08 18:54:47 +00:00
Simon	43b6753782	Update zrpc vs zrpcunsafe logging in z_sendmany operation	2017-02-08 10:50:40 -08:00
zkbot	dff700c1af	Auto merge of #2055 - str4d:1545-note-decryption-error-class, r=daira ... Use a more specific exception class for note decryption failure Closes #1545.	2017-02-08 03:12:37 +00:00
Simon	7eccce4e44	Closes #2045 by allowing z_sendmany with 0 fee	2017-02-06 14:14:28 -08:00
Jack Grigg	8e8b6d701b	Switch miner to P2PKH, add -mineraddress option ... Closes #945 and #1955.	2017-02-06 11:54:58 +00:00
zkbot	499e34fc64	Auto merge of #1706 - paragonie:master, r=bitcartel ... Use libsodium's CSPRNG instead of OpenSSL's Closes #1632.	2017-02-05 18:26:11 +00:00
Simon	ee84f279a9	Update z_sendmany logging	2017-02-01 09:27:44 -08:00
Simon	3110b793f0	Closes #2057 by adding extra zrpcunsafe logging	2017-01-31 22:00:46 -08:00
Jack Grigg	51fde9ea08	Use a more specific exception class for note decryption failure ... Closes #1545.	2017-01-31 23:05:19 +01:00
Jack Grigg	2cc0a252ad	Add compile flag to disable compilation of mining code	2017-01-30 21:14:46 +01:00
Jack Grigg	207924a1d5	Remove OpenSSL PRNG reseeding ... Per https://download.libsodium.org/doc/generating_random_data/ reseeding the default libsodium PRNG is not required.	2017-01-23 17:06:54 +01:00
zkbot	0edb3c0f16	Auto merge of #1978 - str4d:1941-scan-whole-chain-on-zkey-import, r=ebfull ... Scan the whole chain whenever a z-key is imported Closes #1941.	2017-01-20 00:02:12 +00:00
zkbot	4458f87138	Auto merge of #2028 - bitcartel:std_numeric_gcc_620_compile_issue, r=ebfull ... Add missing header Closes #2027 where gcc 6.2.0 identified that `rpcwallet.cpp` was missing a header file `<numeric>` which is required due to usage of `std::accumulate`.	2017-01-18 19:45:02 +00:00
Simon	bcbde86a87	Add missing header required by std::accumulate	2017-01-18 10:52:37 -08:00
zkbot	63e0e895a5	Auto merge of #2006 - bitcartel:1497_destination_path_validation_when_exporting, r=bitcartel ... Fixes #1497 ZCA-009 by restricting export to a user defined folder and sanitizing filenames	2017-01-18 18:19:50 +00:00
zkbot	4d52160de3	Auto merge of #2001 - bitcartel:1957_add_size_to_listtransactions, r=ebfull ... Closes #1957 by adding tx serialization size to listtransactions output.	2017-01-18 07:15:35 +00:00
zkbot	f37f0805cc	Auto merge of #1980 - bitcartel:fix_z_sendmany_logging_bug_txid, r=ebfull ... Fix bug where z_sendmany logged incorrect txid fragment when sending from taddr Closes #1987.	2017-01-18 05:10:18 +00:00
zkbot	c583e42e6b	Auto merge of #1977 - bitcartel:1967_z_sendmany_debug_age_of_notes, r=ebfull ... Fixes #1967 by adding age of note to z_sendmany logging.	2017-01-18 04:29:06 +00:00
zkbot	1e8778a274	Auto merge of #1976 - bitcartel:1964_z_sendmany_exception_handling, r=ebfull ... Fixes #1964 to catch general exception in z_sendmany and catch exceptions as reference-to-const.	2017-01-18 03:48:12 +00:00
zkbot	ee2f1ebb9d	Auto merge of #1942 - str4d:1940-threaded-createjoinsplit, r=ebfull ... Extend createjoinsplit to benchmark parallel JoinSplits Closes #1940	2017-01-18 01:04:05 +00:00
zkbot	4169cddd64	Auto merge of #1991 - bitcartel:1960_z_getoperation_include_call_details, r=ebfull ... Fixes #1960: z_getoperationstatus/result now includes operation details.	2017-01-17 19:24:07 +00:00
zkbot	9cd91833a5	Auto merge of #2015 - bitcartel:1780_sort_getoperationstatus, r=ebfull ... Closes #1780. Result of z_getoperationstatus now sorted by operation's creation time.	2017-01-17 04:06:28 +00:00
Simon	8aa7937d44	Fixes #1960: z_getoperationstatus/result now includes operation details.	2017-01-16 16:45:27 -08:00
Simon	f32cade8fd	Closes #1957 by adding tx serialization size to listtransactions output.	2017-01-16 11:07:16 -08:00
Simon	9064d73bf8	Fixes #1497 ZCA-009 by restricting data exporting to user defined folder. ... Previously the RPC interface allowed z_exportwallet, backupwallet and dumpwallet to write data to an arbitrary filename. ZCA-009 demonstrates how this is vulnerable. The resolution is to only allow data to written when the -exportdir has been configured. Also filenames are restricted to alphanumeric characters.	2017-01-16 10:56:06 -08:00
Simon	2d2f3d1806	Closes #1780. Result of z_getoperationstatus now sorted by creation time of operation	2017-01-11 11:49:10 -08:00
Simon	4c1cd287be	Fixes a bug where the unsigned transaction was logged by z_sendmany ... after a successful sign and send, meaning that the logged hash fragment would be different from the txid logged by "AddToWallet". This issue occured when sending from transparent addresses, as utxo inputs must be signed. It did not occur when sending from shielded addresses.	2017-01-04 12:26:23 -08:00
Jack Grigg	7e3a20f235	Scan the whole chain whenever a z-key is imported ... Closes #1941.	2017-01-04 15:40:35 +01:00
Simon	01f6c5dbee	Fixes #1967 by adding age of note to z_sendmany logging.	2017-01-03 23:57:11 -08:00
Simon	fce7260811	Fixes #1964 to catch general exception in z_sendmany and catch ... exceptions as reference-to-const.	2017-01-03 12:50:19 -08:00