Commit Graph

10832 Commits

Author SHA1 Message Date
Homu
10acd8a1fb Auto merge of #2484 - str4d:block-download-completion, r=daira
Add block download progress to metrics UI
2017-07-28 21:57:19 -07:00
Jack Grigg
92bfde0edf Improve network height estimation 2017-07-28 10:50:07 +00:00
Jack Grigg
4a651837be Correct and extend EstimateNetHeightInner tests
Corrections are to the median block times, which were generated by subtracting
CBlockIndex::nMedianTimeSpan / 2 from the block height and then multiplying by
the target spacing. GetMedianTimePast() takes an array sorted by std::sort() and
returns element CBlockIndex::nMedianTimeSpan / 2, meaning that if
CBlockIndex::nMedianTimeSpan is odd (which it is), there is an out-by-one error
in the subtraction.
2017-07-28 10:45:44 +00:00
Homu
d6e6f51724 Auto merge of #2526 - bitcartel:2480_segfault_zeroconf_from_zaddr, r=daira
Fixes #2480 where missing map entry would cause a segfault.

`wtxHeight = mapBlockIndex[wtx.hashBlock]->nHeight;` results in undefined behaviour when the block hash is not present in the map, returning a null value which is dereferenced via `->nHeight`.  This error is triggered by a zero-conf wallet transaction which has not been mined yet.  As discussed in #2480, on some systems there is a segfault whilst on others there is a silent exit.  This makes it difficult to write a test, but the fix has been tested empirically to confirm an exception is thrown.  This PR fixes the segfault and complements #2525 which prevents a user from sending from a zaddr with minconf 0.
2017-07-27 22:42:59 -07:00
Jack Grigg
047aec1e0e Add block download progress to metrics UI 2017-07-26 00:51:12 +00:00
Homu
e88ab1a920 Auto merge of #2529 - str4d:2444-rpc-www-authenticate, r=daira
[rpc] Add WWW-Authenticate header to 401 response

Fix cherry-picked from upstream PR bitcoin/bitcoin#7472.

Closes #2444.
2017-07-25 15:36:33 -07:00
Homu
eeac474228 Auto merge of #2543 - nathan-at-least:2499-specify-ci-worker-criteria, r=daira
Document our criteria for adding CI workers.

This is a doc improvement that came out of #2499.
2017-07-25 14:16:22 -07:00
Daira Hopwood
75401530d7 Document our criteria for adding CI workers. closes #2499
Author: Nathan Wilcox <nathan@z.cash>
Author: Daira Hopwood <daira@jacaranda.org>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2017-07-25 21:27:16 +01:00
Homu
a698116b28 Auto merge of #2478 - bitcartel:2477_send_alert_1.0.10, r=daira
Alert for 2017-06-23.a degraded networking (fixed in 1.0.10-1)

Alert 1004 (version 1.0.10 only) Issue #2477
2017-07-25 13:03:53 -07:00
Homu
95d18784ec Auto merge of #2525 - bitcartel:2519_no_zero_minconf_from_zaddr_zsendmany, r=daira
When sending from a zaddr, minconf cannot be zero.

Closes #2519.
2017-07-20 08:24:54 -07:00
Bjorn Hjortsberg
ecd04e914f Remove deprecated exception specification
Warns on a newer compiler that these are deprecated in C++11
2017-07-20 13:58:39 +02:00
Bjorn Hjortsberg
4272a1e2b1 Do not warn on built in declaration mismatch 2017-07-20 13:27:37 +02:00
Homu
d2627bc65d Auto merge of #2504 - daira:2501.remove-upnp, r=daira
Remove UPnP support. fixes #2500

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2017-07-16 03:43:54 -07:00
Homu
d3a976095f Auto merge of #2509 - str4d:ci-workers, r=str4d
Ansible playbook for configuring CI workers

The playbook in this PR can be used for configuring common Unix variants to run a Buildbot worker for the Zcash CI, starting from a fresh install (or a VM template provided by a hosting service).
2017-07-14 19:10:21 -07:00
Homu
1738e6957f Auto merge of #2458 - daira:2450.pyflakes-cleanup, r=str4d
pyflakes cleanup

Make the RPC tests pyflakes-clean. fixes #2450

Includes a fix that upstream had in https://github.com/bitcoin/bitcoin/pull/7802
2017-07-14 18:03:03 -07:00
Jack Grigg
e0c696a1e7 Add pyflakes to required Python modules
See #2494 for details.
2017-07-14 12:35:10 -05:00
Jack Grigg
e5f8e6185a Add a separate Buildbot host info template for EC2
Latent workers are not usually created on the instance type that will be used,
so memory and CPU info collected at AMI creation will likely be inaccurate.
2017-07-14 12:35:09 -05:00
Jack Grigg
8247fd954c Remove Buildbot version from host file
Buildbot master already obtains and publishes this in the UI.
2017-07-14 12:34:40 -05:00
Jack Grigg
3ba809b6d7 Add pyblake2 to required Python modules
See #2533 for details.
2017-07-14 12:34:40 -05:00
Jack Grigg
64363d1351 Add steps for setting up a latent worker on Amazon EC2 2017-07-14 12:34:37 -05:00
Jack Grigg
6ff5a13497 Add Buildbot worker setup to Ansible playbook
Currently assumes the host uses systemd
2017-07-14 12:33:55 -05:00
Homu
098e8139c5 Auto merge of #2535 - daira:zcash-is-experimental-wording, r=daira
Change wording in Security Warnings section of README.md.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2017-07-14 08:52:25 -07:00
Simon
9b5da42745 Fixes #2480. Null entry in map was dereferenced leading to a segfault. 2017-07-14 00:10:54 -07:00
Daira Hopwood
52ca5aac5b Change wording in Security Warnings section of README.md.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2017-07-14 05:18:08 +01:00
Homu
2c0fd9e5e4 Auto merge of #2522 - bitcartel:2446_coinbase_field_listunspent, r=daira
Add generated field to listunspent output

Closes #2446
2017-07-12 23:46:25 -07:00
Wladimir J. van der Laan
20fb708e6f rpc: Add WWW-Authenticate header to 401 response
A WWW-Authenticate header must be present in the 401
response to make clients know that they can authenticate,
and how.

    WWW-Authenticate: Basic realm="jsonrpc"

Fixes #7462.
2017-07-12 16:37:48 -05:00
Jack Grigg
689264bbff Add test for issue #2444
A WWW-Authenticate header must be present in the 401 response to make clients
know that they can authenticate, and how.
2017-07-12 16:34:58 -05:00
Simon
b639bb1eef Fixes #2519. When sending from a zaddr, minconf cannot be zero. 2017-07-11 11:29:43 -07:00
Simon
d77a0ac4a0 Closes #2446 by adding generated field to listunspent.
If generated is true, the unspent transaction output is from a
coinbase transaction and can only be sent to a shielded address.
2017-07-11 10:44:36 -07:00
Homu
5df11e9d8e Auto merge of #2460 - str4d:process-temp-release-notes, r=daira
Pull in temporary release notes during the release process

This PR assumes we always have at least one notable change in `doc/release-notes.md`, which should be the case for every release.
2017-07-10 11:44:00 -07:00
Homu
90a255a747 Auto merge of #2464 - str4d:torcontrol-rbf-resource-leak, r=daira
Net: Fix resource leak in ReadBinaryFile(...)

Introduced in 3290567bbd via PR #2177.

Cherry-picked from Bitcoin PR https://github.com/bitcoin/bitcoin/pull/10408
2017-07-10 10:43:22 -07:00
Jack Grigg
046c3d4f24 Simplify Python installation, inform user if they need to manually configure 2017-07-10 10:30:23 -05:00
Jack Grigg
c73014a2e3 Variable overrides for FreeBSD
These are insufficient to enable FreeBSD to build.
2017-07-04 17:47:34 -07:00
Jack Grigg
6f4a1721f2 Variable overrides for Debian, Ubuntu and Fedora 2017-07-04 17:47:11 -07:00
Jack Grigg
6db418c982 Ansible playbook for installing Zcash dependencies and Buildbot worker 2017-07-04 17:46:17 -07:00
Daira Hopwood
506a21850a Remove UPnP support. fixes #2500
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2017-07-03 08:57:05 +01:00
Jack Grigg
caafbbb483 Pull in temporary release notes during the release process 2017-06-29 15:42:40 -07:00
Daira Hopwood
262fc5f4e3 Alert 1004 (version 1.0.10 only)
Author: Simon <simon@bitcartel.com>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2017-06-24 19:49:41 +01:00
Homu
d6ec3954c6 Auto merge of #2474 - bitcartel:release-v1.0.10-1, r=bitcartel
Release v1.0.10-1
2017-06-23 20:13:47 -07:00
Simon
2762b68576 make-release.py: Updated release notes and changelog for 1.0.10-1. 2017-06-23 19:50:41 -07:00
Simon
a0a3eb70b9 make-release.py: Updated manpages for 1.0.10-1. 2017-06-23 19:50:40 -07:00
Simon
d444e1cf40 make-release.py: Versioning changes for 1.0.10-1. 2017-06-23 19:43:29 -07:00
Homu
ad5e8a544b Auto merge of #2462 - str4d:2404-gitian-no-proton, r=ebfull
Disable building Proton in Gitian

This is the patch used to build 1.0.9 and 1.0.10.

Part of #2404.
2017-06-23 18:34:31 -07:00
Homu
1605da740e Auto merge of #2473 - ebfull:init-proto-hotfix-release, r=ebfull
Revert changes to INIT_PROTO_VERSION

This reverts https://github.com/zcash/zcash/pull/2245 in order to fix degraded networking behavior for 1.0.10 clients.
2017-06-23 17:26:34 -07:00
Sean Bowe
15a9937654 Revert "Delete old protocol version constants and simplify code that used them."
This reverts commit 5a49c929dd.
2017-06-23 18:19:25 -06:00
Sean Bowe
9ad9a25eff Revert "Remove an unneeded version workaround as per @str4d's review comment."
This reverts commit 1e9db0b38a.
2017-06-23 18:19:17 -06:00
practicalswift
1240717431 Net: Fix resource leak in ReadBinaryFile(...)
Introduced in 3290567bbd via PR #2177.
2017-06-23 18:49:43 +12:00
Daira Hopwood
ff0f305497 Cosmetics (trailing whitespace, comment conventions, etc.)
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2017-06-22 18:09:05 +01:00
Daira Hopwood
811b36ba80 For unused variables reported by pyflakes, either remove the variable,
suppress the warning, or fix a bug (if the wrong variable was used).
refs #2450

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2017-06-22 18:09:05 +01:00
Daira Hopwood
aff0bf7fa1 Clean up imports to be pyflakes-checkable. fixes #2450
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2017-06-22 18:09:04 +01:00