DragonX/hush3
1
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity
10,283 Commits 2 Branches 1 Tag
d101d7b8e68d7949b1dbc6286074e1fb0dee82de
Commit Graph

7016 Commits

Author SHA1 Message Date
zathras-crypto
a11c4bbd26 Exempt unspendable transaction outputs from dust checks 
Since unspendable outputs can't be spent, there is no threshold at which it would be uneconomic to spend them.

This primarily targets transaction outputs with `OP_RETURN`.

---

Initially based on:

commit 9cf0ae26350033d43d5dd3c95054c0d1b1641eda
Author: zathras-crypto <zathrasc@gmail.com>
Date:   Wed Mar 25 02:04:02 2015 -0700

Changes:

- cherry-picked on top of bitcoin:master
- added RPC test for fundrawtransaction
 2017-03-02 13:26:34 -08:00
Wladimir J. van der Laan
ce83df8fc4 rpc: Remove chain-specific RequireRPCPassword 
I've never liked the chain-specific exception to having to set a
password. It gives issues with #6388 which makes it valid to
set no password in every case (as it enables random cookie authentication).

This pull removes the flag, so that all chains are regarded the same.

It also removes the username==password test, which doesn't provide any
substantial extra security.
 2017-03-02 13:23:03 -08:00
Jonas Schnelli
81eb80d841 [REST] add JSON support for /rest/headers/ 2017-03-02 13:23:03 -08:00
Forrest Voight
483672f772 When processing RPC commands during warmup phase, parse the 
request object before returning an error so that id value can
be used in the response.

Prior to this commit, RPC commands sent during Bitcoin's
warmup/startup phase were responded to with a JSON-RPC error
with an id of null, which violated the JSON-RPC 2.0 spec:

id: This member is REQUIRED. It MUST be the same as the value
of the id member in the Request Object. If there was an error
in detecting the id in the Request object (e.g. Parse
error/Invalid Request), it MUST be Null.
 2017-03-02 13:23:03 -08:00
Jack Grigg
0352b37bff Adjust blockheaderToJSON() for Zcash block header 2017-03-02 13:23:03 -08:00
Peter Todd
d3d5483eef Add getblockheader RPC call 
Alternative to getblock that works even when the block itself has been
pruned, returning all available information.
 2017-03-02 13:23:03 -08:00
Jonas Schnelli
5548701eeb UniValue: don't escape solidus, keep espacing of reverse solidus 
Zcash: The UniValue changes are already merged; this updates the test
 2017-03-02 13:23:03 -08:00
Matt Corallo
3d8013a01b Add fundrawtransaction RPC method 2017-03-02 13:23:03 -08:00
Matt Corallo
aa30f65502 Add FundTransaction method to wallet 
Some code stolen from Jonas Schnelli <jonas.schnelli@include7.ch>
 2017-03-02 13:23:03 -08:00
Matt Corallo
b6616548ce Small tweaks to CCoinControl for fundrawtransaction 2017-03-02 13:23:03 -08:00
Pieter Wuille
18e804a925 Add DummySignatureCreator which just creates zeroed sigs 2017-03-02 13:23:03 -08:00
dexX7
9c7167d1bc Return all available information via validateaddress 
`"validateaddress"` omits some information, even in cases where is it available.

The primary motivation is to be able to retrieve redeemScripts, after using `"addmultisigaddress"`, when not all keys are available in the keystore, but the redeemScript actually is.

The output of `"validateaddress"` with this commit:

Keys not available:
```js
validateaddress "n4KWZKx349gdMQGgTnZ8W6WfgSwybkGSK3"
{
  "isvalid": true,
  "address": "n4KWZKx349gdMQGgTnZ8W6WfgSwybkGSK3",
  "scriptPubKey": "76a914fa20d564550b105787f7ce3a9ad7fd9a45cd407088ac",
  "ismine": false,
  "iswatchonly": false,
  "isscript": false
}
```
```js
validateaddress "2N2g2H7gjA8a11g1yKBgh5VTqndyvbnWpBK"
{
  "isvalid": true,
  "address": "2N2g2H7gjA8a11g1yKBgh5VTqndyvbnWpBK",
  "scriptPubKey": "a9146769c19a16c9400b908756e19a4d2afb9e9760e187",
  "ismine": false,
  "iswatchonly": false,
  "isscript": true
}
```

After adding the redeemScript:
```js
addmultisigaddress 2 '["02537357B156A33306A7A014A3748631C59DF405B56F11BA4AA4A3CE81501AF095","02F1FB200390E7864EF4450C07B15988179A57C3CF3A878F668E1070CB615749FE"]'
2N2g2H7gjA8a11g1yKBgh5VTqndyvbnWpBK

validateaddress "2N2g2H7gjA8a11g1yKBgh5VTqndyvbnWpBK"
{
  "isvalid": true,
  "address": "2N2g2H7gjA8a11g1yKBgh5VTqndyvbnWpBK",
  "scriptPubKey": "a9146769c19a16c9400b908756e19a4d2afb9e9760e187",
  "ismine": false,
  "iswatchonly": false,
  "isscript": true,
  "script": "multisig",
  "hex": "522102537357b156a33306a7a014a3748631c59df405b56f11ba4aa4a3ce81501af0952102f1fb200390e7864ef4450c07b15988179a57c3cf3a878f668e1070cb615749fe52ae",
  "addresses": [
    "n4KWZKx349gdMQGgTnZ8W6WfgSwybkGSK3",
    "mmSKNtbYYHRrhTLKiok5TuYrGEs4Y2A4k6"
  ],
  "sigsrequired": 2,
  "account": ""
}
```

All keys available:
```js
validateaddress "n4KWZKx349gdMQGgTnZ8W6WfgSwybkGSK3"
{
  "isvalid": true,
  "address": "n4KWZKx349gdMQGgTnZ8W6WfgSwybkGSK3",
  "scriptPubKey": "76a914fa20d564550b105787f7ce3a9ad7fd9a45cd407088ac",
  "ismine": true,
  "iswatchonly": false,
  "isscript": false,
  "pubkey": "02537357b156a33306a7a014a3748631c59df405b56f11ba4aa4a3ce81501af095",
  "iscompressed": true,
  "account": ""
}
```
```js
validateaddress "2N2g2H7gjA8a11g1yKBgh5VTqndyvbnWpBK"
{
  "isvalid": true,
  "address": "2N2g2H7gjA8a11g1yKBgh5VTqndyvbnWpBK",
  "scriptPubKey": "a9146769c19a16c9400b908756e19a4d2afb9e9760e187",
  "ismine": true,
  "iswatchonly": false,
  "isscript": true,
  "script": "multisig",
  "hex": "522102537357b156a33306a7a014a3748631c59df405b56f11ba4aa4a3ce81501af0952102f1fb200390e7864ef4450c07b15988179a57c3cf3a878f668e1070cb615749fe52ae",
  "addresses": [
    "n4KWZKx349gdMQGgTnZ8W6WfgSwybkGSK3",
    "mmSKNtbYYHRrhTLKiok5TuYrGEs4Y2A4k6"
  ],
  "sigsrequired": 2,
  "account": ""
}
```
 2017-03-02 13:23:03 -08:00
Wladimir J. van der Laan
a0455eca11 rpc: make gettxoutsettinfo run lock-free 
For leveldb "An iterator operates on a snapshot of the database taken
when the iterator is created". This means that it is unnecessary to
lock out other threads while computing statistics, and neither to hold
cs_main for the whole time. Let the thread run free.
 2017-03-02 13:23:03 -08:00
Jonas Schnelli
cbf3ab51f9 fix lock issue for QT node diconnect and RPC disconnectnode 
Zcash: only RPC disconnectnode
 2017-03-02 13:23:03 -08:00
Jonas Schnelli
fa80be8ff5 setban: add IPv6 tests 2017-03-02 13:23:03 -08:00
Jonas Schnelli
0382246bb1 fix missing lock in CNode::ClearBanned() 2017-03-02 13:23:03 -08:00
Jonas Schnelli
1cad8c9ff9 setban: add RPCErrorCode 2017-03-02 13:23:03 -08:00
Jonas Schnelli
171b4de8d9 fix CSubNet comparison operator 2017-03-02 13:23:03 -08:00
Jonas Schnelli
fcc8920f36 setban: rewrite to UniValue, allow absolute bantime 2017-03-02 13:23:03 -08:00
Jonas Schnelli
63c06b232b rename json field "bannedtill" to "banned_until" 2017-03-02 13:23:03 -08:00
Jonas Schnelli
e521939942 [RPC] extend setban to allow subnets 2017-03-02 13:23:03 -08:00
Jonas Schnelli
445cd761c5 [net] remove unused return type bool from CNode::Ban() 2017-03-02 13:23:03 -08:00
Jonas Schnelli
962ec4b5e4 [QA] add setban/listbanned/clearbanned tests 2017-03-02 13:23:03 -08:00
Jonas Schnelli
ed3f13a057 [RPC] add setban/listbanned/clearbanned RPC commands 2017-03-02 13:23:03 -08:00
Jonas Schnelli
997829713c [net] extend core functionallity for ban/unban/listban 2017-03-02 13:23:03 -08:00
Alex van der Peet
94ee48c42a New RPC command disconnectnode 2017-03-02 13:23:03 -08:00
Stephen
6699b42518 Add paytxfee to getwalletinfo, warnings to getnetworkinfo 2017-03-02 13:23:03 -08:00
Daniel Kraft
e940185294 Fix univalue handling of \u0000 characters. 
Univalue's parsing of \u escape sequences did not handle NUL characters
correctly.  They were, effectively, dropped.  The extended test-case
fails with the old code, and is fixed with this patch.
 2017-03-02 13:23:03 -08:00
zkbot
14711a4a43 Auto merge of #2141 - bitcartel:1969_free_rate_limiter, r=daira 
Closes #1969. Large shielded transactions using the default fee are no longer treated as "free" transactions
 2017-03-02 03:51:14 +00:00
zkbot
c1cff6069f Auto merge of #2130 - str4d:2095-metrics-reindex-msg, r=arcalinea 
Do not ask a UI question on metrics screen

Based on bitcoin/bitcoin#8257.

Closes #2095.
 2017-03-02 03:08:29 +00:00
zkbot
1a41597af8 Auto merge of #2114 - bitcartel:fix_fr_test_bug_and_new_testnet_addresses, r=daira 
Closes #2113. Fixes bug in test and updates testnet fr addresses.

Updating the testnet fr addresses will introduce a consensus change on testnet, so all testnet nodes will be required to upgrade.  See #2113 for more information.
 2017-03-02 02:18:33 +00:00
zkbot
312fbd9d0e Auto merge of #1932 - aniemerg:1522-pause-mining-for-joinsplit, r=arcalinea 
Pause mining during JoinSplit creation

Closes #1522 .
 2017-03-02 01:23:44 +00:00
Allan Niemerg
49c2cecb9f Pause mining during joinsplit creation 2017-03-01 16:54:26 -08:00
zkbot
44ccf1ff20 Auto merge of #2123 - bitcartel:2112_z_getoperationresult_returns_executing_status, r=arcalinea 
Closes #2112 where z_getoperationresult could return stale status.

The problem was similar to a check-then-act race condition.  Status object was obtained from an operation, which might be in an 'executing' state.  Instead of checking the state recorded in the status object, the operation was queried again to see if it was in a finished state (failed,success,cancelled) and if yes, the status object was returned to the user.  However, if the operation had changed state in the background, the status object would be stale.
 2017-03-02 00:24:26 +00:00
Simon
ebe750a882 Part of #1969. Changing min fee calculation also changes the dust threshold. 2017-02-28 11:44:07 -08:00
Simon
0f724e716d Closes #1969. Default fee now sufficient for large shielded tx. 
Sets default min relay tx fee to 100, which is used to initialize
nSatoshisPerK for min fee calculation.  The default z_sendmany
fee of 10000 is now sufficient to cover a tx of size 100000 bytes,
so txs will not be treated as "free" and hit the free rate limiter.
 2017-02-28 11:43:04 -08:00
zkbot
6f5d8fbe81 Auto merge of #2126 - bitcartel:checkpoint_mainnet_67500, r=daira 
Add checkpoint at block 67500 (mainnet)

Close #2125
 2017-02-28 01:01:56 +00:00
zkbot
98ddf87d18 Auto merge of #2128 - bitcartel:checkpoint_testnet_38000, r=daira 
Add checkpoint at block 38000 (testnet)

Closes #2127
 2017-02-28 00:12:04 +00:00
Jack Grigg
0cd769fbb7 Treat metrics screen as non-interactive for now 
Closes #2095
 2017-02-23 12:55:14 +00:00
Jack Grigg
f42cde3c30 Remove reference to -reindex-chainstate 
Revert this when bitcoin/bitcoin#7917 is merged.
 2017-02-23 12:42:28 +00:00
Pieter Wuille
5d66d0a11e Do not ask a UI question from bitcoind 2017-02-23 12:40:45 +00:00
Simon
5a888f7294 Add testnet checkpoint at block 38000 2017-02-22 22:34:20 -08:00
Simon
b897de531c Add mainnet checkpoint at block 67500 2017-02-22 21:36:44 -08:00
Simon
2f21206cfc Closes #2112 where z_getoperationresult could return stale status. 2017-02-22 16:14:56 -08:00
Simon
1003180260 Keep first three original testnet fr addresses so existing coinbase 
transactions on testnet remain valid during upgrade.  New addresses
will be used starting from block 53127.
 2017-02-22 11:04:17 -08:00
zkbot
4e338b0c36 Auto merge of #2093 - bitcartel:sent_network_alerts, r=daira 
Closes #2092. Maintain record of alerts sent onto mainnet.
 2017-02-20 17:28:40 +00:00
Simon
4340ec9705 Update founders reward addresses for testnet 2017-02-20 09:23:06 -08:00
Simon
2911b35712 Fix bug where test was generating but not saving keys to wallet on disk. 2017-02-20 09:23:06 -08:00
Simon
f47269cda9 Add assert to check alert message length is valid 2017-02-17 11:55:41 -08:00
Leo Arias
82c754f628 Fix the path to the example configuration 2017-02-11 13:52:15 -06:00