Less noise unless -debug is used

qa/rpc-tests/test_framework/util.py

@@ -274,7 +274,7 @@ def start_node(i, dirname, extra_args=None, rpchost=None, timewait=None, binary=
     devnull.close()
     port     = extra_args[3]
     #port     = rpc_port(i)
-    print("port=%s" % port)
+    #print("port=%s" % port)
     username = rpc_username()
     password = rpc_password()
     url      = "http://%s:%s@%s:%s" % (username, password, rpchost or '127.0.0.1', port[9:])
@@ -283,7 +283,7 @@ def start_node(i, dirname, extra_args=None, rpchost=None, timewait=None, binary=
         proxy = AuthServiceProxy(url, timeout=timewait)
     else:
         proxy = AuthServiceProxy(url)
-    print("created proxy")
+    #print("created proxy")
     proxy.url = url # store URL on proxy for info
     return proxy
 

src/init.cpp

@@ -146,7 +146,9 @@ std::atomic<bool> fRequestShutdown(false);
 
 void StartShutdown()
 {
-	fprintf(stderr,"%s: fRequestShudown=true\n", __FUNCTION__);
+    if(fDebug) {
+	    fprintf(stderr,"%s: fRequestShudown=true\n", __FUNCTION__);
+    }
     fRequestShutdown = true;
 }
 bool ShutdownRequested()
@@ -208,7 +210,9 @@ void Shutdown()
     RenameThread(shutoffstr);
     mempool.AddTransactionsUpdated(1);
 
-	fprintf(stderr,"%s: stopping HUSH HTTP/REST/RPC\n", __FUNCTION__);
+    if(fDebug) {
+	    fprintf(stderr,"%s: stopping HUSH HTTP/REST/RPC\n", __FUNCTION__);
+    }
     StopHTTPRPC();
     StopREST();
     StopRPC();
@@ -225,7 +229,9 @@ void Shutdown()
     GenerateBitcoins(false, 0);
  #endif
 #endif
-	fprintf(stderr,"%s: stopping node\n", __FUNCTION__);
+    if(fDebug) {
+	    fprintf(stderr,"%s: stopping node\n", __FUNCTION__);
+    }
     StopNode();
     StopTorControl();
     UnregisterNodeSignals(GetNodeSignals());

src/wallet/asyncrpcoperation_sendmany.cpp

@@ -776,7 +776,6 @@ void AsyncRPCOperation_sendmany::lock_notes() {
     LogPrintf("%s: found %lu notes to lock\n", __func__, saplingNoteInputs_.size() );
     for (auto note : saplingNoteInputs_) {
         if(pwalletMain->IsLockedNote(std::get<0>(note))) {
-            //TODO: deal with this
             LogPrintf("%s: note already locked!\n", __func__);
         } else {
             pwalletMain->LockNote(std::get<0>(note));
@@ -790,7 +789,6 @@ void AsyncRPCOperation_sendmany::unlock_notes() {
     LogPrintf("%s: found %lu notes to unlock\n", __func__, saplingNoteInputs_.size() );
     for (auto note : saplingNoteInputs_) {
         if(pwalletMain->IsLockedNote(std::get<0>(note))) {
-            //TODO: deal with this
             pwalletMain->UnlockNote(std::get<0>(note));
         } else {
             LogPrintf("%s: note already unlocked!\n", __func__);

test.sh

@@ -1,4 +1,7 @@
 #!/usr/bin/env bash
+# Copyright 2016-2025 The Hush developers
+# Distributed under the GPLv3 software license, see the accompanying
+# file COPYING or https://www.gnu.org/licenses/gpl-3.0.en.html
 
 #export PYTHON_DEBUG=1
 export PYTHONPATH=./qa/rpc-tests/test_framework/