DragonX/dragonx
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 4 Wiki Activity
6,823 Commits 6 Branches 7 Tags
3cdae61aa22cd6eca43ac4e25c2ea0c1941fbd0d
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Philip Kaufmann 5e83bc404c [Qt] include and file header cleanup 
- alphabetical ordering
- correct ordering own headers before normal headers etc.
 2014-09-18 14:11:44 +02:00
Philip Kaufmann 93f84d0417 cleanup class private and public areas in walletdb 
- only code movement
 2014-09-18 07:21:49 +02:00
Philip Kaufmann 22d7e7014f prefer const string& over char* in CDB and CWalletDB constructor 
- also make parameter of CDBEnv::CheckpointLSN a constant reference
 2014-09-18 07:21:49 +02:00
Philip Kaufmann f4fe205034 add nModSize init to default constructor of CTxMemPoolEntry 2014-09-16 15:07:45 +02:00
Philip Kaufmann ee304b6e35 minor changes for help message of getpeerinfo 2014-09-16 09:00:36 +02:00
Philip Kaufmann 611116d4e3 header include cleanup 
- ensures alphabetical ordering for includes etc. in source file headers
 2014-09-14 12:43:56 +02:00
Philip Kaufmann 2d79bba36b cleanup new script files (no code changes) 
- add missing header end comments
- ensure alphabetical ordering
- update copyright year and license
 2014-09-14 12:25:38 +02:00
Philip Kaufmann faadbe1733 remove unneeded cast in rpcmisc.cpp 2014-09-09 19:23:29 +02:00
Philip Kaufmann 2c2cc5dac1 Remove some unnecessary c_strs() in logging and the GUI 
Includes `core: remove unneeded c_str() / Qt: replace c_str() with Qt code`
by P. Kaufmann.
 2014-09-09 11:31:17 +02:00
Philip Kaufmann 2605b94d73 [Qt] update form files for setting autoDefault explicitly to false 
- also fixes indentation in one file (auto fixed by Qt Designer)
- removes several default parameters, which are not needed in the files
- related to #4840 (but not intended as fix for a no-bug)
 2014-09-05 13:54:16 +02:00
Philip Kaufmann 1ffb99b07f [Qt] copyright, style and indentation cleanup of Qt tests 2014-09-05 13:23:21 +02:00
Philip Kaufmann a264e445ff remove dup include of foreach.hpp in script.cpp 2014-09-05 09:49:57 +02:00
Philip Kaufmann fbe0fcae76 [Qt] minor watch-only changes 
- use watch-only, not watchonly
- add back a tooltip hint when hovering addresses and attach
  "(watch-only)" at the end
 2014-08-28 23:20:46 +02:00
Philip Kaufmann bbad683224 [Qt] simplify return code and return values in txtablemodel 
- also move an added space in a string where it belongs
 2014-08-28 23:14:11 +02:00
Philip Kaufmann 21f1516468 [Qt] add all used colors in txtablemodel to guiconstants 
- add colors used in TX status decoration
 2014-08-28 23:14:10 +02:00
Philip Kaufmann 187115c01d cleanup include of assert.h 2014-08-28 23:02:49 +02:00
Philip Kaufmann 4d04492bf2 add missing copyright headers 2014-08-28 22:26:56 +02:00
Philip Kaufmann 093303a887 add missing header end comments 
- ensures a consistent usage in header files
- also add a blank line after the copyright header where missing
- also remove orphan new-lines at the end of some files
 2014-08-28 22:25:21 +02:00
Philip Kaufmann 22b3c4bbbd remove unused class CAddrMan; from db.h 2014-08-10 14:30:30 +02:00
Philip Kaufmann b197bf3270 [Qt] disable tray interactions when client model set to 0 
- this prevents the ability to fiddle around with the system tray when
  already shutting down (e.g. on slow shutdowns because of a proxy delay)
- extends solution for #4360
 2014-08-08 12:13:39 +02:00
Philip Kaufmann 314fbd9ac7 [Qt] use BitcoinGUI::DEFAULT_WALLET constant in bitcoin.cpp 2014-08-08 12:13:27 +02:00
Philip Kaufmann 8ca6a16176 [Qt] ensure all class attributes are init to 0 
- in BitcoinGUI and UnitDisplayStatusBarControl
 2014-08-08 12:13:26 +02:00
Philip Kaufmann c4bae53092 [Qt] move SubstituteFonts() above ToolTipToRichTextFilter 
- doesn't belong to the ToolTipToRichTextFilter class so move it up
 2014-08-08 11:04:35 +02:00
Philip Kaufmann 94e1b9e05b [Qt] re-work overviewpage UI 
- ensure normal and watch-only stuff looks consistent
- simplify UI by removing unneeded UI layout elements
- change some comments to watch-only from watchonly
 2014-08-08 09:58:58 +02:00
Philip Kaufmann efd6b87811 small net cleanup 
- add comment for disabling sigpipe
- add closing comment in compat.h
- remove redundant check in net.h
 2014-08-08 07:40:45 +02:00
Philip Kaufmann a409467e14 more Bitcoin -> Bitcoin Core string changes 2014-08-04 21:09:38 +02:00
Philip Kaufmann ead6737b87 [Qt] format ping times in peers tab as ms 
- also align ping times to the right
 2014-08-04 19:23:57 +02:00
Philip Kaufmann a5b2d9c82e [Qt] tweak new peers tab in console window 
- remove starting height as table header and replace with ping time
- remove columnResizingFixer
- add local address (if available) in detailed node view (on top of the
  right view below the remote address)
- remove some .c_str() by using QString::fromStdString()
- rename Address to Address/Hostname
- rename secs to just s for ping time
- use MODEL_UPDATE_DELAY from guiconstants.h for the peer refresh time
- make PeerTableModel::columnCount() return no hard-coded value
- remove and cleanup dup private: section in RPCConsole header
- add new defaults for column sizes
- remove behaviour which keeps disconnected peers selected and also remove
  code which keeps track of last selected peer stats
- add sync height to detail view
- add some additional NULL pointer checks for clientModel in
  rpcconsole.cpp
 2014-08-04 15:46:18 +02:00
Philip Kaufmann 2b600992e8 add license header to core_io.h, core_read/_write.cpp 2014-08-01 08:39:06 +02:00
Philip Kaufmann 1b73d36b2c fix compilation error in core_io.h 
- error: 'vector' in namespace 'std' does not name a type
- add <vector> include in core_io.h
- remove <vector> includes from core_read.cpp and core_write.cpp
 2014-08-01 08:38:23 +02:00
Philip Kaufmann 283a3b88b6 small ordering cleanup of init help message 2014-08-01 08:04:46 +02:00
Philip Kaufmann d817187bdb [Qt] remove ProxySocksVersion from OptionID 
- we only support SOCKS5, so remove it
 2014-07-28 14:47:27 +02:00
Philip Kaufmann f65352a7d0 [Qt] small Qt-only include cleanup 2014-07-25 17:43:41 +02:00
Philip Kaufmann f469f79ff8 remove an unneded .c_str() in OpenNetworkConnection() 2014-07-21 15:00:42 +02:00
Philip Kaufmann c994d2e769 prevent SOCKET leak in BindListenPort() 
- the call to CloseSocket() is placed after the WSAGetLastError(), because
  a CloseSocket() can trigger an error also, which we don't want for the
  logging in this two cases
 2014-07-17 22:49:23 +02:00
Philip Kaufmann eaedb59e05 net: add SetSocketNonBlocking() as OS independent wrapper 2014-07-17 22:12:44 +02:00
Philip Kaufmann 7de3f1cfd6 fix help message for RPC getpeerinfo 2014-07-17 15:10:29 +02:00
Philip Kaufmann 4eedf4ffee make RandAddSeed() use OPENSSL_cleanse() 
- removes the cstring include and is also used in RandAddSeedPerfmon()
 2014-07-09 09:43:55 +02:00
Philip Kaufmann 6354935c48 move rand functions from util to new random.h/.cpp 2014-07-09 09:42:19 +02:00
Philip Kaufmann 001a53d742 add GetRandBytes() as wrapper for RAND_bytes() 
- add a small wrapper in util around RAND_bytes() and replace with
  GetRandBytes() in the code to log errors from calling RAND_bytes()
- remove OpenSSL header rand.h where no longer needed
 2014-07-09 09:42:18 +02:00
Philip Kaufmann 00d1980b8f init.cpp: log fee estimates filename on error 
- small changes to Shutdown(), buffer __func__, which is now used in
  all LogPrintf() calls and format for better readability
- order using namespace alpabetically
 2014-07-09 09:22:36 +02:00
Philip Kaufmann a339a37b28 error out, when we detect -socks argument 2014-07-07 08:15:14 +02:00
Philip Kaufmann 0127a9be14 remove SOCKS4 support from core and GUI 
- now we support SOCKS5 only
 2014-07-07 08:15:14 +02:00
Philip Kaufmann 674c070e5d [Qt] seed OpenSSL PNRG with Windows event data 
- see https://bitcointalk.org/index.php?topic=113496.msg1228193#msg1228193
  for the initial suggestion for this
- also ensure consistent debug.log message format
 2014-07-04 17:16:36 +02:00
Philip Kaufmann 3d0e92dc83 [Qt] remove dup includes in bitcoingui 2014-07-04 16:51:25 +02:00
Philip Kaufmann 8d9cc7d743 fix copyright string in two of our *.rc files 
- also make comment about rc-files in clientversion.h generic

Merges #4429.
 2014-07-01 12:13:37 +02:00
Philip Kaufmann 33c62c9c0b set shutdown title to main window title 
- this ensures we don't show Bitcoin-Qt as that is still our
  internal application name
- fixes #4427
 2014-06-27 15:09:41 +02:00
Philip Kaufmann 40a158e100 minor code format fix in rpc-related files 2014-06-27 11:13:25 +02:00
Philip Kaufmann 86fe1b864b update coding.md to reflect changes by pull 
- also mention alphabetical include ordering
 2014-06-26 11:56:56 +02:00
Philip Kaufmann cf04d83624 add OpenSSL RAND_cleanup() on OpenSSL shutdown 
- to securely erase the memory used by the PNRG
- also rework 2 comments in OpenSSL init
 2014-06-26 11:04:31 +02:00
Philip Kaufmann 5d59921237 add missing BOOST_FOREACH indentation in ThreadSocketHandler() 2014-06-26 11:01:24 +02:00
Philip Kaufmann 9e9ca2b671 small cleanup of #ifdefs in BindListenPort() 
- SO_NOSIGPIPE isn't available on WIN32 so merge the 2 non-WIN32 blocks
- use predefined names from header for IPV6_PROTECTION_LEVEL and
  PROTECTION_LEVEL_UNRESTRICTED
 2014-06-26 11:01:23 +02:00
Philip Kaufmann e10dcf27b4 ensure clean and consistent "namespace" usage 
- remove some missplaced ;
- ensure end of a namespace is clearly visible
- use same formatting when using namespace
 2014-06-26 10:36:57 +02:00
Philip Kaufmann 5fbb4c9b58 [Qt] fix links in about window not opening 
- closes #4402
 2014-06-24 16:36:14 +02:00
Philip Kaufmann 1c750dbd40 remove -tor compatibility code (only allow -onion) 
- exit, if -tor option is found and give error to user
 2014-06-24 16:07:20 +02:00
Philip Kaufmann 6dc90ed8fa replace 3 separate calls to WSAGetLastError() with 1 2014-06-24 08:46:12 +02:00
Philip Kaufmann 6a5c124b84 [Qt] don't allow translation of our example btc address 2014-06-23 15:11:28 +02:00
Philip Kaufmann b612bde521 remove unneded class CNodeCombinedStats; from rpcconsole.cpp 
- also 2 small style fixes
 2014-06-23 08:06:52 +02:00
Philip Kaufmann 3dc1464f0a add missing vhListenSocket.clear(); to CNetCleanup() 2014-06-22 14:52:38 +02:00
Philip Kaufmann 2831a03b79 remove unused CNode::Cleanup() 2014-06-22 14:51:38 +02:00
Philip Kaufmann 0655fac0b1 miner: indentation fixes, remove for (;;) 
- change a for (;;) into while (true), as we nowhere else use the first
- init nNonceFound to 0
- fix indentation in BitcoinMiner try/catch block
 2014-06-22 00:33:42 +02:00
Philip Kaufmann fc0c07eb64 small cleanup in src/compat .h and .cpp 
- add license header
- fix include guards
- fix indentation
 2014-06-21 14:39:17 +02:00
Philip Kaufmann 1020f599f3 add comment to HelpMessage() to ensure alphabetical ordering 
- also rename hmm to mode, to be consistent between .h and .cpp
 2014-06-17 09:17:12 +02:00
Philip Kaufmann 6763018797 [Qt] rename In:/Out: to Received/Sent in traffic tab 
- collides with In:/Out: used for displaying number of
  connections when translating
 2014-06-16 08:23:45 +02:00
Philip Kaufmann f5ae6c9826 add NetworkIDString() to chainparams 
- returns the BIP70 network string
- use that new function in the core and GUI code and remove unused code
  and functions
 2014-06-12 13:19:12 +02:00
Philip Kaufmann f3790472f0 remove unused code from getblockchaininfo() 2014-06-11 14:56:08 +02:00
Philip Kaufmann 634bd61b76 convert an if into an else if in OpenNetworkConnection() 2014-06-11 12:40:13 +02:00
Philip Kaufmann 5bd6c31bd6 small cleanup of net 
- remove an unneded else in ConnectNode()
- make 0 a double and change to 0.0 in ConnectNode()
- rename strDest to pszDest in OpenNetworkConnection()
- remove an unneded call to our REF() macro in BindListenPort()
- small style cleanups and removal of unneeded new-lines
 2014-06-11 12:38:31 +02:00
Philip Kaufmann 4aaa01783d rework help messages for fee-related options 
- mention the units and show the default for -paytxfee
 2014-06-11 12:16:26 +02:00
Philip Kaufmann 56b07d2dcd [Qt] allow setting listen via GUI 
- add DEFAULT_LISTEN in net.h and use in the code (shared
  setting between core and GUI)

Important: This makes it obvious, that we need to re-think the
settings/options handling, as GUI settings are processed before
any parameter-interaction (which is mostly important for network
stuff) in AppInit2()!
 2014-06-11 12:04:17 +02:00
Philip Kaufmann 699fe635c6 remove wrong ; in chainparams.h and order includes 2014-06-10 19:33:12 +02:00
Philip Kaufmann 1c24187b51 remove unused UPnP code from main.h 2014-06-10 18:34:35 +02:00
Philip Kaufmann ac14bcc1f1 small formatting, indentation and comment fixes 
- contains zero code changes
 2014-06-10 18:23:56 +02:00
Philip Kaufmann fe6bff2eae [Qt] add BerkeleyDB version info to RPCConsole 
- to match info function between debug.log and RPCConsole
 2014-06-04 22:00:59 +02:00
Philip Kaufmann 5bd02cf715 log used config file to debug.log on startup 2014-06-04 21:19:22 +02:00
Philip Kaufmann bbe1925ce3 [Qt] style police and small addition in rpcconsole 
- fix spaces, indentation and coding style glitches
 2014-06-03 15:01:50 +02:00
Philip Kaufmann cb7a3edc3d remove dup of extern int nConnectTimeout; in netbase 2014-05-31 12:04:34 +02:00
Philip Kaufmann 53a088154c rename fNoListen to fListen and move to net 
- better code readability and it belongs to net
- this is a prerequisite for a pull to add -listen to the GUI
 2014-05-29 14:01:39 +02:00
Philip Kaufmann d4e1c61212 add DEFAULT_UPNP constant in net 
- as this is a shared Core/GUI setting, this makes it easier to keep them
  in sync (also no new includes are needed)
 2014-05-20 15:34:19 +02:00
Philip Kaufmann 4629f95b22 [Qt] fix ugly typo in bitcoin.cpp 
Closes #4145.

Rebased-By: Wladimir J. van der Laan <laanwj@gmail.com>
Rebased-From: 1e4b083
 2014-05-07 15:48:17 +02:00
Philip Kaufmann bdc83e8f45 [Qt] ensure payment request network matches client network 
- replaces checks in SendCoinsDialog::handlePaymentRequest() that belong
  to PaymentServer (normal URIs are special cased, as only an isValid
  check is done on BTC addresses)
- prevents the client to handle payment requests that do not match the
  clients network and shows an error instead (mainly a problem with
  drag&drop payment requests onto the client window)
- includes some small comment changes also
 2014-05-06 21:20:00 +02:00
Philip Kaufmann 01ce711798 [Qt] fix Qt slot problem in receivecoinsdialog 
- fixes error from debug.log:
  QMetaObject::connectSlotsByName: No matching signal for
  on_recentRequestsView_selectionChanged(QItemSelection,QItemSelection)
- small style fixes (e.g. alphabetical ordering if includes etc.)
- fixes #3992
 2014-05-06 12:52:21 +02:00
Philip Kaufmann 3e1cf9b6f6 add DEFAULT_TRANSACTION_FEE constant in wallet 
- as this is a shared Core/GUI setting, this makes it easier to keep them
  in sync (also no new includes are needed)
 2014-05-05 20:54:00 +02:00
Philip Kaufmann 2fdd4c7933 better std::exception logging for CAddrDb 
- also small logging text changes
 2014-05-02 14:35:30 +02:00
Philip Kaufmann 1cc7f54a8d use standard __func__ instead of __PRETTY_FUNCTION__ 2014-04-30 14:45:24 +02:00
Philip Kaufmann d282c1fb64 [Qt] catch Windows shutdown events while client is running 
- prevents unsafe shutdowns on Windows, which is known to be
  able to cause problems with wallet.dat
- if a users ends a Windows session, this will initiate a client shutdown
  and show a Windows dialog, that tells the user what is going on (for
  Windows Vista and higher it will even show a reason for blocking the
  Windows session end)
 2014-04-15 11:57:55 +02:00
Philip Kaufmann d34b958406 [Qt] small cleanup of coincontroldialog 
- use a little more Qt-style
- check for NULL pointers first and return in updateView()
- small space and formating changes
 2014-04-01 10:11:18 +02:00
Philip Kaufmann f7257cfbd9 unified and better log/error messages for CDBEnv/CDB 2014-04-01 09:41:49 +02:00
Philip Kaufmann 5409404d75 add constant for shared (GUI/core) -par settings 
- introduce DEFAULT_SCRIPTCHECK_THREADS in main.h
- only show values from -"MAX_HW_THREADS" up to 16 for -par, as it
  makes no sense to try to leave more "cores free" than the system
  supports anyway
- use the new constant in optionsdialog and remove defaults from
  .ui file
 2014-03-27 11:54:13 +01:00
Philip Kaufmann cfe4cad9e5 [Qt] fix style, formating, comment and indentation problems 
- introduced by #3920
 2014-03-27 09:22:15 +01:00
Philip Kaufmann c17f0a58b4 [Qt] remove space from translation of client bitness 
- its rather easy to leave out the space on Transifex, so remove it from
  the string
 2014-03-21 08:49:51 +01:00
Philip Kaufmann 2b45345aac minor style cleanups 2014-03-11 17:26:05 +01:00
Philip Kaufmann 8e29623077 [Qt] show number of in/out connections in debug console 2014-03-03 22:35:02 +01:00
Philip Kaufmann a486abd419 replace custom GetFilesize() with boost::filesystem::file_size() 2014-03-03 22:33:09 +01:00
Philip Kaufmann f05fa03e8b [Qt] small .ui cleanup for optionsdialog and coincontrol 2014-02-17 15:50:40 +01:00
Philip Kaufmann 82e96006ae add constants for shared (GUI/core) -dbcache settings 
- adds nDefaultDbCache, nMaxDbCache and nMinDbCache in txdb.h
 2014-02-17 15:44:21 +01:00
Philip Kaufmann 7f1b6a6316 remove orphan fHaveGUI from main.h 2014-02-16 22:05:24 +01:00
Philip Kaufmann 3e0753b0f5 always show syncnode in getpeerinfo (fixes #2717) 2014-02-16 18:44:49 +01:00
Philip Kaufmann ceb8e226ef [Qt] allow translation of client bitness 2014-02-16 03:01:34 +01:00
Philip Kaufmann bbfce8a4c9 fix non-standard reason string in main.cpp 2014-02-13 15:12:18 +01:00