Commit Graph

9553 Commits

Author SHA1 Message Date
Jack Grigg
52fdce985f Add RPC test showing correct handling of JS txns from blockchain
For unencrypted wallets, the wallet correctly tracks JoinSplits made for their
zkey in a different wallet.
2016-10-14 17:14:13 -05:00
Jack Grigg
fb2653ed0e Add unit test that fails when calling FindMyNotes on a locked wallet 2016-10-14 17:14:13 -05:00
zkbot
cc10005247 Auto merge of #1486 - str4d:1456-writewitnesscache-exception-safety, r=bitcartel
WriteWitnessCache: Catch errors and abort transaction

Closes #1452
2016-10-14 17:37:53 -04:00
zkbot
3fceaca3a1 Auto merge of #1506 - bitcartel:master_1478_fix_testnet3_test_issue, r=bitcartel
Stop some wallet tests creating ~/.zcash/testnet3 folder by setting -datadir environment

Closes #1478
2016-10-14 17:03:11 -04:00
Simon
b13a87c6d7 Reorder gtests in zcash-gtest.
There is an issue where checktransaction_tests will output errors to ~/.zcash/testnet3/debug.log
because other tests which run before it select the testnet chain parameters.
2016-10-14 13:36:53 -07:00
Simon
6be367ea6d Fix test so that the encrypted wallet is output to the test_bitcoin -datadir folder. 2016-10-14 12:44:22 -07:00
4ZEC
cc6c9ec05e Correct line swap
Pretty clear the author wanted these two lines in other order.
2016-10-14 13:35:22 -04:00
zkbot
27bc01a05b Auto merge of #1523 - bitcartel:master_1504_z_logging, r=bitcartel
Refine LogPrint debugging for z_* rpc calls

For #1504 ZCA011
2016-10-14 11:11:26 -04:00
Jack Grigg
6da46b692a Refactor test to clarify expectations 2016-10-14 09:31:26 -05:00
zkbot
6432b8c453 Auto merge of #1499 - arcalinea:document-coinbase-maturity-security, r=bitcartel
Note that Coinbase maturity interval does not protect JoinSplits

Changed wording of Block Chain Reorganization section in security-warnings.md to note that we did not change Coinbase maturity #1387, but that this also does not protect JoinSplits from becoming invalidated in the case of a block chain reorg #953
2016-10-13 23:52:37 -04:00
zkbot
bb25bd4bc1 Auto merge of #1533 - bitcartel:master_1447_document_getfilterednotes, r=bitcartel
Document CWallet::GetFilteredNotes

Also fixes return type of method which should be void.

Part of #1447
2016-10-13 20:25:19 -04:00
Simon
cb0d208f6b Document CWallet::GetFilteredNotes and fix return type which should be
void.
2016-10-13 17:01:54 -07:00
zkbot
2b29970e28 Auto merge of #1531 - str4d:1447-document-findmynotes, r=bitcartel
Document CWalletTx::FindMyNotes

Part of #1447
2016-10-13 19:51:06 -04:00
Jay Graber
4f61aa6a6a Reword joinsplit anchor paragraph 2016-10-13 16:33:26 -07:00
Jack Grigg
e492d98632 Document CWalletTx::FindMyNotes
Part of #1447
2016-10-13 18:27:58 -05:00
zkbot
8eb672251b Auto merge of #1513 - bitcartel:master_1491_fix_help_message_rpc_z_importkey, r=daira
Fixes #1491 by updating help message for rpc call z_importkey
2016-10-13 19:05:08 -04:00
zkbot
a9243e4f15 Auto merge of #1512 - arcalinea:cleanup-documentation, r=daira
Cleanup documentation

Start cleaning up unused/obsolete documentation. ref #1500
2016-10-13 18:24:57 -04:00
zkbot
49fc58b782 Auto merge of #1514 - bitcartel:master_1481_client_identifier, r=bitcartel
Rename client identifier from Satoshi to MagicBean (closes #1481)

@ageis seeder will have be to updated too.
2016-10-13 02:02:58 -04:00
Jay Graber
6ca68f6745 Mv btc release notes to doc/bitcoin-release-notes 2016-10-12 16:43:45 -07:00
Jay Graber
b54c195ab4 Revert "Rm Bitcoin-specific documentation"
This reverts commit 4902350d32.
2016-10-12 16:33:44 -07:00
Simon
438d1e45be Use -debug=zrpc for z_* rpc calls (#1504) 2016-10-12 15:46:24 -07:00
zkbot
3fdca8a8ed Auto merge of #1511 - arcalinea:document-hidden-service-in-tor.md, r=bitcartel
Tor.md: change alpha to beta testnet, add new zcash hidden service address

Note: When @ageis and I checked this the other day, we were getting multiple peer connections. Think we said we'd change this before launch, so I opened issue #1510. Leaving documentation to expect a single peer.
2016-10-12 14:55:03 -04:00
Jay Graber
1f48a3403b Distinguish between connecting to 1 vs multiple tor nodes 2016-10-12 11:37:49 -07:00
Simon
5bd677f5c6 Rename client identifier from Satoshi to MagicBean (closes #1481) 2016-10-12 10:50:05 -07:00
Simon
e346a0b3f8 Add tests to verify that all z_* rpc calls return an error if there are too many input parameters. 2016-10-12 10:15:12 -07:00
Simon
49e591eb89 Fix incorrect check of number of parameters for z_getnewaddress. 2016-10-12 10:14:32 -07:00
zkbot
137d1f14eb Auto merge of #1507 - ageis:wget-retry, r=bitcartel
Set wget retry options for fetching parameters

This will retry upon refused connections and similar errors, wait 1 second before the next retry, time out after 10 seconds if no data is received or the connection times out, plus try an infinite number of times.

Resolves #1196.
2016-10-11 21:57:39 -04:00
Simon
950f8ffdb6 Fixes #1491 by updating help message for rpc call z_importkey 2016-10-11 16:52:38 -07:00
Jay Graber
59f9305432 Merge branch 'document-hidden-service-in-tor.md' of github.com:arcalinea/zcash into document-hidden-service-in-tor.md 2016-10-11 15:48:42 -07:00
Jay Graber
18a96c7977 Update tor.md 2016-10-11 15:48:09 -07:00
Jay Graber
8908b299c4 Improve documentation on connecting to zcash hidden server 2016-10-11 15:47:05 -07:00
Jay Graber
856b92faa1 Improve documentation on connecting to zcash hidden server 2016-10-11 15:44:38 -07:00
Jay Graber
5b07ee597c Change alpha to beta testnet, add zcash hidden service 2016-10-11 12:06:24 -07:00
Kevin Gallagher
e3320f4f0f Increases timeout to 30s, wait before retry to 3s
Default: 20 tries
2016-10-11 10:56:01 -07:00
Jack Grigg
82c2d97c60 Add unit tests for WriteWitnessCache
Requires moving implementation into header
2016-10-11 09:33:47 -05:00
zkbot
7dc49cbc6a Auto merge of #1490 - str4d:1454-deprecate-accounts, r=bitcartel
Throw an RPC error for all accounts except the default

Closes #1454
2016-10-10 23:55:02 -04:00
Kevin Gallagher
f964718c83 Set wget retry options for fetching parameters
This will retry upon refused connections and similar errors, wait 1 second
before the next retry, time out after 10 seconds if no data is received or
the connection times out, plus try an infinite number of times.
2016-10-10 20:34:55 -07:00
Simon
32bf097f90 Fixes #1478 by ensuring wallet tests have the -datadir environment set appropriately. 2016-10-10 20:23:24 -07:00
str4d
29af81274e Merge pull request #7 from daira/1454-deprecate-accounts
1454 deprecate accounts
2016-10-10 21:00:39 -05:00
zkbot
4210e20c9c Auto merge of #1501 - ebfull:100kb-max-tx, r=ebfull
Make 100KB transaction size limit a consensus rule, rather than a standard rule

Closes #1475
2016-10-10 15:39:42 -04:00
Daira Hopwood
3040239e2a Cosmetics in RPC tests.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2016-10-10 20:27:16 +01:00
Daira Hopwood
218ded68f3 Fix RPC tests to not rely on accounts.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2016-10-10 20:26:52 +01:00
Jack Grigg
715e5bbefd Correct docstring 2016-10-10 10:47:38 -05:00
Jack Grigg
7b3351ff0e Deprecated -> Unsupported in RPC error 2016-10-10 10:47:36 -05:00
Jack Grigg
b6f100cf86 Update tests for account deprecation 2016-10-10 10:47:30 -05:00
zkbot
bc0629230a Auto merge of #1493 - bitcartel:master_1446_gettransaction, r=bitcartel
Add vjoinsplit to JSON output of RPC call gettransaction

Closes #1446.
2016-10-08 02:41:18 -04:00
Sean Bowe
74f15a73a1 Make 100KB transaction size limit a consensus rule, rather than a standard rule. 2016-10-08 00:00:23 -06:00
Jay Graber
098af42f36 Rm doc for disabled REST interface 2016-10-07 16:22:52 -07:00
Jay Graber
82dd46a6d8 Add note that document is not updated for Zcash to translation policy 2016-10-07 16:22:26 -07:00
Jay Graber
4902350d32 Rm Bitcoin-specific documentation 2016-10-07 16:21:57 -07:00