Commit Graph
100 Commits
Author SHA1 Message Date
Wladimir J. van der Laan 5e2fb330fd Merge pull request #3409
a9a37c8 update help for -blockmaxsize and blockprioritysize (Philip Kaufmann)
2013-12-13 10:13:32 +01:00
Wladimir J. van der Laan 666225f687 Merge pull request #3387
3e01c00 Add tests for correct and incorrect order of signatures for a multisig (P2SH) (Tamas Blummer)
2013-12-13 06:03:40 +01:00
Wladimir J. van der Laan 150771c4f3 Merge pull request #3326
ad898b4 Increase default -blockmaxsize/prioritysize to 750K/50K (Gavin Andresen)
2013-12-13 05:39:35 +01:00
Wladimir J. van der Laan d670cdd698 Merge pull request #3407
952fe2e docs: remove workaround instructions now that the problem is fixed (Cory Fields)
efdfee4 build: fix detection of boost libs on multi-arch distros (Cory Fields)
2013-12-13 05:16:19 +01:00
Wladimir J. van der Laan 5e47c2b70a Merge pull request #3382
24646ee [Qt] fix possibilty to delete last sendcoins entry (Philip Kaufmann)
2013-12-11 15:10:21 +01:00
Wladimir J. van der Laan 69127034c3 Merge pull request #3379
4f99b16 Release process: add section about announcing new release (Wladimir J. van der Laan)
2013-12-11 12:41:51 +01:00
Wladimir J. van der Laan 6939a0d50e Merge pull request #3350
fdbdb7f cleanup includes in rpcnet.cpp (Philip Kaufmann)
b6aafca some string and indentation updates in init/rpcclient (Philip Kaufmann)
2013-12-10 12:37:43 +01:00
Wladimir J. van der Laan 4f99b1601b Release process: add section about announcing new release 2013-12-10 09:57:30 +01:00
Wladimir J. van der Laan fb96e28b29 Merge pull request #3378
b9c3416 Add protobuf-compiler dependency package for debian (Wladimir J. van der Laan)
2013-12-10 09:03:44 +01:00
Wladimir J. van der Laan b9c3416723 Add protobuf-compiler dependency package for debian
Fixes #3361
2013-12-10 09:02:35 +01:00
Wladimir J. van der Laan 955787f83f Merge pull request #3207
666893b qt: keep a list of requested payments (Wladimir J. van der Laan)
2013-12-09 16:42:37 +01:00
Wladimir J. van der Laan 20a3c80790 Merge pull request #3178
f914c7a rpcwallet: use EnsureWalletIsUnlocked() where possible (Philip Kaufmann)
2013-12-09 16:24:23 +01:00
Wladimir J. van der Laan 6694f4a7a2 Merge pull request #3297
84f8551 [Qt] misc small Mac related changes/cleanups (Philip Kaufmann)
2013-12-09 15:36:14 +01:00
Wladimir J. van der Laan 7266bb1bdc Merge pull request #3373
80ecf67 Add ThreadGetMyExternalIP to net thread group (Gavin Andresen)
2013-12-09 12:27:59 +01:00
Wladimir J. van der Laan fbc7a96d03 Re-enable miner tests in --disable-wallet mode
Use a fixed script instead of a CReserveKey from the wallet.
This does not affect the functionality or result of the tests as they never
check the state of the wallet in the first place.
2013-12-09 09:25:10 +01:00
Wladimir J. van der Laan acfa03337e Move internal miner functionality together 2013-12-09 08:55:56 +01:00
Wladimir J. van der Laan 4a85e06750 Allow mining RPCs with --disable-wallet
The following mining-related RPC calls don't use the wallet:

- getnetworkhashps
- getmininginfo
- getblocktemplate
- submitblock

Enable them when compiling with --disable-wallet.
2013-12-09 08:44:57 +01:00
Wladimir J. van der Laan 70370ae502 Merge pull request #3348
ccd1372 [Qt] small notificator and style changes (Philip Kaufmann)
2013-12-08 14:24:49 +01:00
Wladimir J. van der Laan 6893d74e15 Merge pull request #3322
26d1b65 src/Makefile.am: Simplify clean of leveldb (Josh Triplett)
a26a367 configure.ac: Check for miniupnpc headers, not just -lminiupnpc (Josh Triplett)
82ccb05 autogen.sh: Stop passing --verbose to autoreconf (Josh Triplett)
e12dafd autogen.sh: Use long options to autoreconf, for self-documentation (Josh Triplett)
19b9add autogen.sh: Support running from outside the source directory (Josh Triplett)
97d285a autogen.sh: Use set -e to fail if any command fails (Josh Triplett)
f80b723 autogen.sh: Add a /bin/sh shebang. (Josh Triplett)
2013-12-08 13:56:12 +01:00
Wladimir J. van der Laan 05e27c6641 Merge pull request #3332
5094f8d Split off rpc_wallet_tests (Wladimir J. van der Laan)
829c920 Move CCryptoKeyStore to crypter.cpp (Wladimir J. van der Laan)
ae6ea5a Update build-unix.md to mention --disable-wallet (Wladimir J. van der Laan)
4f9e993 Add --disable-wallet option to build system (Wladimir J. van der Laan)
d004d72 Move CAddrDB frrom db to net (Wladimir J. van der Laan)
48ba56c Delimit code with #ifdef ENABLE_WALLET (Wladimir J. van der Laan)
991685d Move getinfo to rpcnet.cpp (Wladimir J. van der Laan)
bbb0936 Move HelpExample* from rpcwallet to rpcserver (Wladimir J. van der Laan)
2013-12-08 13:52:48 +01:00
Wladimir J. van der Laan 9ac11a4e1e Merge pull request #3254
4cf3411 [Qt] misc PaymentServer changes (e.g. changes to eventFilter()) (Philip Kaufmann)
2013-12-06 11:32:25 +01:00
Wladimir J. van der Laan b4297c8fff Merge pull request #3353
1e01f7c Payment request URI syntax changed, from request=... to r=... (Gavin Andresen)
2013-12-06 09:46:48 +01:00
Wladimir J. van der Laan ac57a2320f Merge pull request #3359
38cbeab fix typo in rpcnet.cpp (Philip Kaufmann)
2013-12-05 09:35:10 +01:00
Wladimir J. van der Laan b1961523f1 Merge pull request #3356
d3ef9b0 Prevent empty transactions from being added to vtxPrev (Wladimir J. van der Laan)
2013-12-05 08:17:02 +01:00
Wladimir J. van der Laan 80ca273b7f Merge pull request #3357
4ef92a9 Refuse to retransmit transactions without vins (Wladimir J. van der Laan)
2013-12-04 18:29:00 +01:00
Wladimir J. van der Laan 4ef92a9067 Refuse to retransmit transactions without vins
Versions of bitcoin before 0.8.6 have a bug that inserted
empty transactions into the vtxPrev in the wallet, which will cause the node to be
banned when retransmitted, hence add a check for !tx.vin.empty()
before RelayTransaction.
2013-12-04 15:40:51 +01:00
Wladimir J. van der Laan d3ef9b00ec Prevent empty transactions from being added to vtxPrev
CWalletTx::AddSupportingTransactions() was adding empty transaction
to vtxPrev in some cases. Skip over these.

Part one of the solution to #3190. This prevents invalid vtxPrev from
entering the wallet, but not current ones being transmitted.
2013-12-04 15:30:23 +01:00
Wladimir J. van der Laan 5094f8d46f Split off rpc_wallet_tests
Split wallet tests from other RPC tests.
Now no #ifdef ENABLE_WALLET are needed anymore in either file.
2013-12-04 12:46:14 +01:00
Wladimir J. van der Laan 829c920387 Move CCryptoKeyStore to crypter.cpp
This breaks the dependency on crypter for disable-wallet builds.
2013-12-04 12:46:13 +01:00
Wladimir J. van der Laan ae6ea5a6fa Update build-unix.md to mention --disable-wallet
Mention the new --disable-wallet mode.
Also, correct the BDB entry in the dependencies table.
2013-12-04 12:46:13 +01:00
Wladimir J. van der Laan 4f9e993bc9 Add --disable-wallet option to build system
Make it possible to build Bitcoin without wallet
(and thus without BDB) so that it only functions as node.
2013-12-04 12:46:13 +01:00
Wladimir J. van der Laan d004d7279f Move CAddrDB frrom db to net
This was a leftover from the times in which
peers.dat depended in BDB.

Other functions in db.cpp still depend on BerkelyDB,
to be able to compile without BDB this (small)
functionality needs to be moved to another file.
2013-12-04 12:46:13 +01:00
Wladimir J. van der Laan 48ba56cdfd Delimit code with #ifdef ENABLE_WALLET
Delimit all code that uses the wallet functions
in implementation files that conditionally use the wallet.
2013-12-04 12:46:13 +01:00
Wladimir J. van der Laan 991685d3dc Move getinfo to rpcnet.cpp
Where to place `getinfo` is a difficult issue
as it shows information from the wallet, net and
block chain. However, I moved it out of rpcwallet
as the command needs also to be available without
wallet.
2013-12-04 12:46:13 +01:00
Wladimir J. van der Laan bbb093652e Move HelpExample* from rpcwallet to rpcserver
General functions used throughout the RPC framework
don't belong in rpcwallet.
2013-12-04 12:46:12 +01:00
Wladimir J. van der Laan 00cfc9f074 Merge pull request #3355
6c98cca qt: use deleteLater to remove send entries (Wladimir J. van der Laan)
2013-12-04 09:42:09 +01:00
Wladimir J. van der Laan 6c98cca9e4 qt: use deleteLater to remove send entries
Use deleteLater() instead of delete, as it is not allowed
to delete widgets directly in an event handler.
Should solve the MacOSX random crashes on send with coincontrol.
2013-12-04 08:17:57 +01:00
Wladimir J. van der Laan f15bd3c96f Merge pull request #3285
d3207b6 [Qt] coin-control features GUI cleanup 3 (Philip Kaufmann)
834e14e [Qt] coin-control features GUI cleanup 2 (Philip Kaufmann)
2013-12-03 17:26:45 +01:00
Wladimir J. van der Laan 0b47fe6bdc bitcoin-cli: remove unneeded dependencies (only code movement)
Remove unnecessary dependencies for bitcoin-cli
(leveldb, berkelydb, wallet, RPC server)

Build system changes:
- split libbitcoin.a into libbitcoin_common.a, libbitcoin_server.a and
  libbitcoin_cli.a

Code changes (movement only):
- split up HelpMessage into HelpMessage in init.cpp and HelpMessageCli
  in rpcclient.cpp
- move uiInterface from init.cpp to util.cpp
2013-12-03 09:07:13 +01:00
Wladimir J. van der Laan b9988c9e74 Merge pull request #3339
bae6c7e Fix a rare crash on Mac OS X, by removing a setFocus on the payTo field that was not necessary, as the field still receives focus without it. (Ryan Niebur)
2013-12-02 08:52:54 +01:00
Wladimir J. van der Laan 40ad6e7f35 Merge pull request #3306
84b695c [Qt] allow deletion of payment-requests in sendcoins (Philip Kaufmann)
2013-12-01 13:02:14 +01:00
Wladimir J. van der Laan e7e8a7537a Merge pull request #3309
9ac5a01 Move types.h include before ifaddres.h for u_int declaration (Robert Backhaus)
2013-11-29 10:34:38 +01:00
Wladimir J. van der Laan 5c56ee1ace Merge pull request #3328
9d2b73d bitcoin-cli: Add missing SelectParamsFromCommandLine (Wladimir J. van der Laan)
2013-11-29 07:56:05 +01:00
Wladimir J. van der Laan 207cfbfbf1 Merge pull request #3295
9e7776b Integration tests via RPC calls (Gavin Andresen)
2013-11-28 18:28:42 +01:00
Wladimir J. van der Laan 9d2b73d19f bitcoin-cli: Add missing SelectParamsFromCommandLine
The SelectParamsFromCommandLine call was missing in bitcoin-cli,
which caused `-testnet` and `-regtest` to be ignored. Add this
call just like in bitcoind.cpp.
2013-11-28 17:37:01 +01:00
Wladimir J. van der Laan 4ae42d43a4 Merge pull request #3321
0078841 prevent Windows redefinition warning cause by compat.h (Philip Kaufmann)
2013-11-28 08:41:23 +01:00
Wladimir J. van der Laan 5f083afde1 Merge pull request #3284
fb78cc2 Split up bitcoinrpc (code movement only) (Wladimir J. van der Laan)
2013-11-27 14:16:36 +01:00
Wladimir J. van der Laan e1169d7eea Merge pull request #3296
a946aa8 Store and use a sanitized subVer (Mike Hearn)
ba6a4ea Add some additional logging to give extra network insight. (Mike Hearn)
2013-11-27 10:40:54 +01:00
Wladimir J. van der Laan 2fc12794c2 Merge pull request #3319
871ac37 qt: restore icon dock menu (theuni)
2013-11-27 06:28:22 +01:00
Wladimir J. van der Laan fb78cc2378 Split up bitcoinrpc (code movement only)
Split bitcoinrpc up into

- rpcserver: bitcoind RPC server
- rpcclient: bitcoin-cli RPC client
- rpcprotocol: shared common HTTP/JSON-RPC protocol code

One step towards making bitcoin-cli independent from the rest
of the code, and thus a smaller executable that doesn't have to
be linked against leveldb.

This commit only does code movement, there are no functional changes.
2013-11-27 06:00:29 +01:00
Wladimir J. van der Laan 03b6a1cee4 Merge pull request #3316
106f133 Fix uninitialized variable added in b33b9a6fe (theuni)
2013-11-26 07:57:00 +01:00
Wladimir J. van der Laan 4c3e24644d Merge pull request #3294
c8b7425 setgenerate creates multiple blocks in -regtest mode (Gavin Andresen)
2013-11-25 15:47:20 +01:00
Wladimir J. van der Laan d4cda964d2 Merge pull request #3302
e5adec3 contrib: add sipa's github-merge script (Wladimir J. van der Laan)
2013-11-24 12:45:12 +01:00
Wladimir J. van der Laan e5adec35c6 contrib: add sipa's github-merge script 2013-11-24 12:44:31 +01:00
Wladimir J. van der Laan eef8a67abf Merge pull request #3300
848fe68 cleanup error message consistency (Julian Langschaedel)
2013-11-24 12:40:39 +01:00
Wladimir J. van der Laan be5d37c597 Merge pull request #3273
fb0507f qt: show all units in send confirmation (Wladimir J. van der Laan)
2013-11-22 05:42:31 +01:00
Wladimir J. van der Laan 76cfa60222 Merge pull request #3299
c89d59c Remove '/': prefix always starts with '/' (Florin)
2013-11-22 05:42:06 +01:00
Wladimir J. van der Laan 35454b35d8 Merge pull request #3287
67448b2 [Qt] make a UI element in sendcoins non-validated (Philip Kaufmann)
2013-11-21 11:44:52 +01:00
Wladimir J. van der Laan f7e88c39d7 Merge pull request #3293 from onlyjob/master
Provide build time when building from tarball:
2013-11-20 23:08:37 -08:00
Wladimir J. van der Laan d980f9b7d6 Merge pull request #3257
379778b core: remove includes in .cpp, if header is already in .h (Philip Kaufmann)
2013-11-20 16:18:33 +01:00
Wladimir J. van der Laan 96aaf006a5 Merge pull request #3234 from super3/master
Remove Wallet Tools
2013-11-19 10:25:42 -08:00
Wladimir J. van der Laan 666893b1fa qt: keep a list of requested payments
Keep a list of requested payments in the Receive tab so that a user can
recall previously created requests after closing their windows.

Currently this list is not stored between bitcoin-qt sessions. This can
be implemented later, but it is not clear where it should be stored as
I don't think it belongs in the wallet (maybe in QSettings?)
2013-11-19 14:07:38 +01:00
Wladimir J. van der Laan 993a50b683 Merge pull request #3278 from laanwj/2013_11_boost_m4
Update boost m4 files
2013-11-19 04:43:01 -08:00
Wladimir J. van der Laan 71f97ea2a7 Merge pull request #3267
0689f46 Coincontrol cleanup (e.g. add missing license) (Philip Kaufmann)
2013-11-18 10:12:15 +01:00
Wladimir J. van der Laan 5235db2c1e Merge pull request #3275 from Michagogo/release-process-binary-sizes
Add additional data update to release-process.md
2013-11-18 00:24:58 -08:00
Wladimir J. van der Laan 8808435814 Merge pull request #3272
0e165b9 doc: small doxygen update (Wladimir J. van der Laan)
2013-11-18 08:49:39 +01:00
Wladimir J. van der Laan fb0507fe4b qt: show all units in send confirmation
Make users accustomed to the other subdivision units (mBTC, muBTC)
by showing the total amount in all units in the confirmation dialog.

This was recently raised on the mailing list and could be a preparation
for switching over the default unit eventually.
2013-11-17 14:43:23 +01:00
Wladimir J. van der Laan 0e165b97d9 doc: small doxygen update
I was merging change this every time before generation of
the doxygen developer docs (https://dev.visucore.com/bitcoin/doxygen/)
but there's no reason why it can't just be merged upstream.
2013-11-17 14:17:39 +01:00
Wladimir J. van der Laan af6e093f06 Merge pull request #3268
79fac3f [Qt] use GUIUtil::setClipboard() where possible (Philip Kaufmann)
2013-11-17 10:18:58 +01:00
Wladimir J. van der Laan 3443adecf1 Merge pull request #3253
6a86c24 Coin Control Features (Cozz Lovan)
8dfd8c6 pass nBytes as parameter to GetMinFee(..) (Cozz Lovan)
2013-11-16 09:55:07 +01:00
Wladimir J. van der Laan 0b4bd485ba Merge pull request #3255
309f796 [Qt] make most Windows appear centered on main GUI (Philip Kaufmann)
2013-11-16 09:27:23 +01:00
Wladimir J. van der Laan 5082b50a65 Merge pull request #3258
fabba0e orphan spaces cleanup ;-) (Philip Kaufmann)
2013-11-15 13:57:45 +01:00
Wladimir J. van der Laan 4fc241235c Merge pull request #3252 from laanwj/2013_11_transifex_pull
qt: language update from transifex
2013-11-14 23:59:05 -08:00
Wladimir J. van der Laan 04744b8b54 Merge pull request #3248 from laanwj/2013_11_overviewpage_align
qt: align amounts on overview page to the right
2013-11-14 23:57:24 -08:00
Wladimir J. van der Laan 22d1ac44dc qt: language update from transifex
Adds three new languages:

- de_AT: German (Austria)
- gl: Galician
- sl_SI: Slovenian (Slovenia)

Updates many others.

Thanks to the translators contributing on Transifex!
2013-11-14 14:58:06 +01:00
Wladimir J. van der Laan 79afdd1869 qt: align amounts on overview page to the right
This is more consistent with other places in the GUI.
2013-11-14 09:23:43 +01:00
Wladimir J. van der Laan 6ad44f5693 configure: lupdate is not needed for Qt build
Don't require lupdate to build with Qt. Like xgettext it is only
needed to update translations, not for normal builds.

This fixes the gitian build (broken by fcfbf547d).
2013-11-14 08:59:43 +01:00
Wladimir J. van der Laan 5ce4361077 Merge pull request #3244 from laanwj/2013_11_mingw_c99_printf
Use C99 printf statements in mingw
2013-11-13 08:58:36 -08:00
Wladimir J. van der Laan 194aa6cfdf Merge pull request #3246 from laanwj/2013_11_rpc_help
Clean up RPC help messages (rebased)
2013-11-13 08:23:38 -08:00
Wladimir J. van der Laan c82788efff tests: add testcases for strprintf 2013-11-13 17:02:27 +01:00
Wladimir J. van der Laan d6f690f7da Use C99 printf statements in mingw
Otherwise, format specifiers such as %llu will not work on XP or
earlier.
This bug was introduced with 51ed9ec9.
http://sourceforge.net/apps/trac/mingw-w64/wiki/gnu%20printf
2013-11-13 17:02:27 +01:00
Wladimir J. van der Laan 2830a9051d Merge pull request #3240 from laanwj/2013_11_rebase_no_wallet
Introduce disable-wallet / no-wallet mode (rebased)
2013-11-13 04:35:12 -08:00
Wladimir J. van der Laan 146ba964e4 qt: GUI support for -disablewallet mode 2013-11-13 09:22:00 +01:00
Wladimir J. van der Laan d6c434d97e Merge pull request #3241 from laanwj/2013_11_uri_scheme_case_insensitive
qt: make URI scheme comparison case insensitive
2013-11-12 08:21:25 -08:00
Wladimir J. van der Laan b3e579713f qt: make URI scheme comparison case insensitive
Fixes ancient issue #1460.
2013-11-12 16:40:09 +01:00
Wladimir J. van der Laan abf34606c0 Merge pull request #3238 from Diapolo/guiutil
[Qt] remove GUIUtil::getSaveFileName() default arguments
2013-11-12 00:37:27 -08:00
Wladimir J. van der Laan 309f783fce Merge pull request #3235 from Diapolo/misc
misc small changes to polish after include cleanup
2013-11-12 00:34:15 -08:00
Wladimir J. van der Laan a6aa179699 Merge pull request #3187 from Diapolo/netManager
[Qt] paymentserver: start netManager in uiReady()
2013-11-11 07:00:34 -08:00
Wladimir J. van der Laan 2b8c4410c1 Merge pull request #3138 from super3/master
Squash README
2013-11-11 05:37:24 -08:00
Wladimir J. van der Laan c2468c1542 Merge pull request #3215 from laanwj/2013_11_openuridialog
qt: add Open URI dialog
2013-11-11 05:33:43 -08:00
Wladimir J. van der Laan 4c60358604 qt: add Open URI dialog 2013-11-11 14:29:49 +01:00
Wladimir J. van der Laan 3a8915d9a8 doc: replace DOS with MSYS shell to be more consistent
A plain DOS window doesn't have the right path settings, whereas
the MSYS shell window does.
2013-11-11 13:47:19 +01:00
Wladimir J. van der Laan bb8f9179ad Merge pull request #3233 from laanwj/2013_11_autoconf
Autoconf improvements
2013-11-11 04:42:24 -08:00
Wladimir J. van der Laan 59be91ae1e Merge pull request #3231 from brandondahler/doc-autotool-update
Update build docs that refer to old makefile.* files.
2013-11-11 00:59:38 -08:00
Wladimir J. van der Laan fb4a31a26c Merge pull request #3232 from laanwj/2013_11_ubuntu1310
doc: add note about building on Ubuntu 13.10
2013-11-11 00:50:22 -08:00
Wladimir J. van der Laan 7a6fed86d3 doc: add note about building on Ubuntu 13.10
Also mention `autoconf` as required package.
2013-11-11 09:10:16 +01:00
Wladimir J. van der Laan 995cb284cf Merge pull request #3223 from TheBlueMatt/master
Test changes
2013-11-08 09:48:30 -08:00
Wladimir J. van der Laan 9a165e5714 Merge pull request #3155 from wtogami/split_proto_var
Split MIN_PROTO_VERSION into INIT_PROTO_VERSION and MIN_PEER_PROTO_VERSION
2013-11-08 01:03:11 -08:00
Wladimir J. van der Laan 7f0ccea768 Merge pull request #3222 from Diapolo/debug-window
[Qt] rename rpcconsole window
2013-11-08 00:32:43 -08:00
Wladimir J. van der Laan b744fdbf52 Merge pull request #3209
a80b1a0 [Qt] make event() and eventFilter() in askpassphrasedialog protected (Philip Kaufmann)
2013-11-07 13:53:26 +01:00