DragonX/dragonx
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 4 Wiki Activity
7,256 Commits 6 Branches 7 Tags
ab9edbd6b6eb3efbca11f16fa467c3c0ef905708
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Philip Kaufmann b4347f6035 minor code style cleanup after recent merges 
- add a missing license header
- correct some header orderings etc.
 2014-11-04 14:36:46 +01:00
Philip Kaufmann 771d500283 minor cleanup: include orders, end comments etc. 
- no code changes
 2014-10-31 09:41:15 +01:00
Philip Kaufmann 981f7907c4 [Qt] fix slot connection problems when no wallet is loaded 
- guard 4 connect calls by an #ifdef when no wallet is loaded to fix "No
  such slot" warnings
- also add comments when #ifdef ENABLE_WALLET end
- fixes #5175
 2014-10-30 09:31:36 +01:00
Philip Kaufmann de10efd154 add -timeout default as constant and use them 
- update help message text
- simplify code in init to check for -timeout
 2014-10-06 13:13:25 +02:00
Philip Kaufmann 4dc5eb057c fix a lock indentation in main.cpp 
- also ensure alphabetical ordering in file header
 2014-10-06 13:04:02 +02:00
Philip Kaufmann 5eed8c21c7 minor license, header end comment etc. cleanup in /script 
- ensure all licenses are just MIT
- add a missing header end comment
- ensure alphabetical ordering
 2014-10-06 13:00:55 +02:00
Philip Kaufmann 4bd1185280 Qt: allow "emergency" shutdown during startup 
- allows closing our splash screen to abort startup
 2014-10-02 11:26:36 +02:00
Philip Kaufmann e2efdf3937 amount.h: update license, add header end comment + rem from util.h 2014-10-02 11:25:21 +02:00
Philip Kaufmann 938bccebf1 CAutoFile: make file private 2014-10-02 10:59:28 +02:00
Philip Kaufmann 0c35486dc9 CBufferedFile: add explicit close function 
- also use identical close function for CAutoFile (avoids setting file to
  NULL under wrong conditions)
 2014-10-02 10:56:10 +02:00
Philip Kaufmann c9fb27da0a CBufferedFile: convert into a non-refcounted RAII wrapper 
- it now takes over the passed file descriptor and closes it in the
  destructor
- this fixes a leak in LoadExternalBlockFile(), where an exception could
  cause the file to not getting closed

- disallow copies (like recently added for CAutoFile)
- make nType and nVersion private
 2014-10-02 10:46:31 +02:00
Philip Kaufmann c375b5c102 remove dead/unused code in walletdb.cpp 
- closes #5021
 2014-10-01 11:00:29 +02:00
Philip Kaufmann b5ec5fe0cb update getnetworkinfo help with subversion 
- add missing subversion field to getnetworkinfo help
- fix style and format errors in help string
- remove unneeded int casts
 2014-10-01 10:23:00 +02:00
Philip Kaufmann d0c4197ef6 change exit(1) to an assert in CWallet::EncryptWallet 2014-10-01 08:50:24 +02:00
Philip Kaufmann 870da77da6 fix possible memory leaks in CWallet::EncryptWallet 
- add missing deletes for pwalletdbEncryption
- add an assert before trying to reserve memory for pwalletdbEncryption
- add a destructor to CWallet, which ensures deletion of
  pwalletdbEncryption on object destruction
 2014-10-01 08:48:23 +02:00
Philip Kaufmann f606bb9baf fix a possible memory leak in CWalletDB::Recover 
- convert pdbCopy into a boost::scoped_ptr to ensure memory gets freed
  in all cases (e.g. after "ret > 0")
 2014-10-01 08:48:22 +02:00
Philip Kaufmann 7bec6dd230 cleanup license and header end comment in chain.cpp/.h 2014-09-29 08:22:03 +02:00
Philip Kaufmann 0db65d8798 update license of compat and crypto 
- change license to be just MIT for all files in compat and crypto
- also add missing header end comments
- ensure default header include style
 2014-09-29 08:21:11 +02:00
Philip Kaufmann 20a11ffabf minor variable init changes in init.cpp 
- explicit init of pcoinsdbview and pwalletMain (even if not needed, as
  globals are init to NULL, it seems cleaner)
- remove check if (pwalletMain) in Shutdown() as delete is valid even if
  pwalletMain is NULL
 2014-09-25 13:49:49 +02:00
Philip Kaufmann e6beedc496 [Qt] add more NULL pointer checks in bitcoingui 
- add missing checks for clientModel and optionsModel
- small cleanups for an #ifdef on Mac
- remove an unneeded else
 2014-09-25 09:16:45 +02:00
Philip Kaufmann bb26e2c896 [Qt] minor changes in splashscreen.cpp 
- guard an unused variable with Q_UNUSED() macro
- remove a commented out line of code
 2014-09-23 09:56:46 +02:00
Philip Kaufmann 2e5361b9c2 remove code below asserts in limitedmap.h (fixes a ToDo) 2014-09-22 09:35:40 +02:00
Philip Kaufmann 5e83bc404c [Qt] include and file header cleanup 
- alphabetical ordering
- correct ordering own headers before normal headers etc.
 2014-09-18 14:11:44 +02:00
Philip Kaufmann 93f84d0417 cleanup class private and public areas in walletdb 
- only code movement
 2014-09-18 07:21:49 +02:00
Philip Kaufmann 22d7e7014f prefer const string& over char* in CDB and CWalletDB constructor 
- also make parameter of CDBEnv::CheckpointLSN a constant reference
 2014-09-18 07:21:49 +02:00
Philip Kaufmann f4fe205034 add nModSize init to default constructor of CTxMemPoolEntry 2014-09-16 15:07:45 +02:00
Philip Kaufmann ee304b6e35 minor changes for help message of getpeerinfo 2014-09-16 09:00:36 +02:00
Philip Kaufmann 611116d4e3 header include cleanup 
- ensures alphabetical ordering for includes etc. in source file headers
 2014-09-14 12:43:56 +02:00
Philip Kaufmann 2d79bba36b cleanup new script files (no code changes) 
- add missing header end comments
- ensure alphabetical ordering
- update copyright year and license
 2014-09-14 12:25:38 +02:00
Philip Kaufmann faadbe1733 remove unneeded cast in rpcmisc.cpp 2014-09-09 19:23:29 +02:00
Philip Kaufmann 2c2cc5dac1 Remove some unnecessary c_strs() in logging and the GUI 
Includes `core: remove unneeded c_str() / Qt: replace c_str() with Qt code`
by P. Kaufmann.
 2014-09-09 11:31:17 +02:00
Philip Kaufmann 2605b94d73 [Qt] update form files for setting autoDefault explicitly to false 
- also fixes indentation in one file (auto fixed by Qt Designer)
- removes several default parameters, which are not needed in the files
- related to #4840 (but not intended as fix for a no-bug)
 2014-09-05 13:54:16 +02:00
Philip Kaufmann 1ffb99b07f [Qt] copyright, style and indentation cleanup of Qt tests 2014-09-05 13:23:21 +02:00
Philip Kaufmann a264e445ff remove dup include of foreach.hpp in script.cpp 2014-09-05 09:49:57 +02:00
Philip Kaufmann fbe0fcae76 [Qt] minor watch-only changes 
- use watch-only, not watchonly
- add back a tooltip hint when hovering addresses and attach
  "(watch-only)" at the end
 2014-08-28 23:20:46 +02:00
Philip Kaufmann bbad683224 [Qt] simplify return code and return values in txtablemodel 
- also move an added space in a string where it belongs
 2014-08-28 23:14:11 +02:00
Philip Kaufmann 21f1516468 [Qt] add all used colors in txtablemodel to guiconstants 
- add colors used in TX status decoration
 2014-08-28 23:14:10 +02:00
Philip Kaufmann 187115c01d cleanup include of assert.h 2014-08-28 23:02:49 +02:00
Philip Kaufmann 4d04492bf2 add missing copyright headers 2014-08-28 22:26:56 +02:00
Philip Kaufmann 093303a887 add missing header end comments 
- ensures a consistent usage in header files
- also add a blank line after the copyright header where missing
- also remove orphan new-lines at the end of some files
 2014-08-28 22:25:21 +02:00
Philip Kaufmann 22b3c4bbbd remove unused class CAddrMan; from db.h 2014-08-10 14:30:30 +02:00
Philip Kaufmann b197bf3270 [Qt] disable tray interactions when client model set to 0 
- this prevents the ability to fiddle around with the system tray when
  already shutting down (e.g. on slow shutdowns because of a proxy delay)
- extends solution for #4360
 2014-08-08 12:13:39 +02:00
Philip Kaufmann 314fbd9ac7 [Qt] use BitcoinGUI::DEFAULT_WALLET constant in bitcoin.cpp 2014-08-08 12:13:27 +02:00
Philip Kaufmann 8ca6a16176 [Qt] ensure all class attributes are init to 0 
- in BitcoinGUI and UnitDisplayStatusBarControl
 2014-08-08 12:13:26 +02:00
Philip Kaufmann c4bae53092 [Qt] move SubstituteFonts() above ToolTipToRichTextFilter 
- doesn't belong to the ToolTipToRichTextFilter class so move it up
 2014-08-08 11:04:35 +02:00
Philip Kaufmann 94e1b9e05b [Qt] re-work overviewpage UI 
- ensure normal and watch-only stuff looks consistent
- simplify UI by removing unneeded UI layout elements
- change some comments to watch-only from watchonly
 2014-08-08 09:58:58 +02:00
Philip Kaufmann efd6b87811 small net cleanup 
- add comment for disabling sigpipe
- add closing comment in compat.h
- remove redundant check in net.h
 2014-08-08 07:40:45 +02:00
Philip Kaufmann a409467e14 more Bitcoin -> Bitcoin Core string changes 2014-08-04 21:09:38 +02:00
Philip Kaufmann ead6737b87 [Qt] format ping times in peers tab as ms 
- also align ping times to the right
 2014-08-04 19:23:57 +02:00
Philip Kaufmann a5b2d9c82e [Qt] tweak new peers tab in console window 
- remove starting height as table header and replace with ping time
- remove columnResizingFixer
- add local address (if available) in detailed node view (on top of the
  right view below the remote address)
- remove some .c_str() by using QString::fromStdString()
- rename Address to Address/Hostname
- rename secs to just s for ping time
- use MODEL_UPDATE_DELAY from guiconstants.h for the peer refresh time
- make PeerTableModel::columnCount() return no hard-coded value
- remove and cleanup dup private: section in RPCConsole header
- add new defaults for column sizes
- remove behaviour which keeps disconnected peers selected and also remove
  code which keeps track of last selected peer stats
- add sync height to detail view
- add some additional NULL pointer checks for clientModel in
  rpcconsole.cpp
 2014-08-04 15:46:18 +02:00
Philip Kaufmann 2b600992e8 add license header to core_io.h, core_read/_write.cpp 2014-08-01 08:39:06 +02:00
Philip Kaufmann 1b73d36b2c fix compilation error in core_io.h 
- error: 'vector' in namespace 'std' does not name a type
- add <vector> include in core_io.h
- remove <vector> includes from core_read.cpp and core_write.cpp
 2014-08-01 08:38:23 +02:00
Philip Kaufmann 283a3b88b6 small ordering cleanup of init help message 2014-08-01 08:04:46 +02:00
Philip Kaufmann d817187bdb [Qt] remove ProxySocksVersion from OptionID 
- we only support SOCKS5, so remove it
 2014-07-28 14:47:27 +02:00
Philip Kaufmann f65352a7d0 [Qt] small Qt-only include cleanup 2014-07-25 17:43:41 +02:00
Philip Kaufmann f469f79ff8 remove an unneded .c_str() in OpenNetworkConnection() 2014-07-21 15:00:42 +02:00
Philip Kaufmann c994d2e769 prevent SOCKET leak in BindListenPort() 
- the call to CloseSocket() is placed after the WSAGetLastError(), because
  a CloseSocket() can trigger an error also, which we don't want for the
  logging in this two cases
 2014-07-17 22:49:23 +02:00
Philip Kaufmann eaedb59e05 net: add SetSocketNonBlocking() as OS independent wrapper 2014-07-17 22:12:44 +02:00
Philip Kaufmann 7de3f1cfd6 fix help message for RPC getpeerinfo 2014-07-17 15:10:29 +02:00
Philip Kaufmann 4eedf4ffee make RandAddSeed() use OPENSSL_cleanse() 
- removes the cstring include and is also used in RandAddSeedPerfmon()
 2014-07-09 09:43:55 +02:00
Philip Kaufmann 6354935c48 move rand functions from util to new random.h/.cpp 2014-07-09 09:42:19 +02:00
Philip Kaufmann 001a53d742 add GetRandBytes() as wrapper for RAND_bytes() 
- add a small wrapper in util around RAND_bytes() and replace with
  GetRandBytes() in the code to log errors from calling RAND_bytes()
- remove OpenSSL header rand.h where no longer needed
 2014-07-09 09:42:18 +02:00
Philip Kaufmann 00d1980b8f init.cpp: log fee estimates filename on error 
- small changes to Shutdown(), buffer __func__, which is now used in
  all LogPrintf() calls and format for better readability
- order using namespace alpabetically
 2014-07-09 09:22:36 +02:00
Philip Kaufmann a339a37b28 error out, when we detect -socks argument 2014-07-07 08:15:14 +02:00
Philip Kaufmann 0127a9be14 remove SOCKS4 support from core and GUI 
- now we support SOCKS5 only
 2014-07-07 08:15:14 +02:00
Philip Kaufmann 674c070e5d [Qt] seed OpenSSL PNRG with Windows event data 
- see https://bitcointalk.org/index.php?topic=113496.msg1228193#msg1228193
  for the initial suggestion for this
- also ensure consistent debug.log message format
 2014-07-04 17:16:36 +02:00
Philip Kaufmann 3d0e92dc83 [Qt] remove dup includes in bitcoingui 2014-07-04 16:51:25 +02:00
Philip Kaufmann 8d9cc7d743 fix copyright string in two of our *.rc files 
- also make comment about rc-files in clientversion.h generic

Merges #4429.
 2014-07-01 12:13:37 +02:00
Philip Kaufmann 33c62c9c0b set shutdown title to main window title 
- this ensures we don't show Bitcoin-Qt as that is still our
  internal application name
- fixes #4427
 2014-06-27 15:09:41 +02:00
Philip Kaufmann 40a158e100 minor code format fix in rpc-related files 2014-06-27 11:13:25 +02:00
Philip Kaufmann 86fe1b864b update coding.md to reflect changes by pull 
- also mention alphabetical include ordering
 2014-06-26 11:56:56 +02:00
Philip Kaufmann cf04d83624 add OpenSSL RAND_cleanup() on OpenSSL shutdown 
- to securely erase the memory used by the PNRG
- also rework 2 comments in OpenSSL init
 2014-06-26 11:04:31 +02:00
Philip Kaufmann 5d59921237 add missing BOOST_FOREACH indentation in ThreadSocketHandler() 2014-06-26 11:01:24 +02:00
Philip Kaufmann 9e9ca2b671 small cleanup of #ifdefs in BindListenPort() 
- SO_NOSIGPIPE isn't available on WIN32 so merge the 2 non-WIN32 blocks
- use predefined names from header for IPV6_PROTECTION_LEVEL and
  PROTECTION_LEVEL_UNRESTRICTED
 2014-06-26 11:01:23 +02:00
Philip Kaufmann e10dcf27b4 ensure clean and consistent "namespace" usage 
- remove some missplaced ;
- ensure end of a namespace is clearly visible
- use same formatting when using namespace
 2014-06-26 10:36:57 +02:00
Philip Kaufmann 5fbb4c9b58 [Qt] fix links in about window not opening 
- closes #4402
 2014-06-24 16:36:14 +02:00
Philip Kaufmann 1c750dbd40 remove -tor compatibility code (only allow -onion) 
- exit, if -tor option is found and give error to user
 2014-06-24 16:07:20 +02:00
Philip Kaufmann 6dc90ed8fa replace 3 separate calls to WSAGetLastError() with 1 2014-06-24 08:46:12 +02:00
Philip Kaufmann 6a5c124b84 [Qt] don't allow translation of our example btc address 2014-06-23 15:11:28 +02:00
Philip Kaufmann b612bde521 remove unneded class CNodeCombinedStats; from rpcconsole.cpp 
- also 2 small style fixes
 2014-06-23 08:06:52 +02:00
Philip Kaufmann 3dc1464f0a add missing vhListenSocket.clear(); to CNetCleanup() 2014-06-22 14:52:38 +02:00
Philip Kaufmann 2831a03b79 remove unused CNode::Cleanup() 2014-06-22 14:51:38 +02:00
Philip Kaufmann 0655fac0b1 miner: indentation fixes, remove for (;;) 
- change a for (;;) into while (true), as we nowhere else use the first
- init nNonceFound to 0
- fix indentation in BitcoinMiner try/catch block
 2014-06-22 00:33:42 +02:00
Philip Kaufmann fc0c07eb64 small cleanup in src/compat .h and .cpp 
- add license header
- fix include guards
- fix indentation
 2014-06-21 14:39:17 +02:00
Philip Kaufmann 1020f599f3 add comment to HelpMessage() to ensure alphabetical ordering 
- also rename hmm to mode, to be consistent between .h and .cpp
 2014-06-17 09:17:12 +02:00
Philip Kaufmann 6763018797 [Qt] rename In:/Out: to Received/Sent in traffic tab 
- collides with In:/Out: used for displaying number of
  connections when translating
 2014-06-16 08:23:45 +02:00
Philip Kaufmann f5ae6c9826 add NetworkIDString() to chainparams 
- returns the BIP70 network string
- use that new function in the core and GUI code and remove unused code
  and functions
 2014-06-12 13:19:12 +02:00
Philip Kaufmann f3790472f0 remove unused code from getblockchaininfo() 2014-06-11 14:56:08 +02:00
Philip Kaufmann 634bd61b76 convert an if into an else if in OpenNetworkConnection() 2014-06-11 12:40:13 +02:00
Philip Kaufmann 5bd6c31bd6 small cleanup of net 
- remove an unneded else in ConnectNode()
- make 0 a double and change to 0.0 in ConnectNode()
- rename strDest to pszDest in OpenNetworkConnection()
- remove an unneded call to our REF() macro in BindListenPort()
- small style cleanups and removal of unneeded new-lines
 2014-06-11 12:38:31 +02:00
Philip Kaufmann 4aaa01783d rework help messages for fee-related options 
- mention the units and show the default for -paytxfee
 2014-06-11 12:16:26 +02:00
Philip Kaufmann 56b07d2dcd [Qt] allow setting listen via GUI 
- add DEFAULT_LISTEN in net.h and use in the code (shared
  setting between core and GUI)

Important: This makes it obvious, that we need to re-think the
settings/options handling, as GUI settings are processed before
any parameter-interaction (which is mostly important for network
stuff) in AppInit2()!
 2014-06-11 12:04:17 +02:00
Philip Kaufmann 699fe635c6 remove wrong ; in chainparams.h and order includes 2014-06-10 19:33:12 +02:00
Philip Kaufmann 1c24187b51 remove unused UPnP code from main.h 2014-06-10 18:34:35 +02:00
Philip Kaufmann ac14bcc1f1 small formatting, indentation and comment fixes 
- contains zero code changes
 2014-06-10 18:23:56 +02:00
Philip Kaufmann fe6bff2eae [Qt] add BerkeleyDB version info to RPCConsole 
- to match info function between debug.log and RPCConsole
 2014-06-04 22:00:59 +02:00
Philip Kaufmann 5bd02cf715 log used config file to debug.log on startup 2014-06-04 21:19:22 +02:00
Philip Kaufmann bbe1925ce3 [Qt] style police and small addition in rpcconsole 
- fix spaces, indentation and coding style glitches
 2014-06-03 15:01:50 +02:00
Philip Kaufmann cb7a3edc3d remove dup of extern int nConnectTimeout; in netbase 2014-05-31 12:04:34 +02:00
Philip Kaufmann 53a088154c rename fNoListen to fListen and move to net 
- better code readability and it belongs to net
- this is a prerequisite for a pull to add -listen to the GUI
 2014-05-29 14:01:39 +02:00