DragonX/dragonx
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 4 Wiki Activity
12,910 Commits 6 Branches 7 Tags
dd67ab017e72afafc461a83db4defacecd381d21
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Simon 774489569a Increase timeout for z_sendmany transaction in wallet.py qa test 2017-01-18 16:54:39 -08:00
Simon bcbde86a87 Add missing header required by std::accumulate 2017-01-18 10:52:37 -08:00
Simon bab89e35c7 Update walletbackup.py qa test to use -exportdir option 2017-01-18 10:05:49 -08:00
Simon 8aa7937d44 Fixes #1960: z_getoperationstatus/result now includes operation details. 2017-01-16 16:45:27 -08:00
Simon f32cade8fd Closes #1957 by adding tx serialization size to listtransactions output. 2017-01-16 11:07:16 -08:00
Simon 9064d73bf8 Fixes #1497 ZCA-009 by restricting data exporting to user defined folder. 
Previously the RPC interface allowed z_exportwallet, backupwallet and
dumpwallet to write data to an arbitrary filename.  ZCA-009 demonstrates
how this is vulnerable.  The resolution is to only allow data to
written when the -exportdir has been configured.  Also filenames are
restricted to alphanumeric characters.
 2017-01-16 10:56:06 -08:00
Simon af02114469 Closes #1097 so zcash-cli now displays license info like zcashd. 
LicenseInfo is refactored from init.cpp to util.cpp so that the
bitcoin-cli makefile target does not need to be modified.
 2017-01-16 09:38:09 -08:00
Simon f1498d5829 Remove UTF-8 BOM efbbbf from zcash.conf to avoid problems with command line tools 2017-01-12 18:26:20 -08:00
Simon 2d2f3d1806 Closes #1780. Result of z_getoperationstatus now sorted by creation time of operation 2017-01-11 11:49:10 -08:00
Simon e466df9369 Bump COPYRIGHT_YEAR from 2016 to 2017. 2017-01-09 23:23:36 -08:00
Simon 4c1cd287be Fixes a bug where the unsigned transaction was logged by z_sendmany 
after a successful sign and send, meaning that the logged hash fragment
would be different from the txid logged by "AddToWallet".  This issue
occured when sending from transparent addresses, as utxo inputs must be
signed.  It did not occur when sending from shielded addresses.
 2017-01-04 12:26:23 -08:00
Simon 01f6c5dbee Fixes #1967 by adding age of note to z_sendmany logging. 2017-01-03 23:57:11 -08:00
Simon fce7260811 Fixes #1964 to catch general exception in z_sendmany and catch 
exceptions as reference-to-const.
 2017-01-03 12:50:19 -08:00
Simon 84e8c5f921 WitnessAnchorData only needs to store one witness per JSOutPoint. 2016-12-07 12:05:29 -08:00
Simon f3c4919027 Increase timeout as laptops on battery power have cpu throttling. 2016-12-05 10:46:12 -08:00
Simon 2d931e905b Fixes #1823. Witness anchors for input notes no longer cross block boundaries. 2016-12-03 00:22:42 -08:00
Simon af53da0225 Closes #1903. Add fee parameter to z_sendmany. 2016-11-30 14:23:35 -08:00
Simon e2a6161f4a Closes #1901. Increase default settings for the max block size when 
mining and the amount of space available for priority transactions.
 2016-11-29 10:01:20 -08:00
Simon 520ced1405 Closes #1857. Fixes bug where tx spending only notes had priority of 0. 2016-11-28 22:54:49 -08:00
Simon 2f1238bc51 Add checkpoint at block height 15000 2016-11-23 15:17:51 -08:00
Simon 4e3ac9b015 Fix stale comment referencing upstream block interval 2016-11-18 10:26:20 -08:00
Simon 26fb4db53b 1.0.3 Release 2016-11-17 16:07:09 -08:00
Simon 13e9a639b7 Fix threading issue when initializing public params. 2016-11-17 15:36:26 -07:00
Simon 27c2ccb880 Partial revert of bd87e8c: file release-notes-1.0.2.md to 343b0d6. 2016-11-16 21:16:29 -08:00
Simon 0afd3687c8 Closes #1854. z_sendmany selects more utxos to avoid dust change output. 2016-11-15 17:12:37 -08:00
Simon de38bfbbed Track the correct change witness across chained joinsplits 2016-11-15 12:39:16 -08:00
Simon 9ddb6ad028 Mempool will accept tx with joinsplits and the default z_sendmany fee. 
Issue #1851 shows that a zaddr->taddr can be rejected from mempools
due to not meeting fee requirements given the size of the transaction.
Fee calculation for joinsplit txs has not yet been agreed upon, so
during this interim period, this patch ensures  joinsplit txs using
the default fee are not rejected due to an insufficient fee.
 2016-11-15 11:32:59 -08:00
Simon ba0625f25d Set default minrelaytxfee to 1000 zatoshis to match upstream. 
A txout will be considered dust when it has a value <546 zatoshis.
Helps to address #1719.
 2016-11-15 10:48:51 -08:00
Simon f4404d7b5b Closes #1680, temporary fix for rpc deadlock inherited from upstream. 2016-11-15 00:31:24 -08:00
Simon 9384e74c50 Closes #1833. Format currency amounts in z_sendmany error message. 
Improve coverage of possible error states from z_sendmany.
Refactor qa test for z_sendmany operations.
 2016-11-10 16:57:36 -08:00
Simon 3920292b43 Add transaction size and zaddr output limit checks to z_sendmany. 2016-11-07 09:29:56 -08:00
Simon 38276c6ba2 Add GenIdentity, an identity function for MappedShuffle. 
We use this function in z_sendmany as part of the fix for #1779.
 2016-11-05 14:17:19 -07:00
Simon 7c463780cf Fixes #1779 so that sending to multiple zaddrs no longer fails. 
Commit 2eeb6b randomized the order of input and output notes,
but this is now known to prevent the chaining of multiple joinsplits
in a single transaction.  The root cause has yet to be determined.

This patch is a temporary fix and disables the shuffling of input
and output notes.  It also adds a chained joinsplit test to the
python qa test suite.
 2016-11-04 23:23:48 -07:00
Simon 5e9b555fed Fixes #1762 segfault when miner is interrupted. 
Running ./zcash-cli setgenerate false would result in a segfault.
The miner thread's boost::signals2::connection was not disconnected
when the miner thread was interrupted and shutdown.  Subsequently, when
a new block arrived, the UpdateTip callback would still be invoked on
a now invalid object, resulting in a segfault.
 2016-11-03 21:53:56 -07:00
Simon 4e16a7249c Closes #1746. Add rpc call z_validateaddress to validate zaddrs. 2016-10-31 20:05:48 -07:00
Simon 55d4f13bb7 Bump version number in sendalert.cpp 2016-10-26 12:00:43 -07:00
bitcartel 5cf1637ebf Update payment-api.md 2016-10-25 23:36:09 -07:00
Simon ad0ba9467d Add assert to AsyncRPCOperation_sendmany 2016-10-25 11:25:05 -07:00
Simon db026807b8 Add z_sendmany rule that when sending coinbase utxos to a zaddr 
they must be consumed entirely, without any change, since there
is currently no way to specify a change address in z_sendmany.
 2016-10-24 21:34:16 -07:00
Simon 10d1b90987 Fix incorrect error message in z_sendmany 2016-10-24 07:59:32 -07:00
Simon 432bc22ade Patch backport of upstream 1588 as we don't (yet) use the NetMsgType namespace 2016-10-22 09:49:35 -07:00
Simon e11e61ddb1 Workaround g++ 5.x bug with brace enclosed initializer. 
http://stackoverflow.com/questions/32912921/whats-wrong-with-this-inline-initialization-of-stdarray/32912976#32912976
 2016-10-21 21:50:25 -07:00
Simon 43f0769cf6 Fix build problem with coins_tests 2016-10-20 23:50:19 -07:00
Simon 5eed758493 Update test to use integer amount as well as decimal amount when calling z_sendmany 2016-10-20 17:10:25 -07:00
Simon 75407c6872 Fix issue where z_sendmany is too strict and does not allow integer based amount e.g. 1 which is the same as 1.0 2016-10-20 17:03:57 -07:00
Simon ffd2cb3437 Closes #1583 by setting up the datadir for the wallet gtest. 2016-10-20 16:45:02 -07:00
Simon 446f867b4c Add debug option "zrpcunsafe" to be used when logging more sensitive information such as the memo field of a note. 2016-10-20 15:24:31 -07:00
Simon e7b1f312f5 Add security warning about logging of z_* calls. 2016-10-20 15:24:31 -07:00
Simon ccc0f9af42 Fixes CID 1352714 uninitialized scalar variable. 2016-10-20 11:41:28 -07:00
Simon fed6c83ccf Fixes CID 1352727 uninitialized scalar variable. 2016-10-20 11:40:22 -07:00
Simon 351b38fd5b Fixes CID 1352599 unitialized scalar variable 2016-10-20 11:35:51 -07:00
Simon 43873535d4 Fixes CID 1352686 uninitialized scalar variable. 2016-10-20 11:28:22 -07:00
Simon 19bec4d9bb Fixes CID 1352715 uninitialized scalar field. 2016-10-20 11:25:36 -07:00
Simon b7727d8b3b Fixes CID 1352687 uninitialized scalar field. 2016-10-20 11:19:36 -07:00
Simon b1c1a32b3a Fixes CID 1352698 uninitialized scalar field. 2016-10-20 11:17:17 -07:00
Simon 9a4127e74c Fixes CID 1352706 uninitialized scalar field. 2016-10-20 11:05:30 -07:00
Simon 2da03f897b Fixes CID 1147436 uninitialized scalar field. 2016-10-20 11:01:46 -07:00
Simon 1218603f73 Update Debian changelog. 2016-10-17 11:52:55 -07:00
Simon cf8fe19c54 Update release notes for 1.0.0-rc1 2016-10-17 10:59:51 -07:00
Simon f7a624299d Update release version number for 1.0.0-rc1 2016-10-17 10:59:07 -07:00
Simon 2b1cda3b6a Return improved error message when trying to spend Coinbase coins (#1373). 
Extra parameter added to AvailableCoins to include or exclude Coinbase coins.
SelectCoins, used for sending taddr->taddr, will exclude Coinbase coins.

Added qa rpc test and a runtime parameter -regtestprotectcoinbase to enforce
the coinbase->zaddr consensus rule in regtest mode.
 2016-10-16 19:05:56 -07:00
Simon b13a87c6d7 Reorder gtests in zcash-gtest. 
There is an issue where checktransaction_tests will output errors to ~/.zcash/testnet3/debug.log
because other tests which run before it select the testnet chain parameters.
 2016-10-14 13:36:53 -07:00
Simon 6be367ea6d Fix test so that the encrypted wallet is output to the test_bitcoin -datadir folder. 2016-10-14 12:44:22 -07:00
Simon cb0d208f6b Document CWallet::GetFilteredNotes and fix return type which should be 
void.
 2016-10-13 17:01:54 -07:00
Simon 438d1e45be Use -debug=zrpc for z_* rpc calls (#1504) 2016-10-12 15:46:24 -07:00
Simon 5bd677f5c6 Rename client identifier from Satoshi to MagicBean (closes #1481) 2016-10-12 10:50:05 -07:00
Simon e346a0b3f8 Add tests to verify that all z_* rpc calls return an error if there are too many input parameters. 2016-10-12 10:15:12 -07:00
Simon 49e591eb89 Fix incorrect check of number of parameters for z_getnewaddress. 2016-10-12 10:14:32 -07:00
Simon 950f8ffdb6 Fixes #1491 by updating help message for rpc call z_importkey 2016-10-11 16:52:38 -07:00
Simon 32bf097f90 Fixes #1478 by ensuring wallet tests have the -datadir environment set appropriately. 2016-10-10 20:23:24 -07:00
Simon f7cfb52d3c Add vjoinsplit to JSON output of RPC call gettransaction 2016-10-06 19:53:46 -07:00
Simon 86cf60b5c8 Fixes #1345 so that UTXO debit and credits are computed correctly for a transaction. 2016-10-03 11:06:43 -07:00
Simon 4d11e5d2b9 Update mainnet addresses used for testing to have the correct number 2016-10-01 07:19:24 -07:00
Simon 2d6e97ecc5 Add field fMinerTestModeForFoundersRewardScript to chainparams 2016-09-30 18:31:51 -07:00
Simon 02acbfc262 Add mainnet 2-of-3 multisig addresses for testing. 2016-09-30 18:29:10 -07:00
Simon 6c54e9fc0b Update testnet founders reward addresses 2016-09-30 14:42:47 -07:00
Simon 88fd810150 Update founders reward test to output path of temporary wallet.dat file which contains keys which can be used for testing founders reward addresses. 2016-09-30 14:42:47 -07:00
Simon b7d072069e Update comment per review 2016-09-30 14:42:47 -07:00
Simon 22dadb35ec Refactor and fix per review 2016-09-30 14:42:47 -07:00
Simon 1a21a25e62 Refactor to add test to verify number of rewards each mainnet address will receive 2016-09-30 14:42:47 -07:00
Simon 241867b115 Founders reward: Refactor test and formatting per review. 2016-09-30 14:42:47 -07:00
Simon 3b30d8361a Founders reward: changed index computation, added new test and some refactoring. 2016-09-30 14:42:47 -07:00
Simon db0f931570 Add founders reward to ChainParams. 
Fix bug where subsidy slow shift was ignored.
 2016-09-30 14:42:47 -07:00
Simon 82bd9ee81b Fix comment and formatting per review 2016-09-29 22:07:38 -07:00
Simon 2aa9c0253a Update to use new API in CCryptoKeyStore and store a viewing key in walletdb. 2016-09-29 20:17:30 -07:00
Simon 73699ceaf6 Add support for spending keys to the encrypted wallet. 2016-09-29 20:17:30 -07:00
Simon eaccc007c9 Update test to filter and find notes. 2016-09-27 22:43:13 -07:00
Simon dec49d1f82 Fix GetFilteredNotes to use int for minDepth like upstream and avoid casting problems. Don't use FindMyNotes as mapNoteData has already been set on wallet tx. 2016-09-27 11:14:49 -07:00
Simon e63d14fd4d Replace %i format specifier with more commonly used %d. 2016-09-19 09:36:26 -07:00
de3dd8a015 Modify message string so we don't need to backport commits which implement FormatStateMessage and GetDebugMessage and involve changes to consensus/validation.h 2016-09-16 17:51:46 -07:00
0163f8faa2 Closes #1371 by updating signed message 2016-09-12 11:01:28 -07:00
Simon b11bb0e26a Replace GetTxid() with GetHash() 2016-09-08 21:54:34 -07:00
Simon 6114cfe767 Improve check that user supplied memo field is too long. 2016-09-08 21:46:15 -07:00
Simon e79ded8a47 Remove line of commented out code we don't need 2016-09-08 21:46:15 -07:00
Simon dfc0080d06 Update comment with ticket issue number 2016-09-08 21:46:15 -07:00
Simon 1eb8789789 Add assert 2016-09-08 21:46:15 -07:00
Simon ed42053a6c Fix formatting 2016-09-08 21:46:15 -07:00
Simon 2ad0b7bfe2 Use zcash constants 2016-09-08 21:46:15 -07:00
Simon b99d4f9b17 Improve error reporting when attempting to spend coinbase utxos. 2016-09-08 21:46:15 -07:00
Simon 9fb18458e8 Add assert for two mutually exclusive member variables. 2016-09-08 21:46:15 -07:00